bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

[Spencer Baugh]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Tags: patch


This is mildly prettier.


In GNU Emacs 29.1.50 (build 6, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-10-04 built on
 igm-qws-u22796a
Repository revision: 1f6accd7986dbafa8668bd16f56a22352b38a661
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.8 (Green Obsidian)

Configured using:
 'configure --config-cache --with-x-toolkit=lucid
 --with-gif=ifavailable'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-project-name-in-the-project-kill-buffers-prompt.patch --]
[-- Type: text/patch, Size: 970 bytes --]

From 98bffe5752a97aeaf7bb9592732e033d99e56bbe Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@janestreet.com>
Date: Fri, 13 Oct 2023 08:35:58 -0400
Subject: [PATCH] Use project-name in the project-kill-buffers prompt

This is mildly prettier.

* lisp/progmodes/project.el (project-kill-buffers): Use project-name.
---
 lisp/progmodes/project.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 0612b1a2e9a..c5843d40d41 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1620,7 +1620,7 @@ project-kill-buffers
                        (yes-or-no-p
                         (format "Kill %d buffers in %s? "
                                 (length bufs)
-                                (project-root pr))))))
+                                (project-name pr))))))
     (cond (no-confirm
            (mapc #'kill-buffer bufs))
           ((null bufs)
-- 
2.39.3

bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

[Philip Kaludercic]

Spencer Baugh <sbaugh@janestreet.com> writes:

> Tags: patch
>
>
> This is mildly prettier.

Could this cause confusion, in case two projects share the same name?

>
> In GNU Emacs 29.1.50 (build 6, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.15.12, Xaw scroll bars) of 2023-10-04 built on
>  igm-qws-u22796a
> Repository revision: 1f6accd7986dbafa8668bd16f56a22352b38a661
> Repository branch: emacs-29
> Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
> System Description: Rocky Linux 8.8 (Green Obsidian)
>
> Configured using:
>  'configure --config-cache --with-x-toolkit=lucid
>  --with-gif=ifavailable'
>
>>From 98bffe5752a97aeaf7bb9592732e033d99e56bbe Mon Sep 17 00:00:00 2001
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Fri, 13 Oct 2023 08:35:58 -0400
> Subject: [PATCH] Use project-name in the project-kill-buffers prompt
>
> This is mildly prettier.
>
> * lisp/progmodes/project.el (project-kill-buffers): Use project-name.
> ---
>  lisp/progmodes/project.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 0612b1a2e9a..c5843d40d41 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1620,7 +1620,7 @@ project-kill-buffers
>                         (yes-or-no-p
>                          (format "Kill %d buffers in %s? "
>                                  (length bufs)
> -                                (project-root pr))))))
> +                                (project-name pr))))))
>      (cond (no-confirm
>             (mapc #'kill-buffer bufs))
>            ((null bufs)

bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

[Dmitry Gutov]

On 13/10/2023 19:04, Philip Kaludercic wrote:
> Spencer Baugh<sbaugh@janestreet.com>  writes:
> 
>> Tags: patch
>>
>>
>> This is mildly prettier.
> Could this cause confusion, in case two projects share the same name?

I suppose this can indeed be problematic with the default backend, where 
project-name just returns the base name of the root directory (and they 
can conflict).

OTOH, we do use the project name as prefix for buffer names, for 
example. So this might be okay. Worst case, we add a user option later.

bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

[Spencer Baugh]

Dmitry Gutov <dmitry@gutov.dev> writes:
> On 13/10/2023 19:04, Philip Kaludercic wrote:
>> Spencer Baugh<sbaugh@janestreet.com>  writes:
>> 
>>> Tags: patch
>>>
>>>
>>> This is mildly prettier.
>> Could this cause confusion, in case two projects share the same name?
>
> I suppose this can indeed be problematic with the default backend,
> where project-name just returns the base name of the root directory
> (and they can conflict).
>
> OTOH, we do use the project name as prefix for buffer names, for
> example. So this might be okay. Worst case, we add a user option
> later.

My contention is that if the user is running this in the current
project, they already basically know where they are, they just need a
little reminder.  Plausibly not even that is necessary if they have
project-mode-line enabled.  And if they're running it in another
project, using project-switch-project, then they just explicitly
selected a project so we definitely don't need to tell them the full
path of the project they're running in.

bug#66518: [PATCH] Use project-name in the project-kill-buffers prompt

[Dmitry Gutov]

Version: 30.1

On 16/10/2023 21:48, Spencer Baugh wrote:
> My contention is that if the user is running this in the current
> project, they already basically know where they are, they just need a
> little reminder.  Plausibly not even that is necessary if they have
> project-mode-line enabled.  And if they're running it in another
> project, using project-switch-project, then they just explicitly
> selected a project so we definitely don't need to tell them the full
> path of the project they're running in.

That's a fair point.

Thank you, pushed to master, and closing.