From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#69584: 29.2.50; project-find-functions should have access to maybe-prompt Date: Thu, 04 Apr 2024 10:29:48 -0400 Message-ID: References: <65b29bab-3149-49e3-a6ae-6c0c1485e6f2@gutov.dev> <875xxmjoc9.fsf@catern.com> <34e15612-77bc-4a67-b493-e00c97d1155e@gutov.dev> <28cf57b9-de16-46a5-9bb8-918827143f72@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, 69584@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 04 16:31:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsO7d-0001jG-AX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Apr 2024 16:31:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsO7P-0007kr-Ux; Thu, 04 Apr 2024 10:31:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsO7J-0007jP-NC for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsO7G-0006u1-Bt for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 10:30:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsO7L-0003i7-3R for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 10:31:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2024 14:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69584 X-GNU-PR-Package: emacs Original-Received: via spool by 69584-submit@debbugs.gnu.org id=B69584.171224100213780 (code B ref 69584); Thu, 04 Apr 2024 14:31:03 +0000 Original-Received: (at 69584) by debbugs.gnu.org; 4 Apr 2024 14:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:34456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsO6L-0003a0-NN for submit@debbugs.gnu.org; Thu, 04 Apr 2024 10:30:02 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:53009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsO6J-0003Z4-7x for 69584@debbugs.gnu.org; Thu, 04 Apr 2024 10:30:00 -0400 In-Reply-To: <28cf57b9-de16-46a5-9bb8-918827143f72@gutov.dev> (Dmitry Gutov's message of "Thu, 28 Mar 2024 05:44:52 +0200") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1712240988; bh=sW2kz42F+7oOu3aEJk8oC8vvLwDV5SrBLQ2xPM22mLk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=kjjIz2tvjyVbvWZVnOb6Ib/4nqz9chSCWMpyCdNFQsUsoWSIxJQK/ITmH61vBQ166 upoNhXXYUzHVsafRBpuJTMG+mFXoJP2r79VBtiNAjJE2rs9lHlqouykOJz8xtz5j81 YkInAnJaixbgjgNBIiyPNW7PNovmejqG37rAcuEVAZpPqv9kvHlU77CeJ5dOpwhfak Y1lXxEpsSB0Qp8YqjTufvPZia1EonZnwn1fFnrDg1bJXcL6UOszJnSiiqM1O/7EidQ zI+aanrSasuE1gJebjlT44IZB8al8XFYJwvPbnefTnUEVLw0wfJt+Z1sEzHNaMNyTv EWdZHnuQ8ywyQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282659 Archived-At: Dmitry Gutov writes: > On 22/03/2024 15:05, Spencer Baugh wrote: >>> If this change will be enough to cover your scenario, let's go ahead >>> and add the 'non-essential' binding. It does seem to make sense for >>> Tramp, at least. >> Yes, that completely covers my scenario. (Putting aside whether my >> scenario is a good idea :) ) >> So I would be happy with that. > > Now pushed to master as commit 1552f8345d8. Ah, I think this is not quite right, should be: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 1da03c7b60e..3cd6dafb409 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -229,8 +229,8 @@ project-current of the project instance object." (unless directory (setq directory (or project-current-directory-override default-directory))) - (let ((pr (project--find-in-directory directory)) - (non-essential (not maybe-prompt))) + (let* ((non-essential (not maybe-prompt)) + (pr (project--find-in-directory directory))) (cond (pr) ((unless project-current-directory-override