From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Thu, 27 Jun 2024 09:35:34 -0400 Message-ID: References: <865xtu7seh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2042"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71504@debbugs.gnu.org, Eshel Yaron To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 15:36:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMpII-00006g-Rk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 15:36:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMpIA-0008Tk-Jf; Thu, 27 Jun 2024 09:36:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMpI8-0008TG-FC for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 09:36:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMpI7-0005GR-Ur for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 09:36:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMpI9-0001Fz-QH for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 09:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.17194953444803 (code B ref 71504); Thu, 27 Jun 2024 13:36:01 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 27 Jun 2024 13:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:41289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMpHs-0001FP-3F for submit@debbugs.gnu.org; Thu, 27 Jun 2024 09:35:44 -0400 Original-Received: from mxout6.mail.janestreet.com ([64.215.233.21]:49817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMpHq-0001FB-Sa for 71504@debbugs.gnu.org; Thu, 27 Jun 2024 09:35:43 -0400 In-Reply-To: <865xtu7seh.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Jun 2024 10:32:06 +0300") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1719495334; bh=uPebfm99fXIxdTw+rFik2U99G/AKbPLN5HtGjftvx4k=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=XelvV0i5liwsMyvfYig5NHvMD1mGZdlA5D8H0tkeOZrDsvfAEUXH8y2nHpSDnhfFY 0AntaYIrUlRf4W6gbX1tTypkBxShsNrz79fAd1gTcU9nEA30JkxBkbsJDFTDaQp9qZ GoJR6Fll4rL7f68TiftwritwU0NMYu1zg+sdv4pJ4qRbGf226awxwuAE+h05aLRI7+ CBuobHcdrmjPVMH9D9WPY8RuDctstRCgS0ceQITCjZblv7eQXlvhWUGdxudwi8ICQH oEv8VaUl6b6MDOuo6CbkC5WRrPtxlY3Y2Pi3fwPKn2GUePWGCHchMgM4XaRV1BDeXD V+OS4IVzeLgug== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288018 Archived-At: Eli Zaretskii writes: >> Date: Wed, 12 Jun 2024 10:43:14 +0200 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Following a recent short discussion[0] on emacs-devel, I'm opening this >> feature request so it doesn't get lost: >> >> Flymake should provide a standard way for backends to associate fix >> suggestions with the diagnostics they produce, along with a >> backend-agnostic user interface (e.g. a command) for examining and >> applying such fixes. >> >> I suggested a possible implementation that works quite well for me >> (with the three backends I've adapted so far - checkdoc, shellcheck >> and Eglot), but any other solution that gives various backends a >> standard way to provide their fixes would be just as welcome. >> >> >> Thanks and best regards, >> >> Eshel >> >> >> [0] https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01137.html > > Spencer, any comments or suggestions? > > Thanks. I basically agree with Joao's views in the linked thread. It is already possible to associate arbitrary data and actions with flymake diagnostics by adding overlay properties, as Joao mentioned. I also think we have not sufficiently explored different UI possibilities, and I think adding to flymake now will limit us in what UI possibilities we can explore, no matter how generic we try to be. And that UI exploration can happen without adding to flymake. For example, maybe we want to have a command which can accept fixes output by a process running in M-x compile. Baking the UI into flymake would make that impossible, wouldn't it? So before any change in flymake I would like to see much more exploration of "fix" UIs which are genuinely flymake-independent. And fit in well with existing Emacs functionality, rather than just porting VSCode and LSP patterns.