From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#65347: 29.1; Underscore in query replace prevents case-matching Date: Fri, 18 Aug 2023 12:30:48 -0400 Message-ID: References: <838raa6syr.fsf@gnu.org> <83o7j451iu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65347@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 18 18:31:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qX2Nc-000ALC-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Aug 2023 18:31:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qX2NR-0008GR-3v; Fri, 18 Aug 2023 12:31:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX2NK-0008Fu-N0 for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 12:31:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qX2NK-0006YT-EJ for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 12:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qX2NK-0000FX-1o for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 12:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2023 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65347 X-GNU-PR-Package: emacs Original-Received: via spool by 65347-submit@debbugs.gnu.org id=B65347.1692376258950 (code B ref 65347); Fri, 18 Aug 2023 16:31:02 +0000 Original-Received: (at 65347) by debbugs.gnu.org; 18 Aug 2023 16:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:48595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX2NG-0000FG-HT for submit@debbugs.gnu.org; Fri, 18 Aug 2023 12:30:58 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:56097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX2ND-0000Ey-8E for 65347@debbugs.gnu.org; Fri, 18 Aug 2023 12:30:56 -0400 In-Reply-To: <83o7j451iu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Aug 2023 09:04:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267771 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: Eli Zaretskii , 65347@debbugs.gnu.org >> Date: Thu, 17 Aug 2023 22:04:53 -0400 >> >> > Although, a further relevant question: is there some way to make _ not >> > be a word separator, in this specific context? Without changing the >> > syntax table of the buffer overall? So that foo_bar is interpreted as >> > one word? >> >> There's `superword-mode`, but I suspect that query-replace does not >> honor it in this case. Could be considered as a bug in >> `superword-mode`. > > Actually, I think it's a bug in replace-match: it doesn't honor > find-word-boundary-function-table. I think it should. Patches > welcome. I suppose this is a bit of an XY problem - the real thing I (speaking for the user who reported this to me) want is to have case-matching for symbols instead of words. e.g. if I have Foo-do-action and I do a replace of foo-do-action with bar-do-action, I want the replacement to be Bar-do-action. That seems like a reasonable customization... I could add support for this to replace-match - it would just be a matter of teaching it to conditionally use symbol boundaries instead of word boundaries. Alternatively, much more interestingly, the case-matching could *always* detect case patterns both for symbols and for words. And if there's no case pattern for words, but there is a case pattern for symbols, apply that case pattern to symbols in the replacement. We could even turn that on by default. Does that sound like a good change? I can make that change if it sounds desirable. Alternatively, much more simply, maybe the case-matching could just detect if the first word is capitalized, and then also capitalize the first word in the replacement? That would work for this specific usage.