From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory Date: Mon, 14 Aug 2023 16:12:28 -0400 Message-ID: References: <16b64d95-35e9-ef94-2c54-17b670111f0f@gutov.dev> <86h6rnw7gm.fsf@mail.linkov.net> <3e404df1-b3a9-f9e3-4270-f42df8b704c7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Juri Linkov , 63829@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 14 22:13:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVdwi-0002vx-Uo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Aug 2023 22:13:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVdwY-0003DR-Mh; Mon, 14 Aug 2023 16:13:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVdvz-0002z0-UB for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 16:13:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVdvy-0008Gj-GE for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 16:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVdvy-0001ZA-0s for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2023 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63829 X-GNU-PR-Package: emacs Original-Received: via spool by 63829-submit@debbugs.gnu.org id=B63829.16920439575990 (code B ref 63829); Mon, 14 Aug 2023 20:13:01 +0000 Original-Received: (at 63829) by debbugs.gnu.org; 14 Aug 2023 20:12:37 +0000 Original-Received: from localhost ([127.0.0.1]:34471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVdvZ-0001YY-8t for submit@debbugs.gnu.org; Mon, 14 Aug 2023 16:12:37 -0400 Original-Received: from mxout6.mail.janestreet.com ([64.215.233.21]:33625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVdvX-0001YI-4W for 63829@debbugs.gnu.org; Mon, 14 Aug 2023 16:12:36 -0400 In-Reply-To: (Dmitry Gutov's message of "Sat, 12 Aug 2023 04:23:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267444 Archived-At: Dmitry Gutov writes: > Hi Spencer, > > Thanks for the ping. > > On 06/06/2023 18:55, Spencer Baugh wrote: > >>> But so far the patch over there is not complete yet, is it? I wouldn't >>> say it's a settled matter so far. >> Yes, I expect there are any number of alternative implementation >> strategies, I'm not at all tied to using >> project-current-directory-override. Happy to port to whatever approach >> we end up with. > > Notes: > > - We're still using project-current-directory-override, not migrated > to anything else yet. > - I've pushed my earlier patch which should fix the immediate bug as > reported. > > Let's talk about yours a little bit more. I'm a little wary of adding > a specialized feature this way (being able to visit the file > corresponding to the current one only), but that patch might be the > most optimal still. > >>>> BTW, I asked about this before inhttps://debbugs.gnu.org/58447#127 >>>> and then it was deemed to be not too general to handle, so I backed it out >>>> inhttps://debbugs.gnu.org/58447#160 with such conclusion: >>>> OTOH, `C-x p f M-p' in another project is not my primary >>>> workflow. >>>> But if someone wants to keep a plain history, this could be added >>>> later in master, e.g. by a new value of project-read-file-name-function >>>> and a function that is mostly a copy of project--read-file-cpd-relative. >>>> So maybe this could be implemented in master now? >>> >>> I think the design there was to use relative file names in history? Or >>> a different variable for project file name history (which would use >>> relative names only). I'm not ruling that out, but the patch proposed >>> here is a little more focused. >>> >>> OTOH, it only allows finding the "current" file in the other project, >>> but not other files that were previously visited too. Spencer, what do >>> you think about that capability? Do you also feel it is missing and >>> would like to look into it next? Then the current patch might be the >>> wrong direction. >> Hm, the main thing I want is to make it very easy to visit the >> current >> file in another project - I am frequently getting user requests for that >> feature. (Mainly because our workflow heavily uses a "git worktree" >> equivalent, where users have one project for each bug/branch they're >> working on, all with basically the same layout, so "visit the same file >> in a different project" is also "visit the same file in a different >> branch", which is often useful. (I actually might work on some code to >> help implement the same kind of workflow for Emacs development, one >> worktree per bug/branch)) > > I suppose one other way to do that would be to create a dedicated > command just for that. But that's a little clunkier -- would require a > separate binding. > >> I'm not sure I understand the alternative - the idea would be to share >> project file name history between all projects? I guess that could be >> nice, although I don't personally use file name history that much, and >> AFAIK it wouldn't solve any concrete user problems, so I'm not really >> motivated to implement it. > > The alternative is a little more general, e.g. propertize every such > history entry with the value of the root, so that they can be > post-processed to adapt to any other root directory. > > This shouldn't take too much work, actually. But I don't know if that > is indeed a necessary feature. From the discussion > (https://debbugs.gnu.org/58447), I had been under impression that it > would be wanted, but it might be just "nice to have". I would be happy to do that. That sounds very cool actually. Can you elaborate on how exactly you imagine this happening? I guess, every time someone enters a filename with project-find-file or project-find-dir, we would include a propertized version of that filename in file-name-history? And then we would re-relativize them and adapt them to the current project when including them as history? And also, we'd always prepend the current file as "future history", propertized in this way? > Juri, are *you* okay with the functionality in Spencer's patch? No > need for further generality? > >> However, if we did share project file name history in that way, I'd want >> to still automatically prepend the "current file" as history. Even if >> we didn't navigate to the current file via project-find-file, I still >> want to make it very easy to visit the current file in another project. >> Just sharing project file name history doesn't provide that. > > Fair point.