From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#65347: 29.1; Underscore in query replace prevents case-matching Date: Fri, 18 Aug 2023 14:31:46 -0400 Message-ID: References: <838raa6syr.fsf@gnu.org> <83o7j451iu.fsf@gnu.org> <83wmxs2p52.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65347@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 18 20:32:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qX4Gk-0006Ib-SZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Aug 2023 20:32:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qX4GR-0004Jq-NA; Fri, 18 Aug 2023 14:32:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX4GQ-0004FJ-1f for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 14:32:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qX4GP-0004B4-PI for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 14:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qX4GQ-0003bM-3n for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 14:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2023 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65347 X-GNU-PR-Package: emacs Original-Received: via spool by 65347-submit@debbugs.gnu.org id=B65347.169238351413829 (code B ref 65347); Fri, 18 Aug 2023 18:32:02 +0000 Original-Received: (at 65347) by debbugs.gnu.org; 18 Aug 2023 18:31:54 +0000 Original-Received: from localhost ([127.0.0.1]:48776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX4GH-0003ay-Ii for submit@debbugs.gnu.org; Fri, 18 Aug 2023 14:31:53 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:50027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX4GG-0003an-8X for 65347@debbugs.gnu.org; Fri, 18 Aug 2023 14:31:52 -0400 In-Reply-To: <83wmxs2p52.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Aug 2023 21:15:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267779 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: Stefan Monnier , 65347@debbugs.gnu.org >> Date: Fri, 18 Aug 2023 12:30:48 -0400 >> >> Eli Zaretskii writes: >> >> There's `superword-mode`, but I suspect that query-replace does not >> >> honor it in this case. Could be considered as a bug in >> >> `superword-mode`. >> > >> > Actually, I think it's a bug in replace-match: it doesn't honor >> > find-word-boundary-function-table. I think it should. Patches >> > welcome. >> >> I suppose this is a bit of an XY problem - the real thing I (speaking >> for the user who reported this to me) want is to have case-matching for >> symbols instead of words. > > We look at this from different angles. As an Emacs maintainer, I > would like to see every place that deals with words to honor > find-word-boundary-function-table, instead of inventing its own ideas > about where a word begins and where it ends. Understandable, I want this too of course. Better support for case matching in words would be good. >> e.g. if I have Foo-do-action and I do a replace of foo-do-action with >> bar-do-action, I want the replacement to be Bar-do-action. > > Here, you look at the issue from a very narrow perspective: of words > separated by '-' or '_', because that just happens to be the case that > you bumped into. But that is just one very particular use case; words > can be separated by a lot more characters. I would actually begin > considering the simpler case of "Foo do action". But no, this use case very specifically is about replacing symbols (sexps) while matching case. There's a body of code which frequently uses the same symbol with different capitalization (both as a lowercase variable name and an uppercase type name) and I want to do replacements which match case. I don't much care about the word boundary or superword-mode, because I'm not dealing with words - I'm very deliberately dealing with symbols. >> Alternatively, much more simply, maybe the case-matching could just >> detect if the first word is capitalized, and then also capitalize the >> first word in the replacement? That would work for this specific usage. > > Given enough user options, we could support that as optional behavior. > But one thing is clear: we cannot simultaneously support all of the > possible interpretations of "capitalization pattern". And another > thing is clear: this heuristic is confusing and rarely kept in mind as > it is, so imagine what will happen if we add half a dozen options to > support its variants... Sure. This idea is very hacky anyway. What about the other thing I proposed? That's what I'm more interested in, because this is a problem of replacing symbols. And it's much more elegant. Repeated here: >>Alternatively, much more interestingly, the case-matching could *always* >>detect case patterns both for symbols and for words. And if there's no >>case pattern for words, but there is a case pattern for symbols, apply >>that case pattern to symbols in the replacement. We could even turn >>that on by default. Does that sound like a good change? I can make >>that change if it sounds desirable.