From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61006: 29.0.60; Wrong indentation in go-ts-mode Date: Wed, 25 Jan 2023 02:35:20 +0000 Message-ID: References: <4e1f92dc54d94cf4860490c643b5fd565deb0e1a.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_NVQmt8GySBmNPw3GhTigl7wRHSgUIEiqOrirTI6Th4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61006@debbugs.gnu.org To: sskostyaev@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 03:36:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKVeI-00019g-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 03:36:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKVdz-0001cm-QD; Tue, 24 Jan 2023 21:36:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKVdq-0001AJ-JC for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:36:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKVdp-0005mG-W4 for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKVdp-0003FU-Mv for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 02:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61006 X-GNU-PR-Package: emacs Original-Received: via spool by 61006-submit@debbugs.gnu.org id=B61006.167461414512458 (code B ref 61006); Wed, 25 Jan 2023 02:36:01 +0000 Original-Received: (at 61006) by debbugs.gnu.org; 25 Jan 2023 02:35:45 +0000 Original-Received: from localhost ([127.0.0.1]:57946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVdY-0003Es-TB for submit@debbugs.gnu.org; Tue, 24 Jan 2023 21:35:45 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:61209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVdW-0003Ed-Aq for 61006@debbugs.gnu.org; Tue, 24 Jan 2023 21:35:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1674614135; x=1674873335; bh=CdM/DqMXl6i3KW+RVcQKhV6s3BM/KuW7ItpJYUur/aE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=fEuNbCL+ySsLjzVU25UcaDEZ6xYOAOhbSSd2PrhntKce8hcLNTBJBbBncy5m17w3q E3TDDEd+VSXlHhWtpHKWUq/NAVQvKlW3vBgq2bw17SEy/X0UIR3eidtPV+HrSyZ8/G Q3Uwot6WPIF96iYdSYAMitM1bja+Bhe4zXoFOZQkJWD5DQl3UnTZl0LtCj/0+XQ9bq r2zpKwYFLBpI4WhjrwB5XLcBHB8zD4hPR0xLIVUC4LewyMS0w2V6MmTHVE0IID6uW6 I3EZQ2/Gy1Xx3h+1t86zTqUw9kXtp+slSwYM5dmR1npLPYFxAgYn6zdxDVPSWDPr1q We9THvv4MU9ig== In-Reply-To: <4e1f92dc54d94cf4860490c643b5fd565deb0e1a.camel@gmail.com> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254090 Archived-At: This is a multi-part message in MIME format. --b1_NVQmt8GySBmNPw3GhTigl7wRHSgUIEiqOrirTI6Th4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sunday, January 22nd, 2023 at 05:00, sskostyaev@gmail.com wrote: >=20 > Hi. Thank you all for great work. > In go-ts-mode indentation breaks in function or method definition if > arguments placed on separate lines like this: > `func transform( s string, ) string {` > This code should be indented like this: > `func transform( s string, ) string {` Thanks for the report. I've attached a patch that fixes this. > Also `go-ts-mode-indent-offset' should be 8 by default. In go world there= is gofmt which is a real standart for code indentation. It would be great = if emacs will provide the same indentation out of the box. And addresses this. > There is also other issue - sometimes go-ts-mode syntax highliting breaks= when I actively use it with` lsp-mode`- refactorings, auto formatting etc.= But I can't reproduce it with`eglot`. Seems like an `lsp-mode` problem then? I only use `eglot` and haven't notic= ed anything amiss. --b1_NVQmt8GySBmNPw3GhTigl7wRHSgUIEiqOrirTI6Th4 Content-Type: text/x-patch; name=0001-Fix-go-ts-mode-parameter-indentation-and-set-indent-.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-go-ts-mode-parameter-indentation-and-set-indent-.patch RnJvbSA2NTk1YTQ1OTJjMmVhMmQ5Y2ZmNDIwM2Q1M2Q5MWRjY2FlOGRjMWNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDI0IEphbiAyMDIzIDIxOjIwOjQ4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGdvLXRzLW1v ZGUgcGFyYW1ldGVyIGluZGVudGF0aW9uIGFuZCBzZXQgaW5kZW50IG9mZnNldCB0bwogOAoKKiBs aXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIChnby10cy1tb2RlLWluZGVudC1vZmZzZXQpOiBD aGFuZ2UgaXQKdG8gOC4KKGdvLXRzLW1vZGUtLWluZGVudC1ydWxlcyk6IEFkZCBpbmRlbnRhdGlv biBmb3IgcGFyYW1ldGVycy4KCihCdWcjNjEwMDYpCi0tLQogbGlzcC9wcm9nbW9kZXMvZ28tdHMt bW9kZS5lbCB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3Av cHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKaW5kZXggZDU1MmUxMzYwZTAuLjVhOTdhYTVkNjgwIDEw MDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21v ZGVzL2dvLXRzLW1vZGUuZWwKQEAgLTM4LDcgKzM4LDcgQEAKIChkZWNsYXJlLWZ1bmN0aW9uIHRy ZWVzaXQtbm9kZS10eXBlICJ0cmVlc2l0LmMiKQogKGRlY2xhcmUtZnVuY3Rpb24gdHJlZXNpdC1z ZWFyY2gtc3VidHJlZSAidHJlZXNpdC5jIikKIAotKGRlZmN1c3RvbSBnby10cy1tb2RlLWluZGVu dC1vZmZzZXQgNAorKGRlZmN1c3RvbSBnby10cy1tb2RlLWluZGVudC1vZmZzZXQgOAogICAiTnVt YmVyIG9mIHNwYWNlcyBmb3IgZWFjaCBpbmRlbnRhdGlvbiBzdGVwIGluIGBnby10cy1tb2RlJy4i CiAgIDp2ZXJzaW9uICIyOS4xIgogICA6dHlwZSAnaW50ZWdlcgpAQCAtODAsNiArODAsNyBAQCBn by10cy1tb2RlLS1pbmRlbnQtcnVsZXMKICAgICAgKChwYXJlbnQtaXMgImltcG9ydF9zcGVjX2xp c3QiKSBwYXJlbnQtYm9sIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQt aXMgImxhYmVsZWRfc3RhdGVtZW50IikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZz ZXQpCiAgICAgICgocGFyZW50LWlzICJsaXRlcmFsX3ZhbHVlIikgcGFyZW50LWJvbCBnby10cy1t b2RlLWluZGVudC1vZmZzZXQpCisgICAgICgocGFyZW50LWlzICJwYXJhbWV0ZXJfbGlzdCIpIHBh cmVudC1ib2wgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1pcyAidHlw ZV9zcGVjIikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFy ZW50LWlzICJ2YXJfZGVjbGFyYXRpb24iKSBwYXJlbnQtYm9sIGdvLXRzLW1vZGUtaW5kZW50LW9m ZnNldCkKICAgICAgKG5vLW5vZGUgcGFyZW50LWJvbCAwKSkpCi0tIAoyLjM5LjEKCg== --b1_NVQmt8GySBmNPw3GhTigl7wRHSgUIEiqOrirTI6Th4--