From: Glenn Morris <rgm@gnu.org>
To: 10513-done@debbugs.gnu.org
Subject: bug#10513: 23.3; vc-modify-change-comment broken in emacs-23.3-8.fc16
Date: Tue, 24 Jan 2012 19:08:39 -0500 [thread overview]
Message-ID: <hyliowlk3c.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <82fwfh1c5y.fsf@kermit.inria.fr> (Francis Montagnac's message of "Sun, 15 Jan 2012 11:40:41 +0100")
Version: 24.0.93
Francis.Montagnac@inria.fr wrote:
> Modifying (even under emacs -q) a change log entry typing 'e' from
> *VC-log* break when typing C-c C-c with the message:
>
> apply: Symbol's value as variable is void: backend
>
> I found a turnaround: use a lexical-let instead of a let in
> vc-modify-change-comment:
>
> < (let ((backend (vc-responsible-backend (car files))))
>> (lexical-let ((backend (vc-responsible-backend (car files))))
Thanks for the report. I installed something similar:
*** lisp/vc/vc.el 2012-01-19 07:21:25 +0000
--- lisp/vc/vc.el 2012-01-25 00:05:40 +0000
***************
*** 1880,1886 ****
"Enter a replacement change comment."
"*vc-log*"
(lambda () (vc-call-backend backend 'log-edit-mode))
! (lexical-let ((rev rev))
(lambda (files comment)
(vc-call-backend backend
'modify-change-comment files rev comment))))))
--- 1880,1887 ----
"Enter a replacement change comment."
"*vc-log*"
(lambda () (vc-call-backend backend 'log-edit-mode))
! (lexical-let ((rev rev)
! (backend backend))
(lambda (files comment)
(vc-call-backend backend
'modify-change-comment files rev comment))))))
prev parent reply other threads:[~2012-01-25 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 10:40 bug#10513: 23.3; vc-modify-change-comment broken in emacs-23.3-8.fc16 Francis.Montagnac
2012-01-25 0:08 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hyliowlk3c.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=10513-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).