* bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 @ 2009-03-23 17:34 ` Dan Nicolaescu 2009-03-23 19:18 ` Stefan Monnier 2009-06-27 0:00 ` bug#2757: marked as done (remove vc-file-not-found-hook in 23.2) Emacs bug Tracking System 0 siblings, 2 replies; 5+ messages in thread From: Dan Nicolaescu @ 2009-03-23 17:34 UTC (permalink / raw) To: bug-gnu-emacs The vc-file-not-found-hook behavior is only used by RCS, and it is a strange wart anyway. IMO we should remove vc-file-not-found-hook from file-not-found-hook by default for 23.1 and even remove the `find-file-not-found-hook' VC method. We can put instructions in NEWS that if people want the old behavior, they can add vc-rcs-file-not-found-hook to find-file-not-found hook. This hook adds a cost every time when opening a non-VC managed file. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 2009-03-23 17:34 ` bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 Dan Nicolaescu @ 2009-03-23 19:18 ` Stefan Monnier 2009-03-23 21:54 ` Dan Nicolaescu 2009-06-27 0:00 ` bug#2757: marked as done (remove vc-file-not-found-hook in 23.2) Emacs bug Tracking System 1 sibling, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2009-03-23 19:18 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: bug-gnu-emacs, 2757 > IMO we should remove vc-file-not-found-hook from file-not-found-hook by > default for 23.1 and even remove the `find-file-not-found-hook' VC > method. Let's remove it in Emacs-23.2. > This hook adds a cost every time when opening a non-VC managed file. Really? It should only be triggered when opening a non-existent file. Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 2009-03-23 19:18 ` Stefan Monnier @ 2009-03-23 21:54 ` Dan Nicolaescu 2009-03-23 22:00 ` Processed: " Emacs bug Tracking System 0 siblings, 1 reply; 5+ messages in thread From: Dan Nicolaescu @ 2009-03-23 21:54 UTC (permalink / raw) To: Stefan Monnier; +Cc: 2757 retitle 2757 remove vc-file-not-found-hook in 23.2 quit Stefan Monnier <monnier@IRO.UMontreal.CA> writes: > > IMO we should remove vc-file-not-found-hook from file-not-found-hook by > > default for 23.1 and even remove the `find-file-not-found-hook' VC > > method. > > Let's remove it in Emacs-23.2. Fine, adjusted the subject accordingly. > > This hook adds a cost every time when opening a non-VC managed file. > > Really? It should only be triggered when opening a non-existent file. You're right. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Processed: Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 2009-03-23 21:54 ` Dan Nicolaescu @ 2009-03-23 22:00 ` Emacs bug Tracking System 0 siblings, 0 replies; 5+ messages in thread From: Emacs bug Tracking System @ 2009-03-23 22:00 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: Emacs Bugs Processing commands for control@emacsbugs.donarmstrong.com: > retitle 2757 remove vc-file-not-found-hook in 23.2 bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 Changed bug title to `remove vc-file-not-found-hook in 23.2' from `disable (or deprecate) vc-file-not-found-hook for 23.1'. > quit Stopping processing here. Please contact me if you need assistance. Don Armstrong (administrator, Emacs bugs database) ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2757: marked as done (remove vc-file-not-found-hook in 23.2) 2009-03-23 17:34 ` bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 Dan Nicolaescu 2009-03-23 19:18 ` Stefan Monnier @ 2009-06-27 0:00 ` Emacs bug Tracking System 1 sibling, 0 replies; 5+ messages in thread From: Emacs bug Tracking System @ 2009-06-27 0:00 UTC (permalink / raw) To: Dan Nicolaescu [-- Attachment #1: Type: text/plain, Size: 915 bytes --] Your message dated Fri, 26 Jun 2009 16:53:59 -0700 (PDT) with message-id <200906262353.n5QNrxbh008540@godzilla.ics.uci.edu> and subject line Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 has caused the Emacs bug report #2757, regarding remove vc-file-not-found-hook in 23.2 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 2757: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2757 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 2954 bytes --] From: Dan Nicolaescu <dann@ics.uci.edu> To: bug-gnu-emacs <bug-gnu-emacs@gnu.org> Subject: disable (or deprecate) vc-file-not-found-hook for 23.1 Date: Mon, 23 Mar 2009 10:34:27 -0700 (PDT) Message-ID: <200903231734.n2NHYRqF011668@godzilla.ics.uci.edu> The vc-file-not-found-hook behavior is only used by RCS, and it is a strange wart anyway. IMO we should remove vc-file-not-found-hook from file-not-found-hook by default for 23.1 and even remove the `find-file-not-found-hook' VC method. We can put instructions in NEWS that if people want the old behavior, they can add vc-rcs-file-not-found-hook to find-file-not-found hook. This hook adds a cost every time when opening a non-VC managed file. [-- Attachment #3: Type: message/rfc822, Size: 2242 bytes --] From: Dan Nicolaescu <dann@ics.uci.edu> To: Stefan Monnier <monnier@IRO.UMontreal.CA> Cc: 2757-done@emacsbugs.donarmstrong.com Subject: Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 Date: Fri, 26 Jun 2009 16:53:59 -0700 (PDT) Message-ID: <200906262353.n5QNrxbh008540@godzilla.ics.uci.edu> Stefan Monnier <monnier@IRO.UMontreal.CA> writes: > > IMO we should remove vc-file-not-found-hook from file-not-found-hook by > > default for 23.1 and even remove the `find-file-not-found-hook' VC > > method. > > Let's remove it in Emacs-23.2. Thanks. Done. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-27 0:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200906262353.n5QNrxbh008540@godzilla.ics.uci.edu>
2009-03-23 17:34 ` bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1 Dan Nicolaescu
2009-03-23 19:18 ` Stefan Monnier
2009-03-23 21:54 ` Dan Nicolaescu
2009-03-23 22:00 ` Processed: " Emacs bug Tracking System
2009-06-27 0:00 ` bug#2757: marked as done (remove vc-file-not-found-hook in 23.2) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).