unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: don@donarmstrong.com (Emacs bug Tracking System)
To: Glenn Morris <rgm@gnu.org>
Subject: bug#980: marked as done (Bug? sit-for and obsolete syntax)
Date: Sun, 14 Sep 2008 12:15:04 -0700	[thread overview]
Message-ID: <handler.980.D980.122141942329688.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: 87fxo32df6.fsf@ID-24456.user.uni-berlin.de

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]


Your message dated Sun, 14 Sep 2008 15:08:26 -0400
with message-id <hkljxuczpx.fsf@fencepost.gnu.org>
and subject line Re: bug#980: Bug? sit-for and obsolete syntax
has caused the Emacs bug report #980,
regarding Bug? sit-for and obsolete syntax
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
980: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=980
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2875 bytes --]

From: Christoph Conrad <christoph.conrad@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: Bug? sit-for and obsolete syntax
Date: Sun, 14 Sep 2008 13:03:09 +0200
Message-ID: <87fxo32df6.fsf@ID-24456.user.uni-berlin.de>

GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of
2008-05-03 on terranova, modified by Ubuntu

sit-for supports an obsolete call syntax with

(sit-for SECONDS &optional MILLISECONDS NODISP)

according to the doc string.

It checks:

  (when (or obsolete (numberp nodisp))
    (setq seconds (+ seconds (* 1e-3 nodisp)))
    (setq nodisp obsolete))

the first logical 'or' should be imho 'and'. Else obsolete could be
non-nil, but nodisp could be no number (e.g. nil), and that results in
an error when multiplying.




[-- Attachment #3: Type: message/rfc822, Size: 1790 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: Christoph Conrad <christoph.conrad@gmx.de>
Cc: 980-done@emacsbugs.donarmstrong.com, martin rudalics <rudalics@gmx.at>
Subject: Re: bug#980: Bug? sit-for and obsolete syntax
Date: Sun, 14 Sep 2008 15:08:26 -0400
Message-ID: <hkljxuczpx.fsf@fencepost.gnu.org>

Christoph Conrad wrote:

> I checked the current CVS version by looking at the source of sit-for.
> The obsolete handling looks correct now.

Yes, this is fixed in Emacs 22.2 and up.


      parent reply	other threads:[~2008-09-14 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <hkljxuczpx.fsf@fencepost.gnu.org>
2008-09-14 11:03 ` bug#980: Bug? sit-for and obsolete syntax Christoph Conrad
2008-09-14 18:01   ` martin rudalics
2008-09-14 18:23     ` Christoph Conrad
2008-09-14 19:15   ` Emacs bug Tracking System [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=handler.980.D980.122141942329688.ackdone@emacsbugs.donarmstrong.com \
    --to=don@donarmstrong.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).