bug#888: 23.0.60; window height 2 too small (after splitting)

bug#888: 23.0.60; window height 2 too small (after splitting)

[Drew Adams]

emacs -Q
 
Manually resize the frame so that it is only a few lines high.
 
Do almost anything that would normally display another buffer, whether
in the same window or by splitting the window. For example, do C-h f
display buffer or do C-x C-b.
 
You get an error message with the subject line, and no buffer is
displayed. In fact, I tried to send a bug report with the same small
frame size, and the *mail* buffer got filled with (only) the error
message.
 
This is worse than useless, and represents a regression. If the window
cannot be split for some reason, then Emacs should do as it did
before: either use the same window or create a new frame.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-08-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 

bug#888: 23.0.60; window height 2 too small (after splitting)

[martin rudalics]

> emacs -Q
>  
> Manually resize the frame so that it is only a few lines high.
>  
> Do almost anything that would normally display another buffer, whether
> in the same window or by splitting the window. For example, do C-h f
> display buffer or do C-x C-b.
>  
> You get an error message with the subject line, and no buffer is
> displayed. In fact, I tried to send a bug report with the same small
> frame size, and the *mail* buffer got filled with (only) the error
> message.
>  
> This is worse than useless, and represents a regression. If the window
> cannot be split for some reason, then Emacs should do as it did
> before: either use the same window or create a new frame.

Sorry.  I have to wrap this part in a condition-case.  `split-window'
is too severe here.

Thanks for the report!

martin

bug#888: 23.0.60; window height 2 too small (after splitting)

[martin rudalics]

> Manually resize the frame so that it is only a few lines high.
>  
> Do almost anything that would normally display another buffer, whether
> in the same window or by splitting the window. For example, do C-h f
> display buffer or do C-x C-b.
>  
> You get an error message with the subject line, and no buffer is
> displayed. In fact, I tried to send a bug report with the same small
> frame size, and the *mail* buffer got filled with (only) the error
> message.
>  
> This is worse than useless, and represents a regression. If the window
> cannot be split for some reason, then Emacs should do as it did
> before: either use the same window or create a new frame.

I checked in a fix.  Please try again.

martin

bug#888: 23.0.60; window height 2 too small (after splitting)

[Drew Adams]

> > Manually resize the frame so that it is only a few lines high.
> >  
> > Do almost anything that would normally display another 
> buffer, whether
> > in the same window or by splitting the window. For example, do C-h f
> > display buffer or do C-x C-b.
> >  
> > You get an error message with the subject line, and no buffer is
> > displayed. In fact, I tried to send a bug report with the same small
> > frame size, and the *mail* buffer got filled with (only) the error
> > message.
> >  
> > This is worse than useless, and represents a regression. If 
> > the window cannot be split for some reason, then Emacs should do as it did
> > before: either use the same window or create a new frame.
> 
> I checked in a fix.  Please try again.

I can't until I get another Windows binary - probably in about a month. But I'm
sure you DTRT - thanks!

bug#888: 23.0.60; window height 2 too small (after splitting)

[martin rudalics]

 > I can't until I get another Windows binary - probably in about a month. But I'm
 > sure you DTRT - thanks!

Why wait?  All you have to do is put an `and' before the penultimate
line in `window--try-to-split-window' like this (modulo some mangled
tabs):

	       ;; If WINDOW is the only window on its frame and not the
	       ;; minibuffer window, attempt to split it vertically
	       ;; disregarding the value of `split-height-threshold'.
	       (let ((split-height-threshold 0))
		 (and (window--splittable-p window)
		      (split-window window))))))))

martin

bug#888: marked as done (23.0.60; window height 2 too small (after splitting))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]


Your message dated Sun, 07 Sep 2008 12:05:13 +0200
with message-id <48C3A759.3080000@gmx.at>
and subject line Re: bug#888: 23.0.60; window height 2 too small (after splitting)
has caused the Emacs bug report #888,
regarding 23.0.60; window height 2 too small (after splitting)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
888: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=888
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3405 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; window height 2 too small (after splitting)
Date: Thu, 4 Sep 2008 09:27:53 -0700
Message-ID: <00e801c90eab$2ebdffd0$c2b22382@us.oracle.com>

emacs -Q
 
Manually resize the frame so that it is only a few lines high.
 
Do almost anything that would normally display another buffer, whether
in the same window or by splitting the window. For example, do C-h f
display buffer or do C-x C-b.
 
You get an error message with the subject line, and no buffer is
displayed. In fact, I tried to send a bug report with the same small
frame size, and the *mail* buffer got filled with (only) the error
message.
 
This is worse than useless, and represents a regression. If the window
cannot be split for some reason, then Emacs should do as it did
before: either use the same window or create a new frame.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-08-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 




[-- Attachment #3: Type: message/rfc822, Size: 1516 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 888-done@emacsbugs.donarmstrong.com
Cc: "Drew Adams" <drew.adams@oracle.com>
Subject: Re: bug#888: 23.0.60; window height 2 too small (after splitting)
Date: Sun, 07 Sep 2008 12:05:13 +0200
Message-ID: <48C3A759.3080000@gmx.at>

Fixed as

2008-09-05  Martin Rudalics  <rudalics@gmx.at>

	* window.el (window--try-to-split-window): Don't split when window
	is not splittable in last disjunct.  (Bug#888)

Thanks

bug#888: 23.0.60; window height 2 too small (after splitting)

[Drew Adams]

Yes, thanks. It works now.  - Drew

> put an `and' before the penultimate line in `window--try-to-split-window'
> like this (modulo some mangled tabs):
> 
> 	       ;; If WINDOW is the only window on its frame and not the
> 	       ;; minibuffer window, attempt to split it vertically
> 	       ;; disregarding the value of `split-height-threshold'.
> 	       (let ((split-height-threshold 0))
> 		 (and (window--splittable-p window)
> 		      (split-window window))))))))