From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#887: marked as done (23.0.60; glyph_string->gidx removal causes HEAD compilation failure under OS X) Date: Fri, 3 Oct 2008 11:10:12 -0700 Message-ID: References: <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> <1f1b3ded0809040804g410096efr46135d26d9ae78ca@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1223057412-27669-18" X-Trace: ger.gmane.org 1223058699 11749 80.91.229.12 (3 Oct 2008 18:31:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Oct 2008 18:31:39 +0000 (UTC) To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 03 20:32:35 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KlpS3-0003QH-58 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 20:32:32 +0200 Original-Received: from localhost ([127.0.0.1]:37156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlpQy-0004Rs-PW for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 14:31:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KlpPi-00043L-L8 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KlpPg-00041k-GO for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:04 -0400 Original-Received: from [199.232.76.173] (port=36285 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlpPf-00041f-QU for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:03 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44821) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KlpPe-00076u-Pn for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:03 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93ITuTN032564; Fri, 3 Oct 2008 11:29:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m93IAC8S028295; Fri, 3 Oct 2008 11:10:12 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 887 X-Emacs-PR-Package: emacs,ns X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21060 Archived-At: This is a multi-part message in MIME format... ------------=_1223057412-27669-18 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 3 Oct 2008 14:03:20 -0400 with message-id <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> and subject line #823 - 23.0.60; uninitialised variable gidx in nsfont.m - = Emacs bug report logs has caused the Emacs bug report #823, regarding 23.0.60; glyph_string->gidx removal causes HEAD compilation failu= re under OS X to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 823: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D823 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1223057412-27669-18 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.2 required=4.0 tests=BAYES_00,FOURLA,HTML_MESSAGE, IMPRONONCABLE_1,MURPHY_SEX_L2,MURPHY_WRONG_WORD2,NORMAL_HTTP_TO_IP, RCVD_IN_DNSWL_MED autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2008 15:05:14 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m84F4xIW026956 for ; Thu, 4 Sep 2008 08:05:01 -0700 Received: from mail.gnu.org ([199.232.76.166]:50444 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KbGMh-0005WR-Qm for emacs-pretest-bug@gnu.org; Thu, 04 Sep 2008 11:03:19 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KbGOG-0002iq-K3 for emacs-pretest-bug@gnu.org; Thu, 04 Sep 2008 11:04:59 -0400 Received: from ug-out-1314.google.com ([66.249.92.170]:59501) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KbGOF-0002iO-Vf for emacs-pretest-bug@gnu.org; Thu, 04 Sep 2008 11:04:56 -0400 Received: by ug-out-1314.google.com with SMTP id m2so2723476uge.17 for ; Thu, 04 Sep 2008 08:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=WiNRrWHiGAPZRjq5x0wsiGc7NqGepsif8Vg5qgck5/8=; b=rTVsCB4HCmJXnjI+cRRhnjWZUElVPh68ESijrr6z5vBvs/ISVemUFaNi1M01vpX9dE RKdvqCCZ4h2+wMV5TmSRV4Sx3HlZkQfZSAEHDIfHOowoHc+mQHx73HdPEaW9nnZeLOlb Nh50xkudSkKIS/n3Q7aqHAP12S8Y0Fz6Qaeeo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=dHJSDyW2y3HnPSH1AwqkM3RmVHxFqyWKdYSBjqTSG+MoUkVd76mZtMDs2quObD80iP vd91/WQ7cwdj+Nvke7PC3SR6peSxm4PPaMvUR3HkMgJNB/AXSlfub5RbhlvCFkaNv9/e uFs11qbMz0O7qXOwHeOGqbtb5TGH0kOoHarw0= Received: by 10.187.202.7 with SMTP id e7mr2425463faq.8.1220540691560; Thu, 04 Sep 2008 08:04:51 -0700 (PDT) Received: by 10.187.239.14 with HTTP; Thu, 4 Sep 2008 08:04:51 -0700 (PDT) Message-ID: <1f1b3ded0809040804g410096efr46135d26d9ae78ca@mail.gmail.com> Date: Thu, 4 Sep 2008 11:04:51 -0400 From: "Sudish Joseph" To: emacs-pretest-bug@gnu.org Subject: 23.0.60; glyph_string->gidx removal causes HEAD compilation failure under OS X MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_31133_13273604.1220540691566" X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) ------=_Part_31133_13273604.1220540691566 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline I last successfully compiled Emacs 23.0.60.1 from cvs a little over a week ago. Trying this again today results in the following error. gcc -c -Demacs -DHAVE_CONFIG_H -I. -I/Users/sj/src/emacs/src -Dtemacs -O2 -pipe -Wall /Users/sj/src/emacs/src/nsfont.m [...] /Users/sj/src/emacs/src/nsfont.m:907: error: 'struct glyph_string' has no member named 'gidx' /Users/sj/src/emacs/src/nsfont.m:908: error: 'struct glyph_string' has no member named 'gidx' /Users/sj/src/emacs/src/nsfont.m:914: error: 'struct glyph_string' has no member named 'gidx' /Users/sj/src/emacs/src/nsfont.m:1064: warning: implicit declaration of function 'CGContextSetFontRenderingMode' /Users/sj/src/emacs/src/nsfont.m:1097: error: 'struct glyph_string' has no member named 'gidx' /Users/sj/src/emacs/src/nsfont.m:1103: error: 'struct glyph_string' has no member named 'gidx' The following change from src/ChangeLog seems to be the root cause -- it seems nsfont.m wasn't updated to reflect the change: 2008-08-29 Kenichi Handa These changes are to re-implement the automatic composition so that it doesn't use text properties. [...] * dispextern.h (struct glyph): New union u.cmp. Delete the member cmp_id. (struct glyph_string): Delete the member gidx. New members cmp_id, cmp_from, and cmp_to. Emacs is being configured and built in a tmp dir as follows: % cd % mkdir tmp % cd tmp % CC=gcc CXX=g++ CFLAGS="-O2 -pipe -Wall" CXXFLAGS=$CFLAGS ../configure --verbose --enable-cocoa-experimental-ctrl-g --without-pop --without-x --with-x-toolkit=no --with-ns % make Thanks for all your hard work in integrating all the OS X/NextStep changes into the mainline. -Sudish In GNU Emacs 23.0.60.1 (i386-apple-darwin9.4.0, *Step 9.0) of 2008-08-27 on fluxus.int.absonant.org Windowing system distributor `Apple', version 49.46.48 configured using `configure '--verbose' '--enable-cocoa-experimental-ctrl-g' '--without-pop' '--without-x' '--with-x-toolkit=no' '--with-ns' 'CC=gcc-4.2' 'CFLAGS=-O2 -pipe -Wall'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Info Minor modes in effect: partial-completion-mode: t hi-lock-mode: t iswitchb-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: d d d d d d d d d d s-s d d d d d d d d d d s-s C-x C-f d r d d s-s C-x C-f d e b R a x x x x x x x x x x x x x x x x x x x s-s C-h i SPC / b u g / SPC SPC SPC SPC SPC M-x r e p o r t - e m a c s - b u g Recent messages: incremental parser error: "Wrong type argument: consp, nil" [2 times] (New file) [2 times] New file. Inserted dmacro: h_masthead Wrote /Users/sj/work/drake_work/httpproxymon/submit.h Wrote /Users/sj/work/drake_work/httpproxymon/httpproxymon.c Wrote /Users/sj/work/drake_work/httpproxymon/Makefile [3 times] Wrote /Users/sj/work/drake_work/httpproxymon/drake.yml Auto-saving...done Wrote /Users/sj/work/drake_work/httpproxymon/Rakefile Composing main Info directory...done ------=_Part_31133_13273604.1220540691566 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
I last successfully compiled Emacs 23.0.60.1 from cvs a little over a week ago.  Trying this again today results in the following error.

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/Users/sj/src/emacs/src -Dtemacs    -O2 -pipe -Wall /Users/sj/src/emacs/src/nsfont.m
[...]
/Users/sj/src/emacs/src/nsfont.m:907: error: 'struct glyph_string' has no member named 'gidx'
/Users/sj/src/emacs/src/nsfont.m:908: error: 'struct glyph_string' has no member named 'gidx'
/Users/sj/src/emacs/src/nsfont.m:914: error: 'struct glyph_string' has no member named 'gidx'
/Users/sj/src/emacs/src/nsfont.m:1064: warning: implicit declaration of function 'CGContextSetFontRenderingMode'
/Users/sj/src/emacs/src/nsfont.m:1097: error: 'struct glyph_string' has no member named 'gidx'
/Users/sj/src/emacs/src/nsfont.m:1103: error: 'struct glyph_string' has no member named 'gidx'

The following change from src/ChangeLog seems to be the root cause -- it seems nsfont.m wasn't updated to reflect the change:

2008-08-29  Kenichi Handa  <handa@m17n.org>

        These changes are to re-implement the automatic composition so
        that it doesn't use text properties.

[...]
        * dispextern.h (struct glyph): New union u.cmp.  Delete the member
        cmp_id.
        (struct glyph_string): Delete the member gidx.  New members
        cmp_id, cmp_from, and cmp_to.

Emacs is being configured and built in a tmp dir as follows:

% cd <head of emacs cvs tree>
% mkdir tmp
% cd tmp
% CC=gcc CXX=g++ CFLAGS="-O2 -pipe -Wall" CXXFLAGS=$CFLAGS ../configure --verbose --enable-cocoa-experimental-ctrl-g --without-pop --without-x --with-x-toolkit=no --with-ns
% make

Thanks for all your hard work in integrating all the OS X/NextStep changes into the mainline.

-Sudish

In GNU Emacs 23.0.60.1 (i386-apple-darwin9.4.0, *Step 9.0)
 of 2008-08-27 on fluxus.int.absonant.org
Windowing system distributor `Apple', version 49.46.48
configured using `configure  '--verbose' '--enable-cocoa-experimental-ctrl-g' '--without-pop' '--without-x' '--with-x-toolkit=no' '--with-ns' 'CC=gcc-4.2' 'CFLAGS=-O2 -pipe -Wall''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Info

Minor modes in effect:
  partial-completion-mode: t
  hi-lock-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <up> <up> <up> <up> <up> <up> <up> <up>
<up> d d d d d d d d d d s-s <up> <up> <up> <up> <up>
d d d d d d d d d d s-s C-x C-f d r <tab> <return>
<down> <down> <down> <down> d d s-s C-x C-f d e b <tab>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> R a <tab> <return> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> x x x x x x
x x x x x x x x x x x <left> <left> x x s-s <down-mouse-1>
<mouse-1> <down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1>
<down-mouse-1> <mouse-1> C-h i <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <right> <right>
<return> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> SPC / b u g <return> / <return>
<right> <return> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> SPC SPC SPC SPC SPC <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> M-x r e p o r t
- e m a c s - b u g <return>

Recent messages:
incremental parser error: "Wrong type argument: consp, nil" [2 times]
(New file) [2 times]
New file. Inserted dmacro: h_masthead
Wrote /Users/sj/work/drake_work/httpproxymon/submit.h
Wrote /Users/sj/work/drake_work/httpproxymon/httpproxymon.c
Wrote /Users/sj/work/drake_work/httpproxymon/Makefile [3 times]
Wrote /Users/sj/work/drake_work/httpproxymon/drake.yml
Auto-saving...done
Wrote /Users/sj/work/drake_work/httpproxymon/Rakefile
Composing main Info directory...done

------=_Part_31133_13273604.1220540691566-- ------------=_1223057412-27669-18 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 823-done) by emacsbugs.donarmstrong.com; 3 Oct 2008 18:04:24 +0000 Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.188]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93I4Hsp025498 for <823-done@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 11:04:18 -0700 Received: by rn-out-0910.google.com with SMTP id j66so598348rne.20 for <823-done@emacsbugs.donarmstrong.com>; Fri, 03 Oct 2008 11:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=I2NbD8QY5lT3/ZR3xu3399fXk2i3NQWv+TkEDZWX80c=; b=SZyg3xvN1wzzlxhxfoNbTCnwNpVxcJFBe/cVq2VXJMmlv6kafZmJBB8qX3waJrziKk wa9mRUL+OPl1iK+mHMyuDU7S55YSST/oGy+f4ckKcsitEMntqohVIUz+XQctE505/aHB Amk9BGgHUOa3C4yyqqCSrTWd9skt7noL8/HIY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=ktHHniRqjTfpiVF4ktg262S0vNnCaCsY5CMJyuHMjDVieyX7jp/dbJmSOA+tQ1dSdR pcE4RcelyEXe8I1dzdmW5ng7Ecq7XH9u+DAEfUSylFlmBvTtL0VqWwVutAKRq93KndHZ l/RzSdLRCO4LP2AvTesg6sR0t3dR6DuOgmB10= Received: by 10.90.92.10 with SMTP id p10mr1584419agb.108.1223057056808; Fri, 03 Oct 2008 11:04:16 -0700 (PDT) Received: from ?10.0.1.199? ([72.169.150.82]) by mx.google.com with ESMTPS id p60sm2937715hsa.8.2008.10.03.11.03.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 03 Oct 2008 11:04:07 -0700 (PDT) Message-Id: <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> From: Adrian Robert To: 823-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: #823 - 23.0.60; uninitialised variable gidx in nsfont.m - Emacs bug report logs Date: Fri, 3 Oct 2008 14:03:20 -0400 X-Mailer: Apple Mail (2.926) Summary: the variable gidx was removed during Kenichi Handa's update of composition handling and it took some time to update all of the code using it: On 2008-08-29 Kenichi Handa changed the glyph_string data structure, composition-related portion On 2008-09-07 Teodor Zlatanov fixed the compiler error by changing glyph_string.gidx to glyph_string.cmp_from On 2008-09-27 Adrian Robert updated this patch to approximate the behavior before Handa's changes ------------=_1223057412-27669-18--