From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#831: marked as done (23.0.60; error in nsfonts.m) Date: Fri, 3 Oct 2008 11:10:06 -0700 Message-ID: References: <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1223057406-27669-4" X-Trace: ger.gmane.org 1223058676 11681 80.91.229.12 (3 Oct 2008 18:31:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Oct 2008 18:31:16 +0000 (UTC) To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 03 20:32:11 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KlpRj-0003Ij-4N for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 20:32:11 +0200 Original-Received: from localhost ([127.0.0.1]:36964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlpQf-0004LB-Rn for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 14:31:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KlpPh-00042u-Vw for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KlpPf-00041T-I9 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:04 -0400 Original-Received: from [199.232.76.173] (port=36282 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlpPf-00041M-ED for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:03 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44818) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KlpPe-00076f-HC for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 14:30:03 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93ITuTH032564; Fri, 3 Oct 2008 11:29:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m93IA6VK027841; Fri, 3 Oct 2008 11:10:06 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 831 X-Emacs-PR-Package: emacs,ns X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21058 Archived-At: This is a multi-part message in MIME format... ------------=_1223057406-27669-4 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 3 Oct 2008 14:03:20 -0400 with message-id <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> and subject line #823 - 23.0.60; uninitialised variable gidx in nsfont.m - = Emacs bug report logs has caused the Emacs bug report #823, regarding 23.0.60; error in nsfonts.m to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 823: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D823 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1223057406-27669-4 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.9 required=4.0 tests=BAYES_00,FOURLA, IMPRONONCABLE_2,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Aug 2008 17:32:45 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7UHWfNY002496 for ; Sat, 30 Aug 2008 10:32:42 -0700 Received: from mx10.gnu.org ([199.232.76.166]:58230) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KZUHz-0001tx-O7 for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:31:07 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KZUJR-0006qM-9O for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:32:40 -0400 Received: from yx-out-1718.google.com ([74.125.44.152]:44191) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZUJQ-0006ps-Ti for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:32:37 -0400 Received: by yx-out-1718.google.com with SMTP id 34so683563yxf.66 for ; Sat, 30 Aug 2008 10:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:user-agent:mime-version:content-type; bh=ADgl4AybtEe+nyIY537k91mpvu1wHJ76SJy4X8tm/8k=; b=jqhmAYNNVJXP+A+LBnNw/TSz7lmZbpQtxFkNo/G7/9qHBTFyJ73YTbRoIIeZRhIWU3 O+/BM4qszQ1Vxeql3hRQqiGz4cBW0WjfjF1DUCtx4BGoUCZIhHLGBPUFyam6qfCiZdo5 ivntpsnopnXuYW/nyUk/3g/InI+CJqwRUfE04= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=WZtuy3DqfS7ol+Q5sqUyR8veJqdi2FR0biPugh3u36x/bMR8Er00T3M0jZrusvO7x9 prtRC836NHEZC65/cHOJS0dR44x3fCWKVAcoPryhYy9hb0DhRLlCiS1s1edmN9fnVZyQ SM4w5zxHnsNkREtYeQfNda5kyHoJq8DzMPv3k= Received: by 10.151.111.15 with SMTP id o15mr6104192ybm.93.1220117554625; Sat, 30 Aug 2008 10:32:34 -0700 (PDT) Received: from localhost ( [74.69.93.157]) by mx.google.com with ESMTPS id 7sm4344277ywo.7.2008.08.30.10.32.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 30 Aug 2008 10:32:33 -0700 (PDT) From: Austin Frank To: emacs-pretest-bug@gnu.org Subject: 23.0.60; error in nsfonts.m Date: Sat, 30 Aug 2008 13:32:39 -0400 Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 with the configure option --with-ns. Build fails because of error in nsfonts.m. That file references a variable called gidx, which is not defined in the relevant structure. The attached patch changes all instances of gidx to x, and allows emacs to build on my system. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gidx.patch Content-Transfer-Encoding: quoted-printable diff --git a/src/nsfont.m b/src/nsfont.m index f49cd0f..10b1c90 100644 =2D-- a/src/nsfont.m +++ b/src/nsfont.m @@ -904,14 +904,14 @@ nsfont_draw (struct glyph_string *s, int from, int to= , int x, int y, int hi, lo; char isComposite =3D 0; /* s->first_glyph->type =3D=3D COMPOSITE_GLYPH= ; */ /* FIXME: composition: no vertical displacement is considered. */ =2D t+=3D s->gidx; /* advance into composition */ =2D for (i =3D0; inchars - s->gidx; i++, t++) + t+=3D s->x; /* advance into composition */ + for (i =3D0; inchars - s->x; i++, t++) { hi =3D (*t & 0xFF00) >> 8; lo =3D *t & 0x00FF; if (isComposite) { =2D cwidth =3D s->cmp->offsets[s->gidx++ * 2] - twidth; + cwidth =3D s->cmp->offsets[s->x++ * 2] - twidth; } else { @@ -1094,13 +1094,13 @@ nsfont_draw (struct glyph_string *s, int from, int = to, int x, int y, [col set]; =20 CGContextSetTextPosition (gcontext, r.origin.x, r.origin.y); =2D CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x, advances, len); =20 if (face->overstrike) { CGContextSetTextPosition (gcontext, r.origin.x+0.5, r.origin.y); =2D CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x, advances, len); } =20 --=-=-= Content-Transfer-Encoding: quoted-printable In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit) of 2008-08-29 on malibu.local Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t =2D-=20 Austin Frank http://aufrank.net GPG Public Key (D7398C2F): http://aufrank.net/personal.asc --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAki5hDgACgkQlHMl2/XbR4Gd2wCfVHK7wfQAv5do6+B7hsKoZJwR kTwAoLxR0MDYoUOD/iF25lh2t2n4/5F3 =xw6u -----END PGP SIGNATURE----- --==-=-=-- ------------=_1223057406-27669-4 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 823-done) by emacsbugs.donarmstrong.com; 3 Oct 2008 18:04:24 +0000 Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.188]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93I4Hsp025498 for <823-done@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 11:04:18 -0700 Received: by rn-out-0910.google.com with SMTP id j66so598348rne.20 for <823-done@emacsbugs.donarmstrong.com>; Fri, 03 Oct 2008 11:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=I2NbD8QY5lT3/ZR3xu3399fXk2i3NQWv+TkEDZWX80c=; b=SZyg3xvN1wzzlxhxfoNbTCnwNpVxcJFBe/cVq2VXJMmlv6kafZmJBB8qX3waJrziKk wa9mRUL+OPl1iK+mHMyuDU7S55YSST/oGy+f4ckKcsitEMntqohVIUz+XQctE505/aHB Amk9BGgHUOa3C4yyqqCSrTWd9skt7noL8/HIY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=ktHHniRqjTfpiVF4ktg262S0vNnCaCsY5CMJyuHMjDVieyX7jp/dbJmSOA+tQ1dSdR pcE4RcelyEXe8I1dzdmW5ng7Ecq7XH9u+DAEfUSylFlmBvTtL0VqWwVutAKRq93KndHZ l/RzSdLRCO4LP2AvTesg6sR0t3dR6DuOgmB10= Received: by 10.90.92.10 with SMTP id p10mr1584419agb.108.1223057056808; Fri, 03 Oct 2008 11:04:16 -0700 (PDT) Received: from ?10.0.1.199? ([72.169.150.82]) by mx.google.com with ESMTPS id p60sm2937715hsa.8.2008.10.03.11.03.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 03 Oct 2008 11:04:07 -0700 (PDT) Message-Id: <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com> From: Adrian Robert To: 823-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: #823 - 23.0.60; uninitialised variable gidx in nsfont.m - Emacs bug report logs Date: Fri, 3 Oct 2008 14:03:20 -0400 X-Mailer: Apple Mail (2.926) Summary: the variable gidx was removed during Kenichi Handa's update of composition handling and it took some time to update all of the code using it: On 2008-08-29 Kenichi Handa changed the glyph_string data structure, composition-related portion On 2008-09-07 Teodor Zlatanov fixed the compiler error by changing glyph_string.gidx to glyph_string.cmp_from On 2008-09-27 Adrian Robert updated this patch to approximate the behavior before Handa's changes ------------=_1223057406-27669-4--