bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)

unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
@ 2008-08-26 15:32 ` Christian Engels
  2008-09-02  2:06   ` Stefan Monnier
                     ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Christian Engels @ 2008-08-26 15:32 UTC (permalink / raw)
  To: emacs-pretest-bug

Perhaps this is only ido-mode related, i don't really now but here the bug 
report.
If you type C-x b you get a list of buffer and if your buffer you searched for 
is not there, you can type right here C-x C-f to get the find-file dialog.

Now do this with C-x 4 b. If you now try C-x C-f you get to the find-file 
dialog, but if you now enter one it doesn't open it in a new window but in 
the old one. I think this is a very unlogic behaviour.

Greetings
Christian Engels



In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-08-22 on d174
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using 
`configure  '--prefix=/opt/emacs' '--enable-font-backend' '--with-x-toolkit=gtk' '--with-xft=yes' '--with-freetype=yes' '--with-xpm=no' '--with-gif=no' '--with-dbus=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  rcirc-track-minor-mode: t
  diff-auto-refine-mode: t
  show-paren-mode: t
  jabber-activity-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: 1
  line-number-mode: t
  transient-mark-mode: t






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-08-26 15:32 ` bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related) Christian Engels
@ 2008-09-02  2:06   ` Stefan Monnier
  2008-09-02  2:49     ` Glenn Morris
  2008-09-03  0:25   ` Kim F. Storm
  2008-09-04 10:45   ` bug#781: marked as done (23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)) Emacs bug Tracking System
  2 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2008-09-02  2:06 UTC (permalink / raw)
  To: Christian Engels; +Cc: 781, emacs-pretest-bug

> Now do this with C-x 4 b. If you now try C-x C-f you get to the find-file 
> dialog, but if you now enter one it doesn't open it in a new window but in 
> the old one. I think this is a very unlogic behaviour.

I must be missing something: C-x C-f always opens the file in the
current (i.e. old) window, doesn't it?


        Stefan






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-09-02  2:06   ` Stefan Monnier
@ 2008-09-02  2:49     ` Glenn Morris
  2008-09-02 12:12       ` martin rudalics
  0 siblings, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2008-09-02  2:49 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 781, Christian Engels

Stefan Monnier wrote:

>> Now do this with C-x 4 b. If you now try C-x C-f you get to the find-file 
>> dialog, but if you now enter one it doesn't open it in a new window but in 
>> the old one. I think this is a very unlogic behaviour.
>
> I must be missing something: C-x C-f always opens the file in the
> current (i.e. old) window, doesn't it?

If ido is active, C-x 4 b runs ido-switch-buffer-other-window.

This calls ido-buffer-internal with method = 'other-window.

If you call C-x C-f from inside this, ido-file-internal gets called.

But it gets called with method = ido-default-file-method rather than
'other-window (though other-window is an option). The OP would prefer
the latter.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-09-02  2:49     ` Glenn Morris
@ 2008-09-02 12:12       ` martin rudalics
  0 siblings, 0 replies; 8+ messages in thread
From: martin rudalics @ 2008-09-02 12:12 UTC (permalink / raw)
  To: Glenn Morris, 781; +Cc: Kim F. Storm, Christian Engels

 > But it gets called with method = ido-default-file-method rather than
 > 'other-window (though other-window is an option). The OP would prefer
 > the latter.

Using plain `method' instead of `ido-default-file-method' works in this
particular case (we'd also have to cater for the 'other-frame case).
But I'm not sure about the argument for the fallback method.  Kim?

martin







^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-08-26 15:32 ` bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related) Christian Engels
  2008-09-02  2:06   ` Stefan Monnier
@ 2008-09-03  0:25   ` Kim F. Storm
  2008-09-03 17:59     ` Christian Engels
  2008-09-04 10:45   ` bug#781: marked as done (23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)) Emacs bug Tracking System
  2 siblings, 1 reply; 8+ messages in thread
From: Kim F. Storm @ 2008-09-03  0:25 UTC (permalink / raw)
  To: Christian Engels; +Cc: 781, emacs-pretest-bug

Christian Engels <s9chenge@stud.uni-saarland.de> writes:

> Perhaps this is only ido-mode related, i don't really now but here the bug 
> report.
> If you type C-x b you get a list of buffer and if your buffer you searched for 
> is not there, you can type right here C-x C-f to get the find-file dialog.
>
> Now do this with C-x 4 b. If you now try C-x C-f you get to the find-file 
> dialog, but if you now enter one it doesn't open it in a new window but in 
> the old one. I think this is a very unlogic behaviour.
>

There is a similar problem for C-x 4 C-f C-x C-b,
and C-x 5 ...

Does the following patch fix the problem for you?


*** ido.el	03 Sep 2008 00:33:03 +0200	1.147
--- ido.el	03 Sep 2008 02:23:35 +0200	
***************
*** 3960,3966 ****
  The buffer name is selected interactively by typing a substring.
  For details of keybindings, see `ido-switch-buffer'."
    (interactive)
!   (ido-buffer-internal 'other-window 'switch-to-buffer-other-window))
  
  ;;;###autoload
  (defun ido-display-buffer ()
--- 3960,3966 ----
  The buffer name is selected interactively by typing a substring.
  For details of keybindings, see `ido-switch-buffer'."
    (interactive)
!   (ido-buffer-internal 'other-window 'switch-to-buffer-other-window nil nil nil 'ido-find-file-other-window))
  
  ;;;###autoload
  (defun ido-display-buffer ()
***************
*** 3993,3999 ****
  For details of keybindings, see `ido-switch-buffer'."
    (interactive)
    (if ido-mode
!       (ido-buffer-internal 'other-frame)
      (call-interactively 'switch-to-buffer-other-frame)))
  
  ;;;###autoload
--- 3993,3999 ----
  For details of keybindings, see `ido-switch-buffer'."
    (interactive)
    (if ido-mode
!       (ido-buffer-internal 'other-frame nil nil nil nil 'ido-find-file-other-frame)
      (call-interactively 'switch-to-buffer-other-frame)))
  
  ;;;###autoload
***************
*** 4054,4060 ****
  The file name is selected interactively by typing a substring.
  For details of keybindings, see `ido-find-file'."
    (interactive)
!   (ido-file-internal 'other-window 'find-file-other-window))
  
  ;;;###autoload
  (defun ido-find-alternate-file ()
--- 4054,4060 ----
  The file name is selected interactively by typing a substring.
  For details of keybindings, see `ido-find-file'."
    (interactive)
!   (ido-file-internal 'other-window 'find-file-other-window nil nil nil nil 'ido-switch-buffer-other-window))
  
  ;;;###autoload
  (defun ido-find-alternate-file ()
***************
*** 4102,4108 ****
  The file name is selected interactively by typing a substring.
  For details of keybindings, see `ido-find-file'."
    (interactive)
!   (ido-file-internal 'other-frame 'find-file-other-frame))
  
  ;;;###autoload
  (defun ido-write-file ()
--- 4102,4108 ----
  The file name is selected interactively by typing a substring.
  For details of keybindings, see `ido-find-file'."
    (interactive)
!   (ido-file-internal 'other-frame 'find-file-other-frame nil nil nil nil 'ido-switch-buffer-other-frame))
  
  ;;;###autoload
  (defun ido-write-file ()







^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-09-03  0:25   ` Kim F. Storm
@ 2008-09-03 17:59     ` Christian Engels
  2008-09-04 10:03       ` Kim F. Storm
  0 siblings, 1 reply; 8+ messages in thread
From: Christian Engels @ 2008-09-03 17:59 UTC (permalink / raw)
  To: emacs-pretest-bug

On Wednesday 03 September 2008 02:25:01 you wrote:
> *** ido.el      03 Sep 2008 00:33:03 +0200      1.147
> --- ido.el      03 Sep 2008 02:23:35 +0200      
> ***************
> *** 3960,3966 ****
>   The buffer name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-switch-buffer'."
>     (interactive)
> !   (ido-buffer-internal 'other-window 'switch-to-buffer-other-window))
>  
>   ;;;###autoload
>   (defun ido-display-buffer ()
> --- 3960,3966 ----
>   The buffer name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-switch-buffer'."
>     (interactive)
> !   (ido-buffer-internal 'other-window 'switch-to-buffer-other-window nil
> nil nil 'ido-find-file-other-window)) 
>   ;;;###autoload
>   (defun ido-display-buffer ()
> ***************
> *** 3993,3999 ****
>   For details of keybindings, see `ido-switch-buffer'."
>     (interactive)
>     (if ido-mode
> !       (ido-buffer-internal 'other-frame)
>       (call-interactively 'switch-to-buffer-other-frame)))
>  
>   ;;;###autoload
> --- 3993,3999 ----
>   For details of keybindings, see `ido-switch-buffer'."
>     (interactive)
>     (if ido-mode
> !       (ido-buffer-internal 'other-frame nil nil nil nil
> 'ido-find-file-other-frame) (call-interactively
> 'switch-to-buffer-other-frame)))
>  
>   ;;;###autoload
> ***************
> *** 4054,4060 ****
>   The file name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-find-file'."
>     (interactive)
> !   (ido-file-internal 'other-window 'find-file-other-window))
>  
>   ;;;###autoload
>   (defun ido-find-alternate-file ()
> --- 4054,4060 ----
>   The file name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-find-file'."
>     (interactive)
> !   (ido-file-internal 'other-window 'find-file-other-window nil nil nil
> nil 'ido-switch-buffer-other-window)) 
>   ;;;###autoload
>   (defun ido-find-alternate-file ()
> ***************
> *** 4102,4108 ****
>   The file name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-find-file'."
>     (interactive)
> !   (ido-file-internal 'other-frame 'find-file-other-frame))
>  
>   ;;;###autoload
>   (defun ido-write-file ()
> --- 4102,4108 ----
>   The file name is selected interactively by typing a substring.
>   For details of keybindings, see `ido-find-file'."
>     (interactive)
> !   (ido-file-internal 'other-frame 'find-file-other-frame nil nil nil nil
> 'ido-switch-buffer-other-frame)) 
>   ;;;###autoload
>   (defun ido-write-file ()

Hello.
Ok i am not really sure if it did the patching right, so perhaps somebody 
should verify this. But if i try to C-x 4 b and C-x C-f after that i get 
a "Command attempted to use minibuffer while in minibuffer". The same for C-x 
4 b C-x 4 f.

Greetings
Christian Engels







^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
  2008-09-03 17:59     ` Christian Engels
@ 2008-09-04 10:03       ` Kim F. Storm
  0 siblings, 0 replies; 8+ messages in thread
From: Kim F. Storm @ 2008-09-04 10:03 UTC (permalink / raw)
  To: Christian Engels; +Cc: 781, emacs-pretest-bug

Christian Engels <s9chenge@stud.uni-saarland.de> writes:

> Ok i am not really sure if it did the patching right, so perhaps somebody 
> should verify this. But if i try to C-x 4 b and C-x C-f after that i get 
> a "Command attempted to use minibuffer while in minibuffer". The same for C-x 
> 4 b C-x 4 f.

Yes, the proposed fix only works with enable-recursive-minibuffers .
I have just checked in a better fix.

So can someone pls. close this...

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk







^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#781: marked as done (23.0.60; C-x C-f after C-x 4 b doesn't  work (perhaps ido-mode related))
  2008-08-26 15:32 ` bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related) Christian Engels
  2008-09-02  2:06   ` Stefan Monnier
  2008-09-03  0:25   ` Kim F. Storm
@ 2008-09-04 10:45   ` Emacs bug Tracking System
  2 siblings, 0 replies; 8+ messages in thread
From: Emacs bug Tracking System @ 2008-09-04 10:45 UTC (permalink / raw)
  To: Juanma Barranquero

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Your message dated Thu, 4 Sep 2008 12:39:58 +0200
with message-id <f7ccd24b0809040339q59d8cadch74b892855444e8d4@mail.gmail.com>
and subject line 
has caused the Emacs bug report #781,
regarding 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)

-- 
781: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=781
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3982 bytes --]

From: Christian Engels <s9chenge@stud.uni-saarland.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)
Date: Tue, 26 Aug 2008 17:32:02 +0200
Message-ID: <200808261732.03275.s9chenge@stud.uni-saarland.de>

Perhaps this is only ido-mode related, i don't really now but here the bug 
report.
If you type C-x b you get a list of buffer and if your buffer you searched for 
is not there, you can type right here C-x C-f to get the find-file dialog.

Now do this with C-x 4 b. If you now try C-x C-f you get to the find-file 
dialog, but if you now enter one it doesn't open it in a new window but in 
the old one. I think this is a very unlogic behaviour.

Greetings
Christian Engels

In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-08-22 on d174
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using 
`configure  '--prefix=/opt/emacs' '--enable-font-backend' '--with-x-toolkit=gtk' '--with-xft=yes' '--with-freetype=yes' '--with-xpm=no' '--with-gif=no' '--with-dbus=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  rcirc-track-minor-mode: t
  diff-auto-refine-mode: t
  show-paren-mode: t
  jabber-activity-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: 1
  line-number-mode: t
  transient-mark-mode: t

[-- Attachment #3: Type: message/rfc822, Size: 2193 bytes --]

From: "Juanma Barranquero" <lekktu@gmail.com>
To: 781-done@emacsbugs.donarmstrong.com
Subject: 
Date: Thu, 4 Sep 2008 12:39:58 +0200
Message-ID: <f7ccd24b0809040339q59d8cadch74b892855444e8d4@mail.gmail.com>

Kim F. Storm checked in a fix.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-09-04 10:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <f7ccd24b0809040339q59d8cadch74b892855444e8d4@mail.gmail.com>
2008-08-26 15:32 ` bug#781: 23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related) Christian Engels
2008-09-02  2:06   ` Stefan Monnier
2008-09-02  2:49     ` Glenn Morris
2008-09-02 12:12       ` martin rudalics
2008-09-03  0:25   ` Kim F. Storm
2008-09-03 17:59     ` Christian Engels
2008-09-04 10:03       ` Kim F. Storm
2008-09-04 10:45   ` bug#781: marked as done (23.0.60; C-x C-f after C-x 4 b doesn't work (perhaps ido-mode related)) Emacs bug Tracking System

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).