bug#696: marked as done (regexp problem in ldap.el)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]


Your message dated Tue, 12 Aug 2008 14:42:04 -0400
with message-id <8763q6vzwj.fsf@stupidchicken.com>
and subject line Re: regexp problem in ldap.el
has caused the Emacs bug report #678,
regarding regexp problem in ldap.el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4579 bytes --]

From: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net (中川 誠)
To: "bug-gnu-emacs@gnu.org" <bug-gnu-emacs@gnu.org>
Subject: Re: regexp problem in ldap.el
Date: Tue, 12 Aug 2008 04:39:02 +0900
Message-ID: <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>

Hi,

According to the rfc4512, \w is not good to match aginst attribuite type
and options.  Wtith the attached patch, options containing hyphens are
sucessfully parsed.

P.S.

I submitted a bug report about regexp in ldap-search-internal last
December, but now I understand that it was a mistake.

-- 
/***   Hewlett-Packard Japan, Ltd.                                ***/
/***   Consulting & Integration                                   ***/
/***   PC-CW-SOL#1 Professional Center                            ***/
/***   Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In)        ***/
/***   PGP: 0B33 EAC3 F2F6 3D10 D9E9  AE7F 8EDA 44F9 1D29 D44A    ***/
--[[application/octet-stream; type=patch]「7bit]]
--- ldap.orig.el	2008-08-09 08:04:07.000000000 +0900
+++ ldap.el	2008-08-09 22:37:05.000000000 +0900
@@ -582,9 +582,9 @@
 					       (end-of-line)
 					       (point))))
 	  (forward-line 1)
-	  (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(&lt;[\t ]*file://\\)\\(.*\\)$")
+	  (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$")
 	    (setq name (match-string 1)
-		  value (match-string 4))
+		  value (match-string 5))
             ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP
             ;; on DOS/Windows as local files.
             (if (and (memq system-type '(windows-nt ms-dos))




[-- Attachment #3: Type: message/rfc822, Size: 1236 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net
Cc: 678-done@emacsbugs.donarmstrong.com, gha03025@nifty.ne.jp
Subject: Re: regexp problem in ldap.el
Date: Tue, 12 Aug 2008 14:42:04 -0400
Message-ID: <8763q6vzwj.fsf@stupidchicken.com>

> According to the rfc4512, \w is not good to match against attribute
> type and options.  With the attached patch, options containing hyphens
> are successfully parsed.

I've checked in a slightly altered version of your patch into CVS.
Thanks very much.