From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#679: marked as done (23.0.60; Function json-read-number does not handle complete Javascript spec) Date: Thu, 28 Aug 2008 13:30:04 -0700 Message-ID: References: <87sksoc2kv.fsf@cyd.mit.edu> <20080809070528.26869.qmail@priss.frightenedpiglet.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1219955404-4550-0" X-Trace: ger.gmane.org 1219956586 17642 80.91.229.12 (28 Aug 2008 20:49:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Aug 2008 20:49:46 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 28 22:50:39 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYoRw-0000BY-DW for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Aug 2008 22:50:39 +0200 Original-Received: from localhost ([127.0.0.1]:54884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYoQw-0002hr-A6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Aug 2008 16:49:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYoP4-0001zd-FS for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 16:47:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYoP1-0001xL-5g for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 16:47:37 -0400 Original-Received: from [199.232.76.173] (port=47649 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYoP0-0001x9-C7 for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 16:47:34 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:39621) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYoOy-0000tX-Rv for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2008 16:47:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7SKlTId010702; Thu, 28 Aug 2008 13:47:29 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7SKU4Ds004638; Thu, 28 Aug 2008 13:30:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 679 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19833 Archived-At: This is a multi-part message in MIME format... ------------=_1219955404-4550-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 28 Aug 2008 16:22:08 -0400 with message-id <87sksoc2kv.fsf@cyd.mit.edu> and subject line Re: 23.0.60; Function json-read-number does not handle com= plete Javascript spec has caused the Emacs bug report #679, regarding 23.0.60; Function json-read-number does not handle complete Javas= cript spec to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 679: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D679 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1219955404-4550-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Aug 2008 08:37:17 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m798bDHO026483 for ; Sat, 9 Aug 2008 01:37:14 -0700 Received: from mail.gnu.org ([199.232.76.166]:53052 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KRjvj-0003KO-4D for emacs-pretest-bug@gnu.org; Sat, 09 Aug 2008 04:36:07 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KRjwk-000845-Qq for emacs-pretest-bug@gnu.org; Sat, 09 Aug 2008 04:37:12 -0400 Received: from v-static-143-234.avvanta.com ([206.124.143.234]:47102 helo=priss.frightenedpiglet.com) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KRjwk-0007xU-3O for emacs-pretest-bug@gnu.org; Sat, 09 Aug 2008 04:37:10 -0400 Received: (qmail 26870 invoked by uid 1000); 9 Aug 2008 07:05:28 -0000 Date: 9 Aug 2008 07:05:28 -0000 Message-ID: <20080809070528.26869.qmail@priss.frightenedpiglet.com> From: sand@blarg.net To: emacs-pretest-bug@gnu.org CC: rfrancoise@debian.org Subject: 23.0.60; Function json-read-number does not handle complete Javascript spec X-URL: http://home.blarg.net/~sand X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Greylist: delayed 1951 seconds by postgrey-1.27 at monty-python; Sat, 09 Aug 2008 04:36:46 EDT ---- In json.el, the 'json-read-number' function is intended to read the textual representation of Javascript numbers. (defun json-read-number () "Read the JSON number following point. N.B.: Only numbers which can fit in Emacs Lisp's native number representation will be parsed correctly." (if (char-equal (json-peek) ?-) (progn (json-advance) (- 0 (json-read-number))) (if (looking-at "[0-9]+\\([.][0-9]+\\)?\\([eE][+-]?[0-9]+\\)?") (progn (goto-char (match-end 0)) (string-to-number (match-string 0))) (signal 'json-number-format (list (point)))))) The Javascript spec (http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Guide:Literals#Floating-Point_Literals) says the following about floating-point numbers: | A floating-point literal can have the following parts: | | * A decimal integer which can be signed (preceded by "+" or "-"), | * A decimal point ("."), | * A fraction (another decimal number), | * An exponent. | | The exponent part is an "e" or "E" followed by an integer, which can | be signed (preceded by "+" or "-"). A floating-point literal must have | at least one digit and either a decimal point or "e" (or "E"). This means that 1. is a valid floating point-literal per the spec, but the regular expression above does not match the complete text---the regular expression requires digits after the decimal point. This ends up matched as a simple integer, leaving the decimal point in the input stream and causing a later syntax error. Similarly .1 is a valid floating point-literal illegal that Emacs rejects, because the regular expression requires digits before the decimal point. Testing with the error console in Firefox confirms that the two examples above are valid syntax. The parser function needs to be fixed to handle the complete syntax. ---- In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-07-27 on elegiac, modified by Debian (emacs-snapshot package, version 1:20080727-1) Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: POSIX value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: VM Minor modes in effect: shell-dirtrack-mode: t auto-image-file-mode: t show-paren-mode: t icomplete-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t ------------=_1219955404-4550-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 679-done) by emacsbugs.donarmstrong.com; 28 Aug 2008 20:20:16 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7SKKD0M001915 for <679-done@emacsbugs.donarmstrong.com>; Thu, 28 Aug 2008 13:20:14 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id E066057E186; Thu, 28 Aug 2008 16:22:08 -0400 (EDT) To: "Edward O'Connor" Cc: 679-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; Function json-read-number does not handle complete Javascript spec From: Chong Yidong Date: Thu, 28 Aug 2008 16:22:08 -0400 Message-ID: <87sksoc2kv.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I've attached a modified version, which disallows octal & hexadecimal. Checked in, thanks. ------------=_1219955404-4550-0--