bug#5296: vc-rcs rcsdiff -u1 -> -u -1

bug#5296: vc-rcs rcsdiff -u1 -> -u -1

[Karl Berry]

In Emacs 23.1, doing vc-diff on an RCS file results in an error with
GNU diff 2.8.1 (or later):

/usr/bin/diff: `-1' option is obsolete; use `-U 1'                          
..

The *Messages* buffer reports:
vc-do-command: Running rcsdiff -q   -p -u1 maintainers...FAILED (status 2)

I could not quickly tell where the invocation was in vc-rcs.el, but
afaik replacing -u1 with -u 1 (or -U 1) is the solution.  (The workaround for
users is to set _POSIX2_VERSION=0 in the environment.)

karl

bug#5296: vc-rcs rcsdiff -u1 -> -u -1

[Dan Nicolaescu]

karl@freefriends.org (Karl Berry) writes:

  > In Emacs 23.1, doing vc-diff on an RCS file results in an error with
  > GNU diff 2.8.1 (or later):
  > 
  > /usr/bin/diff: `-1' option is obsolete; use `-U 1'                          
  > ..
  > 
  > The *Messages* buffer reports:
  > vc-do-command: Running rcsdiff -q   -p -u1 maintainers...FAILED (status 2)
  > 
  > I could not quickly tell where the invocation was in vc-rcs.el, but
  > afaik replacing -u1 with -u 1 (or -U 1) is the solution.  (The workaround for
  > users is to set _POSIX2_VERSION=0 in the environment.)

Do you set `diff-switches' to "-u1" ?

This call:
(vc-switches 'RCS 'diff)
in `vc-rcs-diff' uses `diff-switches', and passes the result to "rcsdiff".

Not sure what to do here.  We already have a bug:
#4422: diff-switches is a bad idea

bug#5296: vc-rcs rcsdiff -u1 -> -u -1

[Karl Berry]

    Do you set `diff-switches' to "-u1" ?

You're completely right (I did that umpteen years ago).  Sorry for
wasting everyone's time.

    #4422: diff-switches is a bad idea

Despite my own bug, I don't agree it's a bad idea.

bug#5296: marked as done (vc-rcs rcsdiff -u1 -> -u -1)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

Your message dated Sun, 3 Jan 2010 19:55:42 -0800 (PST)
with message-id <201001040355.o043tgnf016355@godzilla.ics.uci.edu>
and subject line Re: bug#5296: vc-rcs rcsdiff -u1 -> -u -1
has caused the Emacs bug report #5296,
regarding vc-rcs rcsdiff -u1 -> -u -1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)


-- 
5296: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5296
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 4969 bytes --]

From: karl@freefriends.org (Karl Berry)
To: bug-emacs@gnu.org
Subject: vc-rcs rcsdiff -u1 -> -u -1
Date: Sat, 2 Jan 2010 22:49:43 GMT
Message-ID: <201001022249.o02Mnhx5010096@f7.net>

In Emacs 23.1, doing vc-diff on an RCS file results in an error with
GNU diff 2.8.1 (or later):

/usr/bin/diff: `-1' option is obsolete; use `-U 1'                          
..

The *Messages* buffer reports:
vc-do-command: Running rcsdiff -q   -p -u1 maintainers...FAILED (status 2)

I could not quickly tell where the invocation was in vc-rcs.el, but
afaik replacing -u1 with -u 1 (or -U 1) is the solution.  (The workaround for
users is to set _POSIX2_VERSION=0 in the environment.)

karl




[-- Attachment #3: Type: message/rfc822, Size: 2860 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: karl@freefriends.org (Karl Berry)
Cc: 5296-done@debbugs.gnu.org
Subject: Re: bug#5296: vc-rcs rcsdiff -u1 -> -u -1
Date: Sun, 3 Jan 2010 19:55:42 -0800 (PST)
Message-ID: <201001040355.o043tgnf016355@godzilla.ics.uci.edu>

karl@freefriends.org (Karl Berry) writes:

  >     Do you set `diff-switches' to "-u1" ?
  > 
  > You're completely right (I did that umpteen years ago).

In that case we can close the bug.