From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4981: marked as done (C-l during query-replace) Date: Mon, 30 Nov 2009 16:30:14 +0000 Message-ID: References: <87skbwt9xq.fsf@mail.jurta.org> <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1259598614-32426-0" X-Trace: ger.gmane.org 1259601207 6848 80.91.229.12 (30 Nov 2009 17:13:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 17:13:27 +0000 (UTC) To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 18:13:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NF9oN-00086z-CI for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 18:13:19 +0100 Original-Received: from localhost ([127.0.0.1]:44805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9oM-0003ZC-NF for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 12:13:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF9PZ-000864-5F for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF9PQ-00082e-R2 for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:38 -0500 Original-Received: from [199.232.76.173] (port=58701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9PN-000810-Fi for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42068) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NF9PL-0007OI-To for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:29 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGlN8m001381; Mon, 30 Nov 2009 08:47:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUGUEjv032440; Mon, 30 Nov 2009 08:30:14 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4981 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33071 Archived-At: This is a multi-part message in MIME format... ------------=_1259598614-32426-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 30 Nov 2009 18:06:33 +0200 with message-id <87skbwt9xq.fsf@mail.jurta.org> and subject line Re: bug#4981: C-l during query-replace has caused the Emacs bug report #4981, regarding C-l during query-replace to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4981: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4981 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1259598614-32426-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 20 Nov 2009 00:18:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAK0IfcA030752 for ; Thu, 19 Nov 2009 16:18:43 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBHCz-0008Oc-Cn for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBHCu-0008I6-Su for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:41 -0500 Received: from [199.232.76.173] (port=50487 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBHCu-0008Hr-LB for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:36 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:53702) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBHCu-0001bv-7h for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:36 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAK0H0VS014000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 19 Nov 2009 16:17:00 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAK0Gxf5005670; Thu, 19 Nov 2009 16:16:59 -0800 (PST) Date: Thu, 19 Nov 2009 16:16:59 -0800 (PST) Message-Id: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: C-l during query-replace X-Debbugs-No-Ack: yes Lines: 3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAK0H0VS014000 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) C-l during query-replace should run `recenter-top-bottom', not `recenter' for consistency with what C-l normally does nowadays. ------------=_1259598614-32426-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4981-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMGC2031748 for <4981-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:17 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id A3AAD3F4096; Mon, 30 Nov 2009 18:22:08 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 4981-done@emacsbugs.donarmstrong.com, Dan Nicolaescu Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 18:06:33 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 Nov 2009 20:28:07 -0500") Message-ID: <87skbwt9xq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Why not: > >> Index: lisp/replace.el >> =================================================================== >> RCS file: /sources/emacs/emacs/lisp/replace.el,v >> retrieving revision 1.287 >> diff -u -r1.287 replace.el >> --- lisp/replace.el 12 Nov 2009 06:55:43 -0000 1.287 >> +++ lisp/replace.el 29 Nov 2009 23:43:28 -0000 >> @@ -1785,7 +1788,9 @@ >> ((eq def 'skip) >> (setq done t)) >> ((eq def 'recenter) >> - (recenter nil)) >> + (let ((this-command 'recenter-top-bottom)) >> + (recenter-top-bottom))) >> ((eq def 'edit) >> (let ((opos (point-marker))) >> (setq real-match-data (replace-match-data Thanks, this helped. Fixed with more changes to keep the cycling order. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1259598614-32426-0--