From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4927: marked as done (23.1; checkdoc-proper-noun-regexp with regexp-opt) Date: Tue, 24 Nov 2009 23:20:05 +0000 Message-ID: References: <87zl6b349k.fsf@blah.blah> <87lji8zsqr.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1259104805-2871-0" X-Trace: ger.gmane.org 1259105266 2019 80.91.229.12 (24 Nov 2009 23:27:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Nov 2009 23:27:46 +0000 (UTC) To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 00:27:39 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ND4nI-0006zS-BA for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2009 00:27:36 +0100 Original-Received: from localhost ([127.0.0.1]:52185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ND4nH-00058H-AM for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2009 18:27:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ND4nC-00057T-BR for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 18:27:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ND4n7-00055Q-MC for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 18:27:29 -0500 Original-Received: from [199.232.76.173] (port=38523 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ND4n7-00055N-HD for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 18:27:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53111) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ND4n6-0004YM-Iq for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2009 18:27:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAONRMRf003569; Tue, 24 Nov 2009 15:27:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAONK5SO002901; Tue, 24 Nov 2009 15:20:05 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4927 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32896 Archived-At: This is a multi-part message in MIME format... ------------=_1259104805-2871-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 25 Nov 2009 10:13:43 +1100 with message-id <87zl6b349k.fsf@blah.blah> and subject line Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regex= p-opt has caused the Emacs bug report #4927, regarding 23.1; checkdoc-proper-noun-regexp with regexp-opt to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4927: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4927 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1259104805-2871-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Nov 2009 21:44:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,FOURLA,FVGT_m_MULTI_ODD autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAELilsl008191 for ; Sat, 14 Nov 2009 13:44:49 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9QQJ-0006p5-7p for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9QQC-0006j4-Rd for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:45 -0500 Received: from [199.232.76.173] (port=48358 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9QQC-0006ii-LY for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:40 -0500 Received: from mailout2-5.pacific.net.au ([61.8.2.228]:40389 helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9QQB-00022M-OM for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:40 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 8EB3B1937B9 for ; Sun, 15 Nov 2009 08:44:30 +1100 (EST) Received: from blah.blah (ppp20E0.dyn.pacific.net.au [61.8.32.224]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id CDE242740A for ; Sun, 15 Nov 2009 08:44:29 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1N9QQ0-0001Ee-QL for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 08:44:28 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; checkdoc-proper-noun-regexp with regexp-opt Date: Sun, 15 Nov 2009 08:44:28 +1100 Message-ID: <87lji8zsqr.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= This is the simplification I mentioned before for the way checkdoc-proper-noun-regexp is built. You'd be tempted to build the regexp within checkdoc-proper-noun-region-engine (maybe just with mapconcat) for easier customizing of checkdoc-proper-noun-list, but I suppose nobody changes it. 2009-11-13 Kevin Ryde * emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Build value with regexp-opt instead of explicit joining loop. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=checkdoc.el.regexp-opt.diff --- checkdoc.el.~1.80.~ 2009-11-09 08:46:10.000000000 +1100 +++ checkdoc.el 2009-11-09 09:33:33.000000000 +1100 @@ -334,12 +334,9 @@ ;; "[.!?]" is for noun at end of a sentence, since those chars ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>. ;; The \" allows it to be the last sentence in a docstring too. - (let ((expr "\\_<\\(") - (l checkdoc-proper-noun-list)) - (while l - (setq expr (concat expr (car l) (if (cdr l) "\\|" "")) - l (cdr l))) - (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)")) + (concat "\\_<" + (regexp-opt checkdoc-proper-noun-list t) + "\\(\\_>\\|[.!?][ \t\n\"]\\)") "Regular expression derived from `checkdoc-proper-noun-regexp'.") (defvar checkdoc-common-verbs-regexp nil --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t --=-=-=-- ------------=_1259104805-2871-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4927-done) by emacsbugs.donarmstrong.com; 24 Nov 2009 23:13:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailout1.pacific.net.au (mailout1-1.pacific.net.au [61.8.2.208]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAONDujL002443 for <4927-done@emacsbugs.donarmstrong.com>; Tue, 24 Nov 2009 15:13:57 -0800 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id B29D1510DF2 for <4927-done@emacsbugs.donarmstrong.com>; Wed, 25 Nov 2009 10:13:55 +1100 (EST) Received: from blah.blah (ppp291C.dyn.pacific.net.au [61.8.41.28]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 448962741D for <4927-done@emacsbugs.donarmstrong.com>; Wed, 25 Nov 2009 10:13:55 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1ND4Zr-0000vq-Ok for 4927-done@emacsbugs.donarmstrong.com; Wed, 25 Nov 2009 10:13:43 +1100 From: Kevin Ryde To: 4927-done@emacsbugs.donarmstrong.com Subject: Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt References: <87lji8zsqr.fsf@blah.blah> Date: Wed, 25 Nov 2009 10:13:43 +1100 In-Reply-To: (Glenn Morris's message of "Mon, 16 Nov 2009 23:42:09 -0500") Message-ID: <87zl6b349k.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Glenn Morris writes: > > I think you should feel free to just install this kind of thing, > without needing to create a bug report. Done. ------------=_1259104805-2871-0--