From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4485: marked as done (23.1; bookmark-save performances) Date: Sun, 20 Sep 2009 15:05:06 +0000 Message-ID: References: <87d45n4a03.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1253459106-21948-0" X-Trace: ger.gmane.org 1253459245 933 80.91.229.12 (20 Sep 2009 15:07:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2009 15:07:25 +0000 (UTC) To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 20 17:07:18 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MpO0R-0003KJ-OO for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2009 17:07:18 +0200 Original-Received: from localhost ([127.0.0.1]:47344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpO0Q-0006Nh-RF for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2009 11:07:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpO0M-0006MX-Gz for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2009 11:07:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpO0I-0006HO-PU for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2009 11:07:10 -0400 Original-Received: from [199.232.76.173] (port=54636 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpO0I-0006HH-N3 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2009 11:07:06 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54894) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpO0H-0008NJ-NO for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2009 11:07:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8KF72bF022883; Sun, 20 Sep 2009 08:07:03 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8KF562P022106; Sun, 20 Sep 2009 08:05:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4485 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31303 Archived-At: This is a multi-part message in MIME format... ------------=_1253459106-21948-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sun, 20 Sep 2009 10:55:43 -0400 with message-id and subject line Re: bug#4485: 23.1; bookmark-save performances has caused the Emacs bug report #4485, regarding 23.1; bookmark-save performances to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4485: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4485 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1253459106-21948-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 19 Sep 2009 08:31:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,FOURLA,RCVD_IN_NIX1 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8J8VMcE015281 for ; Sat, 19 Sep 2009 01:31:24 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MovLm-0006j9-AA for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 04:31:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MovLh-0006ij-Ln for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 04:31:21 -0400 Received: from [199.232.76.173] (port=54312 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MovLh-0006ig-IT for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 04:31:17 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:49723) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MovLh-0000hk-2V for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 04:31:17 -0400 Received: by ewy7 with SMTP id 7so1841233ewy.31 for ; Sat, 19 Sep 2009 01:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:organization :date:message-id:user-agent:mime-version:content-type; bh=f/HTzxwdg7vJbwrf0nXVB2haYUP8aYkJYMbLB3r+V1c=; b=o1ceUdGNJ0oz3q9+YvhgzD/nRnrxDQQH2D5WBBVmPvRvLz9MihcXKMOHVNOFOUh5u4 EKTQkvivtUPpooyRLaGYbbM1UNfIwuEraRH8zzLKVaI8IBui7WbNtZzMCjKGmVQHpq4m ZVjaynDJL17GLpN7hnhQ4UIdtClqK+VZiu64E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:organization:date:message-id:user-agent :mime-version:content-type; b=Th9FUwMUM+c+QZ4Fie4oQKx1Xh88CHvUmck1fmnJgIG0yN5xAka0AIwACWPwiw1szj f9YvMJNyquZvf8Q3wUTNj3fDFa6nn7UABKswfxFgtbhnYVL8JrUvvXz7j0m7Thqc5FPe RSg0MeDqm7Cg2fR7UsUPYRM/kiRAXXY/g/HNI= Received: by 10.211.147.10 with SMTP id z10mr474367ebn.28.1253349074202; Sat, 19 Sep 2009 01:31:14 -0700 (PDT) Received: from tux.homenetwork (195.77.197-77.rev.gaoland.net [77.197.77.195]) by mx.google.com with ESMTPS id 28sm1965730eye.14.2009.09.19.01.31.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 19 Sep 2009 01:31:13 -0700 (PDT) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 23.1; bookmark-save performances Organization: ThierryVolpiatto Date: Sat, 19 Sep 2009 10:25:00 +0200 Message-ID: <87d45n4a03.fsf@tux.homenetwork> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Hi, with current version of `bookmark-write-file' saving a big list of bookmarks is very long: More than 50s for 195 bookmarks. That's because entire `bookmark-alist' is given to pp: ,----[ bookmark.el:bookmark-write-file ] | (pp bookmark-alist (current-buffer)) `---- With this modification i made in bookmark+.el, for same 195 bookmarks, it take only 1.24s: ,----[ bookmark+.el:bookmark-write-file ] | (progn (insert "(") | (dolist (i bookmark-alist) (pp i (current-buffer))) | (insert ")")) `---- Little chunks of `bookmark-alist' are given one by one to pp and that is faster. NOTE: Measures were made with elp-instrument-* If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-07-31 on tux Windowing system distributor `The X.Org Foundation', version 11.0.10503000 configured using `configure '--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=i686 -pipe -O2' 'LDFLAGS=-Wl,-O1'' Important settings: value of $LC_ALL: fr_FR.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: eldoc-mode: t icomplete-mode: t icicle-mode: t delete-selection-mode: t minibuffer-depth-indicate-mode: t auto-image-file-mode: t shell-dirtrack-mode: t partial-completion-mode: t show-paren-mode: t display-battery-mode: t display-time-mode: t diff-auto-refine-mode: t outline-minor-mode: t recentf-mode: t savehist-mode: t desktop-save-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: a C-c C-b w r i t e C-SPC C-n C-n C-n M-w a C-c C-b w r i t e C-SPC C-e M-w M-x r e p o r t Recent messages: bunzip2ing elisp.info.bz2...done bunzip2ing elisp-11.info.bz2...done Type C-x 4 C-o RET to restore the other window, C-M-v to scroll help. [2 times] [2 times] Mark set [2 times] [2 times] Mark set Auto-saving... Mark set Computing completion candidates... -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France ------------=_1253459106-21948-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4485-done) by emacsbugs.donarmstrong.com; 20 Sep 2009 14:55:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.183]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8KEtmFf020764 for <4485-done@emacsbugs.donarmstrong.com>; Sun, 20 Sep 2009 07:55:49 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: As4EAObetUpFxL35/2dsb2JhbACBUstHhBsFh34 X-IronPort-AV: E=Sophos;i="4.44,419,1249272000"; d="scan'208";a="46162864" Received: from 69-196-189-249.dsl.teksavvy.com (HELO pastel.home) ([69.196.189.249]) by ironport2-out.pppoe.ca with ESMTP; 20 Sep 2009 10:55:43 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0A9178079; Sun, 20 Sep 2009 10:55:43 -0400 (EDT) From: Stefan Monnier To: Thierry Volpiatto Subject: Re: bug#4485: 23.1; bookmark-save performances Message-ID: References: <87d45n4a03.fsf@tux.homenetwork> Date: Sun, 20 Sep 2009 10:55:43 -0400 In-Reply-To: <87d45n4a03.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Sat, 19 Sep 2009 10:25:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Hi, with current version of `bookmark-write-file' saving a big list of > bookmarks is very long: > More than 50s for 195 bookmarks. > That's because entire `bookmark-alist' is given to pp: > ,----[ bookmark.el:bookmark-write-file ] > | (pp bookmark-alist (current-buffer)) > `---- > With this modification i made in bookmark+.el, for same 195 bookmarks, > it take only 1.24s: > ,----[ bookmark+.el:bookmark-write-file ] > | (progn (insert "(") > | (dolist (i bookmark-alist) (pp i (current-buffer))) > | (insert ")")) > `---- > Little chunks of `bookmark-alist' are given one by one to pp and that is > faster. Thank you very much. I've installed your patch, Stefan ------------=_1253459106-21948-0--