From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4434: marked as done (add -Wdeclaration-after-statement to CFLAGS if supported) Date: Fri, 20 Nov 2009 16:35:09 +0000 Message-ID: References: <200911201630.nAKGUpEI024572@godzilla.ics.uci.edu> <200909141916.n8EJGGJJ023826@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1258734909-27433-0" X-Trace: ger.gmane.org 1258736450 17864 80.91.229.12 (20 Nov 2009 17:00:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Nov 2009 17:00:50 +0000 (UTC) To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 20 18:00:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBWqd-0004Fo-W5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Nov 2009 18:00:40 +0100 Original-Received: from localhost ([127.0.0.1]:35378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBWqc-0005Uj-Tx for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Nov 2009 12:00:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBWdx-000119-RB for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:47:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBWds-0000uj-RM for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:47:32 -0500 Original-Received: from [199.232.76.173] (port=34697 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBWdp-0000ts-KE for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:47:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52758) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBWdo-0006Ua-NR for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:47:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAKGlLhm028446; Fri, 20 Nov 2009 08:47:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAKGZ9FX027472; Fri, 20 Nov 2009 08:35:09 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4434 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32773 Archived-At: This is a multi-part message in MIME format... ------------=_1258734909-27433-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 20 Nov 2009 08:30:51 -0800 (PST) with message-id <200911201630.nAKGUpEI024572@godzilla.ics.uci.edu> and subject line Re: bug#4434: add -Wdeclaration-after-statement to CFLAGS = if supported has caused the Emacs bug report #4434, regarding add -Wdeclaration-after-statement to CFLAGS if supported to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4434: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4434 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1258734909-27433-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 19:18:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EJIOEL027862 for ; Mon, 14 Sep 2009 12:18:25 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnH4C-0004yL-0r for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:18:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnH47-0004t9-Qz for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:18:23 -0400 Received: from [199.232.76.173] (port=34886 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnH47-0004sm-03 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:18:19 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:46775) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MnH42-0003Hm-Ro for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:18:15 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8EJGGwD005684 for ; Mon, 14 Sep 2009 12:16:16 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8EJGGJJ023826; Mon, 14 Sep 2009 12:16:16 -0700 (PDT) Date: Mon, 14 Sep 2009 12:16:16 -0700 (PDT) Message-Id: <200909141916.n8EJGGJJ023826@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: add -Wdeclaration-after-statement to CFLAGS if supported Lines: 40 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8EJGGwD005684 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) Recently we've had a few instances of declarations being added in the middle of a block. gcc has a flag to warn about this. Here's a patch to add this flag to CFLAGS (it mirrors what we already do for -Wno-pointer-sign). OK to check in? Index: configure.in =================================================================== RCS file: /cvsroot/emacs/emacs/configure.in,v retrieving revision 1.607 diff -u -3 -p -u -p -r1.607 configure.in --- configure.in 23 Aug 2009 02:15:00 -0000 1.607 +++ configure.in 14 Sep 2009 18:46:36 -0000 @@ -757,6 +757,19 @@ CFLAGS="$SAVE_CFLAGS" unset has_option unset SAVE_CFLAGS +### Use -Wdeclaration-after-statement if the compiler supports it +AC_MSG_CHECKING([whether gcc understands -Wdeclaration-after-statement]) +SAVE_CFLAGS="$CFLAGS" +CFLAGS="$CFLAGS -Wdeclaration-after-statement" +AC_TRY_COMPILE([], [], has_option=yes, has_option=no,) +if test $has_option = yes; then + C_WARNINGS_SWITCH="-Wdeclaration-after-statement $C_WARNINGS_SWITCH" +fi +AC_MSG_RESULT($has_option) +CFLAGS="$SAVE_CFLAGS" +unset has_option +unset SAVE_CFLAGS + #### Some other nice autoconf tests. dnl checks for programs ------------=_1258734909-27433-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4434-done) by emacsbugs.donarmstrong.com; 20 Nov 2009 16:31:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAKGV4pl027270 for <4434-done@emacsbugs.donarmstrong.com>; Fri, 20 Nov 2009 08:31:05 -0800 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAKGUpeB025878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Nov 2009 08:30:51 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAKGUpEI024572; Fri, 20 Nov 2009 08:30:51 -0800 (PST) Date: Fri, 20 Nov 2009 08:30:51 -0800 (PST) Message-Id: <200911201630.nAKGUpEI024572@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4434-done@emacsbugs.donarmstrong.com Subject: Re: bug#4434: add -Wdeclaration-after-statement to CFLAGS if supported References: <200909141916.n8EJGGJJ023826@godzilla.ics.uci.edu> <200911191655.nAJGtYko021413@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Thu, 19 Nov 2009 16:09:03 -0500") Lines: 7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAKGUpeB025878 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > Stefan, any reason not to check this in? > > Try it, Done. Thanks. ------------=_1258734909-27433-0--