From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4349: marked as done (23.1; bookmark-bmenu-rename call two times bookmark-bmenu-alist) Date: Fri, 09 Oct 2009 06:55:05 +0000 Message-ID: References: <873a5tawmo.fsf@red-bean.com> <87y6otzx2k.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1255071305-21707-0" X-Trace: ger.gmane.org 1255074730 23996 80.91.229.12 (9 Oct 2009 07:52:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Oct 2009 07:52:10 +0000 (UTC) To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 09 09:52:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MwAGa-00082W-Hn for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 09:51:59 +0200 Original-Received: from localhost ([127.0.0.1]:41017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MwAGa-0000Dj-0L for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 03:51:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mw9bx-0008CM-MW for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:09:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mw9bs-000879-AJ for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:09:57 -0400 Original-Received: from [199.232.76.173] (port=37577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mw9bs-00086z-1r for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:09:52 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:8599) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mw9br-0006Gy-Dh for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:09:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mw9bq-0000eG-Jd for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:09:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n99779gG024535; Fri, 9 Oct 2009 00:07:10 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n996t5bd021777; Thu, 8 Oct 2009 23:55:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4349 X-Emacs-PR-Package: emacs X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31807 Archived-At: This is a multi-part message in MIME format... ------------=_1255071305-21707-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 09 Oct 2009 02:50:55 -0400 with message-id <873a5tawmo.fsf@red-bean.com> and subject line Fix "bookmark-bmenu-rename call two times bookmark-bmenu-a= list" has caused the Emacs bug report #4349, regarding 23.1; bookmark-bmenu-rename call two times bookmark-bmenu-alist to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4349: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4349 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1255071305-21707-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 5 Sep 2009 07:16:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n857GEc6026987 for ; Sat, 5 Sep 2009 00:16:16 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjpVO-0003X4-9K for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:16:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjpVJ-0003T5-9P for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:16:13 -0400 Received: from [199.232.76.173] (port=36752 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjpVJ-0003Su-3k for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:16:09 -0400 Received: from mx20.gnu.org ([199.232.41.8]:32079) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MjpVI-0000Eu-Ij for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:16:08 -0400 Received: from mail-fx0-f226.google.com ([209.85.220.226]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjpVH-0004NW-DV for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:16:07 -0400 Received: by fxm26 with SMTP id 26so1157840fxm.42 for ; Sat, 05 Sep 2009 00:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:organization :face:date:message-id:user-agent:mime-version:content-type; bh=bftwSBb+i9afGV7aGcqK4oupLNFBcxqJxf9ckE7q0rw=; b=ImLxe/cqOsUiyr9kXCLwygEYEuBxZpHI5FJ3l76s4ciz3NmkoGQX4KwftjdXlgUkXH J6irSQsp8DR5L0Eo1OSu5E0YheEXHwNfCTeHJo4NSdwTsrOxqdsNDfN+O/G1zVzqozHi IyGTVt7Q30EPu1Rlj/8T2a1yuRQiq1T9I4u2k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:organization:face:date:message-id:user-agent :mime-version:content-type; b=kU4CLbwK+K5OJUtZZCsg/eatgXrkIOm1Aq9OwRJmy6OYKGyhEuwOtBxf8WkqjDNUR4 yjjjXgdXj3NN2Eb4zNLI4anj51ZSzSp4cI+SRk+UHhNzqSUr0NCj9HX0edkcmlrlHdSC ghZE7HE8K7YMjycHMOZIojMlvuHX45pxgLYsc= Received: by 10.86.18.34 with SMTP id 34mr5825563fgr.2.1252134966337; Sat, 05 Sep 2009 00:16:06 -0700 (PDT) Received: from tux.homenetwork (63.78.88-79.rev.gaoland.net [79.88.78.63]) by mx.google.com with ESMTPS id 4sm4199174fgg.1.2009.09.05.00.16.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 05 Sep 2009 00:16:05 -0700 (PDT) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 23.1; bookmark-bmenu-rename call two times bookmark-bmenu-alist Organization: ThierryVolpiatto Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHAwNfJRBVTESlTym0 RB/OwKFivhZqAAAACXBIWXMAAAsSAAALEgHS3X78AAAACXZwQWcAAAAwAAAAMADO7oxXAAABeElE QVQ4y3VTW47CMAyMwwUyTfYfUvG/wfC/ET4B0t7/KmsHurRgXFVVPRm/xglhsRj2+npW98G3+Amp tS5BXxl3SqzcXGRuEyf7n5lPA9jXetNPRhE7EJkzfz8YWnIgBSwW95TK4H79/t4GINKNADWj4PgA DiJX/ZxFDzDXeb4oYMw7kNUvyMzcaj3ioICG4hCKEShkPpwQ49Q05nnkGAQLDFDdExjm0qpowBYA Wi61bDlFU1GW0WbY2dSJYX5ZD2S0AiZL+rPyE19TpMzP2IvNWly+NkuWNgD4pO2oL73IQXoSyVX2 NHna7tgadWRXoCdvf2guqEcvGHqZwE520iRD0/QCYiiTE+U21w1Qxvg6iSp9fbIiDCnSAelDkCVF Vn+HekqXzRybwJ40xF4DMRG6SWGK9G1lYzHSxLYEm05GWbpJCB6A9tb9A3BGn2XdwJbS/WuInj74 4QNF8sVFdP3vl+5tgYp4Ev7fyrfFMkXgElDgV4uV/w8TWEeLCIGJ/AAAACV0RVh0Y3JlYXRlLWRh dGUAMjAwOC0wNS0zMVQyMjoxNDoyMiswMjowMM7uH/IAAAARdEVYdGpwZWc6Y29sb3JzcGFjZQAy LHVVnwAAACB0RVh0anBlZzpzYW1wbGluZy1mYWN0b3IAMngyLDF4MSwxeDFJ+qa0AAAAJXRFWHRt b2RpZnktZGF0ZQAyMDA3LTEwLTI4VDE3OjA4OjQ4KzAxOjAwhqNSRgAAAABJRU5ErkJggg== Date: Sat, 05 Sep 2009 09:10:11 +0200 Message-ID: <87y6otzx2k.fsf@tux.homenetwork> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Hi, bookmark-bmenu-rename call `bookmark-bmenu-list' after `bookmark-rename' that call itself `bookmark-bmenu-surreptitiously-rebuild-list'. That's non--sense. ,----[ bookmark-rename ] | (bookmark-set-name old newname) | (setq bookmark-current-bookmark newname) | (bookmark-bmenu-surreptitiously-rebuild-list) | (setq bookmark-alist-modification-count | (1+ bookmark-alist-modification-count)) | (if (bookmark-time-to-save-p) | (bookmark-save)))) `---- ,----[ bookmark-bmenu-rename ] | (bookmark-rename bmrk) | (bookmark-bmenu-list) | (goto-char thispoint)))) `---- The call to bookmark-bmenu-list should be removed: ,---- | (defun bookmark-bmenu-rename () | "Rename bookmark on current line. Prompts for a new name." | (interactive) | (if (bookmark-bmenu-check-position) | (let ((bmrk (bookmark-bmenu-bookmark)) | (thispoint (point))) | (bookmark-rename bmrk) | (goto-char thispoint)))) `---- If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-07-31 on tux Windowing system distributor `The X.Org Foundation', version 11.0.10503000 configured using `configure '--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=i686 -pipe -O2' 'LDFLAGS=-Wl,-O1'' Important settings: value of $LC_ALL: fr_FR.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: eldoc-mode: t icomplete-mode: t icicle-mode: t delete-selection-mode: t minibuffer-depth-indicate-mode: t auto-image-file-mode: t shell-dirtrack-mode: t partial-completion-mode: t show-paren-mode: t display-battery-mode: t display-time-mode: t diff-auto-refine-mode: t outline-minor-mode: t recentf-mode: t savehist-mode: t desktop-save-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: a C-g w i t h SPC b a t c h SPC a r g SPC I f SPC y o u SPC m a k e SPC t h i s SPC c h a n g e , SPC y o u SPC w i l l SPC p r o b a l b l y SPC w a n t SPC t o SPC r e m o v e SPC u n u s e d SPC s a v i n g SPC c o d e SPC i n SPC C-SPC C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f M-w C-M-` C-y . N O T E : C-c C-c C-x C-& M-x M-p C-g M-x M-p Recent messages: Mark set [2 times] Auto-saving...done Auto-saving...done Sending... Sending via mail... Opening STARTTLS connection to `smtp.gmail.com:587'...done Opening nnml server...done Wrote /home/thierry/Mail/sent-mail/848 Sending...done Opendns have been Updated -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France ------------=_1255071305-21707-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4349-close) by emacsbugs.donarmstrong.com; 9 Oct 2009 06:50:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n996otex021576 for <4349-close@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 23:50:57 -0700 Received: from localhost ([127.0.0.1]:44677 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1Mw9JX-0002ub-HL for 4349-close@emacsbugs.donarmstrong.com; Fri, 09 Oct 2009 01:50:55 -0500 From: Karl Fogel To: 4349-close@emacsbugs.donarmstrong.com Subject: Fix "bookmark-bmenu-rename call two times bookmark-bmenu-alist" Reply-To: Karl Fogel Date: Fri, 09 Oct 2009 02:50:55 -0400 Message-ID: <873a5tawmo.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. Fix committed: $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.134; previous revision: 1.133 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16395; previous revision: 1.16394 Mailing notification to emacs-diffs@gnu.org... sent. $ ------------=_1255071305-21707-0--