From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4348: marked as done (23.1; bookmark-delete don't increment save counter when using batch arg.) Date: Fri, 09 Oct 2009 06:50:05 +0000 Message-ID: References: <8763apawvk.fsf@red-bean.com> <871vml27xb.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1255071005-20974-0" X-Trace: ger.gmane.org 1255074569 23554 80.91.229.12 (9 Oct 2009 07:49:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Oct 2009 07:49:29 +0000 (UTC) To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 09 09:49:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MwAE1-0006yo-TA for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 09:49:19 +0200 Original-Received: from localhost ([127.0.0.1]:39879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MwAE1-0005Pl-AW for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 03:49:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mw9ZO-0004di-3W for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:07:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mw9ZJ-0004Vq-Ao for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:07:17 -0400 Original-Received: from [199.232.76.173] (port=36479 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mw9ZJ-0004VJ-2t for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:07:13 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:8359) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mw9ZI-0005P4-CZ for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:07:12 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mw9ZH-0000MW-8F for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 03:07:11 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n99779gE024535; Fri, 9 Oct 2009 00:07:09 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n996o508021045; Thu, 8 Oct 2009 23:50:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4348 X-Emacs-PR-Package: emacs X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31806 Archived-At: This is a multi-part message in MIME format... ------------=_1255071005-20974-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 09 Oct 2009 02:45:35 -0400 with message-id <8763apawvk.fsf@red-bean.com> and subject line Fix "bookmark-delete don't increment save counter when usi= ng batch arg." has caused the Emacs bug report #4348, regarding 23.1; bookmark-delete don't increment save counter when using bat= ch arg. to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4348: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4348 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1255071005-20974-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 5 Sep 2009 07:05:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8575l78025124 for ; Sat, 5 Sep 2009 00:05:48 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjpLH-0006vw-0L for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:05:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjpLF-0006uc-6g for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:05:45 -0400 Received: from [199.232.76.173] (port=52159 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjpLF-0006uZ-2w for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:05:45 -0400 Received: from mx20.gnu.org ([199.232.41.8]:31328) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MjpLE-00076W-8R for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:05:44 -0400 Received: from fg-out-1718.google.com ([72.14.220.157]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjpLC-0003iQ-MJ for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2009 03:05:42 -0400 Received: by fg-out-1718.google.com with SMTP id e21so270037fga.12 for ; Sat, 05 Sep 2009 00:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:organization :date:message-id:user-agent:mime-version:content-type; bh=lESYUQBiMgEPvED+wemgdmsxgNhvCr8ZeGQHaeGposM=; b=vBYaDxElc3JojTif+Ig+MXiHLvmFgl8P/HqffBgLRnZDG+U3mBZaTiJvTkjcJ/E/bd CBkywMf9XiPkyLpo9DXmW/v6OacAXpkbtXUtjLmIrH65Ap/rMvOfjNz8iogTAn9D04Oz QziUdrv4MxwE550V+16bJrqbM0rp5CKhm2HfU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:organization:date:message-id:user-agent :mime-version:content-type; b=TLR4q0UOLhxZ+KAQweF9ZCIobeH0LdmxJOt0WG4M28+iuUmk+gDiv0AhnzfLtgfTEk fkQ4DUpgPcxlkWLfTUsOLuDhduhtKrqJ940Dz2eG1yjyQg1o3b/KqwIXtcegdWLRKdv/ snnAsvYCJFn8XnW3zwHlEtE7sxJwLKsOumcss= Received: by 10.86.187.7 with SMTP id k7mr5815405fgf.30.1252134340429; Sat, 05 Sep 2009 00:05:40 -0700 (PDT) Received: from tux.homenetwork (63.78.88-79.rev.gaoland.net [79.88.78.63]) by mx.google.com with ESMTPS id 4sm4174989fgg.21.2009.09.05.00.05.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 05 Sep 2009 00:05:39 -0700 (PDT) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 23.1; bookmark-delete don't increment save counter when using batch arg. Organization: ThierryVolpiatto Date: Sat, 05 Sep 2009 08:59:44 +0200 Message-ID: <871vml27xb.fsf@tux.homenetwork> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Hi, as the title say, bookmark-delete don't increment `bookmark-alist-modification-count' when using batch arg. ,---- | (if batch | nil | (bookmark-bmenu-surreptitiously-rebuild-list) | (setq bookmark-alist-modification-count | (1+ bookmark-alist-modification-count)) | (if (bookmark-time-to-save-p) | (bookmark-save)))) `---- As you can see, saving code is called only in else section. Here the redefinition i made in bookmark+.el that fix the problem: ,---- | (unless batch | (bookmark-bmenu-surreptitiously-rebuild-list)) | (setq bookmark-alist-modification-count | (1+ bookmark-alist-modification-count)) | (when (bookmark-time-to-save-p) | (bookmark-save))) `---- This bug don't appear when you delete from bmenu-list because in this case bookmark-delete is called whithout batch arg. But that is annoying for external programs that call bookmark-delete with batch arg (e.g anything, icicles). NOTE: If you make this change, you will probably want to remove unused saving code in `bookmark-bmenu-execute-deletions'. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-07-31 on tux Windowing system distributor `The X.Org Foundation', version 11.0.10503000 configured using `configure '--prefix=/usr' '--build=i686-pc-linux-gnu' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=i686 -pipe -O2' 'LDFLAGS=-Wl,-O1'' Important settings: value of $LC_ALL: fr_FR.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: eldoc-mode: t icomplete-mode: t icicle-mode: t delete-selection-mode: t minibuffer-depth-indicate-mode: t auto-image-file-mode: t shell-dirtrack-mode: t partial-completion-mode: t show-paren-mode: t display-battery-mode: t display-time-mode: t diff-auto-refine-mode: t outline-minor-mode: t recentf-mode: t savehist-mode: t desktop-save-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-c SPC a C-c C-g d e l e t e C-SPC C-n C-n C-n C-n C-n C-n M-w C-u C-c C-g C-g M-x s u b m i t C-g a p b u g g e m m a a c c s s SPC b b u u g g e t d e f a a l i a s SPC s e n d - b u g - e m a c s e m a c s - b u g SPC C-x b r e p o r t - e m a c s - b u g e t C-! s e n d - e e t e t M-x r e p o r t - e m a Recent messages: Loading em-prompt...done Loading em-script...done Loading em-unix...done Saving file /home/thierry/.emacs.d/.eshell/alias... Wrote /home/thierry/.emacs.d/.eshell/alias usage: report-emacs-bug: (TOPIC &optional RECENT-KEYS) History item: 128 Saving file /home/thierry/.emacs.d/.eshell/alias... Wrote /home/thierry/.emacs.d/.eshell/alias Computing completion candidates... -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France ------------=_1255071005-20974-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4348-close) by emacsbugs.donarmstrong.com; 9 Oct 2009 06:45:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n996jZvu020791 for <4348-close@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 23:45:37 -0700 Received: from localhost ([127.0.0.1]:34504 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1Mw9EN-00052H-Io for 4348-close@emacsbugs.donarmstrong.com; Fri, 09 Oct 2009 01:45:35 -0500 From: Karl Fogel To: 4348-close@emacsbugs.donarmstrong.com Subject: Fix "bookmark-delete don't increment save counter when using batch arg." Reply-To: Karl Fogel Date: Fri, 09 Oct 2009 02:45:35 -0400 Message-ID: <8763apawvk.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. Fix committed: $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.133; previous revision: 1.132 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16394; previous revision: 1.16393 Mailing notification to emacs-diffs@gnu.org... sent. @/home/kfogel/src/emacs/emacs-cvs> $ ------------=_1255071005-20974-0--