* bug#4308: 23.1.50; patch: fix `eshell-history-file-name' @ 2009-09-01 19:32 ` Leo 2009-09-01 19:49 ` Leo 2009-09-13 2:25 ` bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') Emacs bug Tracking System 0 siblings, 2 replies; 3+ messages in thread From: Leo @ 2009-09-01 19:32 UTC (permalink / raw) To: emacs-pretest-bug Please describe exactly what actions triggered the bug and the precise symptoms of the bug: The attached small patch makes eshell-history-file-name more robust. For example, I accidentally set eshell-directory-name to ~/.emacs.d/shell without a trailing / and the history was written to ~/.emacs.d/shellhistory. diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz --- a/em-hist.el.gz +++ b/em-hist.el.gz @@ -86,7 +86,7 @@ :group 'eshell-hist) (defcustom eshell-history-file-name - (concat eshell-directory-name "history") + (expand-file-name "history" eshell-directory-name) "*If non-nil, name of the file to read/write input history. See also `eshell-read-history' and `eshell-write-history'. If it is nil, Eshell will use the value of HISTFILE." Diff finished. Tue Sep 1 20:27:29 2009 Leo ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4308: 23.1.50; patch: fix `eshell-history-file-name' 2009-09-01 19:32 ` bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Leo @ 2009-09-01 19:49 ` Leo 2009-09-13 2:25 ` bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Leo @ 2009-09-01 19:49 UTC (permalink / raw) To: 4308 On 2009-09-01 20:32 +0100, Leo wrote: > The attached small patch makes eshell-history-file-name more robust. For > example, I accidentally set eshell-directory-name to ~/.emacs.d/shell > without a trailing / and the history was written to > ~/.emacs.d/shellhistory. Please also fix the following places: em-alias.el.gz:105:(defcustom eshell-aliases-file (concat eshell-directory-name "alias") em-dirs.el.gz:141: (concat eshell-directory-name "lastdir") em-script.el.gz:43:(defcustom eshell-login-script (concat eshell-directory-name "login") em-script.el.gz:50:(defcustom eshell-rc-script (concat eshell-directory-name "profile") Thank you. -- Leo's Emacs uptime: 10 days, 1 hour, 21 minutes, 12 seconds ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') 2009-09-01 19:32 ` bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Leo 2009-09-01 19:49 ` Leo @ 2009-09-13 2:25 ` Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Emacs bug Tracking System @ 2009-09-13 2:25 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 886 bytes --] Your message dated Sat, 12 Sep 2009 22:17:51 -0400 with message-id <87pr9vbnao.fsf@cyd.mit.edu> and subject line Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' has caused the Emacs bug report #4308, regarding 23.1.50; patch: fix `eshell-history-file-name' to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 4308: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4308 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 3032 bytes --] From: Leo <sdl.web@gmail.com> To: emacs-pretest-bug@gnu.org Subject: 23.1.50; patch: fix `eshell-history-file-name' Date: Tue, 01 Sep 2009 20:32:10 +0100 Message-ID: <m0ws4iihqd.fsf@cam.ac.uk> Please describe exactly what actions triggered the bug and the precise symptoms of the bug: The attached small patch makes eshell-history-file-name more robust. For example, I accidentally set eshell-directory-name to ~/.emacs.d/shell without a trailing / and the history was written to ~/.emacs.d/shellhistory. diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz --- a/em-hist.el.gz +++ b/em-hist.el.gz @@ -86,7 +86,7 @@ :group 'eshell-hist) (defcustom eshell-history-file-name - (concat eshell-directory-name "history") + (expand-file-name "history" eshell-directory-name) "*If non-nil, name of the file to read/write input history. See also `eshell-read-history' and `eshell-write-history'. If it is nil, Eshell will use the value of HISTFILE." Diff finished. Tue Sep 1 20:27:29 2009 Leo [-- Attachment #3: Type: message/rfc822, Size: 1387 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: Leo <sdl.web@gmail.com> Cc: 4308-done@emacsbugs.donarmstrong.com Subject: Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Date: Sat, 12 Sep 2009 22:17:51 -0400 Message-ID: <87pr9vbnao.fsf@cyd.mit.edu> > > The attached small patch makes eshell-history-file-name more > > robust. For > > example, I accidentally set eshell-directory-name to ~/.emacs.d/shell > > without a trailing / and the history was written to > > ~/.emacs.d/shellhistory. > Please also fix the following places: All fixed, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-13 2:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <87pr9vbnao.fsf@cyd.mit.edu> 2009-09-01 19:32 ` bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Leo 2009-09-01 19:49 ` Leo 2009-09-13 2:25 ` bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).