bug#4261: marked as done (make gcc warn about c99 declarations)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Your message dated Fri, 20 Nov 2009 08:30:51 -0800 (PST)
with message-id <200911201630.nAKGUpEI024572@godzilla.ics.uci.edu>
and subject line Re: bug#4434: add -Wdeclaration-after-statement to CFLAGS if supported
has caused the Emacs bug report #4434,
regarding make gcc warn about c99 declarations
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4434: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4434
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3703 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs@gnu.org>
Subject: make gcc warn about c99 declarations
Date: Tue, 25 Aug 2009 16:16:39 -0700 (PDT)
Message-ID: <200908252316.n7PNGdd6014912@godzilla.ics.uci.edu>

There were several patch proposals recently that had c99 style
declarations in the middle of a block.
There's a gcc flag that warns about that.

The configure.in patch below enables the flag if gcc supports it,
following the model for -Wno-pointer-sign

Please apply if appropriate.



Index: configure.in
===================================================================
RCS file: /cvsroot/emacs/emacs/configure.in,v
retrieving revision 1.607
diff -u -3 -p -u -p -r1.607 configure.in
--- configure.in 23 Aug 2009 02:15:00 -0000     1.607
+++ configure.in 25 Aug 2009 23:11:58 -0000
@@ -757,6 +757,19 @@ CFLAGS="$SAVE_CFLAGS"
 unset has_option
 unset SAVE_CFLAGS
 
+### Use -Wdeclaration-after-statement if the compiler supports it
+AC_MSG_CHECKING([whether gcc understands -Wdeclaration-after-statement])
+SAVE_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -Wdeclaration-after-statement"
+AC_TRY_COMPILE([], [], has_option=yes, has_option=no,)
+if test $has_option = yes; then
+   C_WARNINGS_SWITCH="-Wdeclaration-after-statement $C_WARNINGS_SWITCH"
+fi
+AC_MSG_RESULT($has_option)
+CFLAGS="$SAVE_CFLAGS"
+unset has_option
+unset SAVE_CFLAGS
+
 #### Some other nice autoconf tests.
 
 dnl checks for programs



[-- Attachment #3: Type: message/rfc822, Size: 2259 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 4434-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4434: add -Wdeclaration-after-statement to CFLAGS if supported
Date: Fri, 20 Nov 2009 08:30:51 -0800 (PST)
Message-ID: <200911201630.nAKGUpEI024572@godzilla.ics.uci.edu>

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

  > > Stefan, any reason not to check this in?
  > 
  > Try it,

Done. Thanks.