From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#423: marked as done (flymake faces hard to read on dark backgrounds) Date: Wed, 23 Jul 2008 15:05:05 -0700 Message-ID: References: <87abg8463b.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1216850705-28754-0" X-Trace: ger.gmane.org 1216850859 27355 80.91.229.12 (23 Jul 2008 22:07:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2008 22:07:39 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 24 00:08:27 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KLmVR-0004s1-K3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jul 2008 00:08:22 +0200 Original-Received: from localhost ([127.0.0.1]:49278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLmUY-0004tA-56 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2008 18:07:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLmUU-0004sc-CE for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2008 18:07:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLmUT-0004s8-HM for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2008 18:07:21 -0400 Original-Received: from [199.232.76.173] (port=60656 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLmUT-0004s2-B6 for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2008 18:07:21 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41293) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLmUS-00011b-KZ for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2008 18:07:21 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6NM7JUa030302; Wed, 23 Jul 2008 15:07:19 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m6NM55JW029269; Wed, 23 Jul 2008 15:05:05 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 423 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18802 Archived-At: This is a multi-part message in MIME format... ------------=_1216850705-28754-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 23 Jul 2008 17:56:56 -0400 with message-id <87abg8463b.fsf@stupidchicken.com> and subject line Re: flymake faces hard to read on dark backgrounds has caused the Emacs bug report #423, regarding flymake faces hard to read on dark backgrounds to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 423: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D423 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1216850705-28754-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Jun 2008 21:00:28 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5FL0KUA019397 for ; Sun, 15 Jun 2008 14:00:21 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7zKl-0003WG-Vn for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7zKk-0003Vd-Fk for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:19 -0400 Received: from [199.232.76.173] (port=45996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7zKk-0003VX-8A for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:18 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:43663) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K7zKj-0005qa-Qf for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:18 -0400 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id B851BE42A2E3 for ; Sun, 15 Jun 2008 23:00:16 +0200 (CEST) Received: from [77.189.15.115] (helo=thursday) by smtp05.web.de with asmtp (WEB.DE 4.109 #226) id 1K7zKi-0004hQ-00 for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 23:00:16 +0200 To: bug-gnu-emacs@gnu.org Subject: flymake faces hard to read on dark backgrounds From: Nikolaj Schumacher User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2.50 (darwin) Date: Sun, 15 Jun 2008 23:00:15 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: n_schumacher@web.de X-Sender: n_schumacher@web.de X-Provags-ID: V01U2FsdGVkX1/zwNC3Dk/eHpE0w9XFy83XMKia4D5orbph8ZUZ t9Rc+caR9vmmC6bV8AULvIDQp4OyCxAzgMX2qWyDDarR5YbRkR s6kP1oVK2mICDR/CUWUA== X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 --=-=-= Hello, flymake-errline and flymake-warnline faces are very hard to read on dark backgrounds. regards, Nikolaj Schumacher --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=emacs-flymake-face-colors.patch Content-Description: patch diff -du /Users/nik/emacs/var/backup/\!Applications\!Emacs.app\!Contents\!Resources\!share\!emacs\!22.2.50\!lisp\!progmodes\!flymake.el.\~1\~ /Applications/Emacs.app/Contents/Resources/share/emacs/22.2.50/lisp/progmodes/flymake.el --- lisp/progmodes/flymake.el 2008-06-12 23:22:42.000000000 +0200 +++ lisp/progmodes/flymake.el 2008-06-15 22:28:02.000000000 +0200 @@ -799,15 +799,15 @@ has-flymake-overlays)) (defface flymake-errline - ;;+ '((((class color)) (:foreground "OrangeRed" :bold t :underline t)) - ;;+ '((((class color)) (:underline "OrangeRed")) - '((((class color)) (:background "LightPink")) + '((((background dark)) (:background "Firebrick4")) + (((background light)) (:background "LightPink")) (t (:bold t))) "Face used for marking error lines." :group 'flymake) (defface flymake-warnline - '((((class color)) (:background "LightBlue2")) + '((((background dark)) (:background "DarkBlue")) + (((background light)) (:background "LightBlue2")) (t (:bold t))) "Face used for marking warning lines." :group 'flymake) Diff finished. Sun Jun 15 22:28:11 2008 --=-=-=-- ------------=_1216850705-28754-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 423-done) by emacsbugs.donarmstrong.com; 23 Jul 2008 21:55:39 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6NLtYxB027222 for <423-done@emacsbugs.donarmstrong.com>; Wed, 23 Jul 2008 14:55:35 -0700 Received: by cyd (Postfix, from userid 1000) id F1F0657E32C; Wed, 23 Jul 2008 17:56:57 -0400 (EDT) From: Chong Yidong To: Nikolaj Schumacher Cc: 423-done@emacsbugs.donarmstrong.com Subject: Re: flymake faces hard to read on dark backgrounds Date: Wed, 23 Jul 2008 17:56:56 -0400 Message-ID: <87abg8463b.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > flymake-errline and flymake-warnline faces are very hard to read on > dark backgrounds. Your patch looks reasonable. I've checked it in. Thanks. ------------=_1216850705-28754-0--