From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4229: marked as done (23.1; wrong-type arg: char or string-p, nil) Date: Mon, 05 Oct 2009 04:35:05 +0000 Message-ID: References: <87d452mpo2.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1254717305-3055-2" X-Trace: ger.gmane.org 1254718047 32481 80.91.229.12 (5 Oct 2009 04:47:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2009 04:47:27 +0000 (UTC) To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 05 06:47:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MufTk-0001GU-V2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Oct 2009 06:47:21 +0200 Original-Received: from localhost ([127.0.0.1]:35617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MufTl-00050v-0j for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Oct 2009 00:47:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MufTg-00050c-48 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 00:47:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MufTb-000507-Cz for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 00:47:15 -0400 Original-Received: from [199.232.76.173] (port=38317 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MufTb-000502-AR for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 00:47:11 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34955) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MufTa-0007Kb-LJ for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 00:47:11 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n954l8UR005081; Sun, 4 Oct 2009 21:47:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n954Z6nc003183; Sun, 4 Oct 2009 21:35:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4229 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31690 Archived-At: This is a multi-part message in MIME format... ------------=_1254717305-3055-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 05 Oct 2009 00:26:53 -0400 with message-id <87d452mpo2.fsf@red-bean.com> and subject line Fix "bookmark.el should raise reasonable error for empty f= ilename entry" has caused the Emacs bug report #4250, regarding 23.1; wrong-type arg: char or string-p, nil to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4250: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4250 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1254717305-3055-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Aug 2009 22:38:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7LMcYlJ008223 for ; Fri, 21 Aug 2009 15:38:35 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Meckk-0005I0-Bs for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:38:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Meckf-0005H8-PH for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:38:34 -0400 Received: from [199.232.76.173] (port=35474 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Meckf-0005H5-LJ for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:38:29 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:40846 helo=rgminet11.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mecke-0006lC-Lf for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:38:29 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7LMchqe003520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Aug 2009 22:38:44 GMT Received: from abhmt005.oracle.com (abhmt005.oracle.com [141.146.116.14]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7LMcNCG014104 for ; Fri, 21 Aug 2009 22:38:24 GMT Received: from dradamslap1 (/141.144.245.31) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Aug 2009 15:38:22 -0700 From: "Drew Adams" To: Subject: 23.1; wrong-type arg: char or string-p, nil Date: Fri, 21 Aug 2009 15:38:22 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcoisBazS76IuBXgQAK3vFzKVhyaLA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt005.oracle.com [141.146.116.14] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4A8F21E0.0064:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q M-x set-variable debug-on-error t M-x load-file /......./bookmark.el C-x r l raises error: Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil) insert(nil) (prog1 (insert (bookmark-location bookmark)) (if (and ... ...) (add-text-properties start ... ...))) (let ((start ...)) (prog1 (insert ...) (if ... ...))) bookmark-insert-location("*Messages* buffer list" t) (let ((bmrk ...)) (setq bookmark-bmenu-hidden-bookmarks (cons bmrk bookmark-bmenu-hidden-bookmarks)) (let (...) (move-to-column bookmark-bmenu-file-column t) (if ... ...)) (delete-region (point) (progn ... ...)) (insert " ") (bookmark-insert-location bmrk t) (forward-line 1)) (while (< (point) (point-max)) (let (...) (setq bookmark-bmenu-hidden-bookmarks ...) (let ... ... ...) (delete-region ... ...) (insert " ") (bookmark-insert-location bmrk t) (forward-line 1))) (let ((inhibit-read-only t)) (while (< ... ...) (let ... ... ... ... ... ... ...))) (save-window-excursion (goto-char (point-min)) (forward-line 2) (setq bookmark-bmenu-hidden-bookmarks nil) (let (...) (while ... ...))) (save-excursion (save-window-excursion (goto-char ...) (forward-line 2) (setq bookmark-bmenu-hidden-bookmarks nil) (let ... ...))) (if (and (not force) bookmark-bmenu-toggle-filenames) nil (save-excursion (save-window-excursion ... ... ... ...))) bookmark-bmenu-show-filenames() (cond (show (setq bookmark-bmenu-toggle-filenames nil) (bookmark-bmenu-show-filenames) (setq bookmark-bmenu-toggle-filenames t)) (bookmark-bmenu-toggle-filenames (bookmark-bmenu-hide-filenames) (setq bookmark-bmenu-toggle-filenames nil)) (t (bookmark-bmenu-show-filenames) (setq bookmark-bmenu-toggle-filenames t))) bookmark-bmenu-toggle-filenames(t) (if bookmark-bmenu-toggle-filenames (bookmark-bmenu-toggle-filenames t)) bookmark-bmenu-list() call-interactively(bookmark-bmenu-list nil nil) In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1254717305-3055-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4250-close) by emacsbugs.donarmstrong.com; 5 Oct 2009 04:26:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n954QrK3002225 for <4250-close@emacsbugs.donarmstrong.com>; Sun, 4 Oct 2009 21:26:54 -0700 Received: from localhost ([127.0.0.1]:52856 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1Muf9x-0001DT-Dk for 4250-close@emacsbugs.donarmstrong.com; Sun, 04 Oct 2009 23:26:53 -0500 From: Karl Fogel To: 4250-close@emacsbugs.donarmstrong.com Subject: Fix "bookmark.el should raise reasonable error for empty filename entry" Reply-To: Karl Fogel Date: Mon, 05 Oct 2009 00:26:53 -0400 Message-ID: <87d452mpo2.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- I think this is fixed now, though I'm not positive it was broken in the first place. I've made `bookmark-default-handler' raise a catchable error on entries that have no filename. But in general, if you're defining your own types of bookmarks, you should be defining custom handlers for them. So when you say "I have code that allows for bookmarks that have no filename", I'm curious to see that code. It's impossible, in the general case, for bookmark.el to tolerate all entries it does not recognize -- a sufficiently bizarre entry might not even have discernable boundaries, for example. We must depend on custom handlers to handle custom data. Anyway, here's the commit: $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.131; previous revision: 1.130 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16357; previous revision: 1.16356 Mailing notification to emacs-diffs@gnu.org... sent. $ And this is the log message, so you can get an idea of what I did: (bookmark-handle-bookmark): If bookmark has no file, don't do anything related to relocating, just return nil. (bookmark-error-no-filename): New error. (bookmark-default-handler): Signal `bookmark-error-no-filename' if bookmark has no file. Don't even attempt to handle things that are not files; the whole point of custom handlers is to keep that knowledge elsewhere anyway. Tighten some comments. (bookmark-file-or-variation-thereof): Remove now-unused function. (bookmark-location): Doc string fix. ------------=_1254717305-3055-2--