From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4188: marked as done (23.1; doc strings in bookmark.el) Date: Mon, 05 Oct 2009 01:45:08 +0000 Message-ID: References: <87y6nqmxk0.fsf@red-bean.com> <93AC19018012425A8D3A6E2163301F3A@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1254707108-8745-0" X-Trace: ger.gmane.org 1254707263 13223 80.91.229.12 (5 Oct 2009 01:47:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2009 01:47:43 +0000 (UTC) To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 05 03:47:38 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mucfl-00022x-6D for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Oct 2009 03:47:33 +0200 Original-Received: from localhost ([127.0.0.1]:33198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mucfl-00035k-9T for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Oct 2009 21:47:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MucfU-0002uX-OY for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 21:47:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MucfQ-0002u6-5A for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 21:47:16 -0400 Original-Received: from [199.232.76.173] (port=56303 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MucfP-0002tq-Jb for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 21:47:11 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37939) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MucfO-0006Ga-SW for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 21:47:11 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n951l8wR009357; Sun, 4 Oct 2009 18:47:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n951j8ri008857; Sun, 4 Oct 2009 18:45:08 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4188 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31682 Archived-At: This is a multi-part message in MIME format... ------------=_1254707108-8745-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sun, 04 Oct 2009 21:36:31 -0400 with message-id <87y6nqmxk0.fsf@red-bean.com> and subject line Fixed "doc strings in bookmark.el" has caused the Emacs bug report #4188, regarding 23.1; doc strings in bookmark.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4188: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4188 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1254707108-8745-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 19 Aug 2009 22:23:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7JMNqHm003529 for ; Wed, 19 Aug 2009 15:23:53 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdtZP-0005sB-SX for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 18:23:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdtZL-0005qE-4n for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 18:23:51 -0400 Received: from [199.232.76.173] (port=42254 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdtZK-0005q5-S1 for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 18:23:46 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:56394 helo=rgminet11.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdtZK-0007De-HJ for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2009 18:23:46 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7JMNwDb011028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Aug 2009 22:23:59 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7JMOQZj016587 for ; Wed, 19 Aug 2009 22:24:26 GMT Received: from dradamslap1 (/141.144.160.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Aug 2009 15:23:40 -0700 From: "Drew Adams" To: Subject: 23.1; doc strings in bookmark.el Date: Wed, 19 Aug 2009 15:23:50 -0700 Message-ID: <93AC19018012425A8D3A6E2163301F3A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcohG7njvcs8ZKqjRUCAPo/2AOYL9Q== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A8C7B6D.0136:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) 1. The function doc strings need to describe the arguments. For example, these functions (at least) should say, "BOOKMARK is a bookmark name or a bookmark record." bookmark-get-bookmark, bookmark-get-bookmark-record, bookmark-prop-get, bookmark-prop-set, bookmark-get-handler, bookmark--jump-via, bookmark-jump-noselect. This is particularly important because some functions expect that their bookmark argument be a bookmark name, others expect that it be a bookmark record, and still others allow either. 2. Some functions (e.g. bookmark--jump-via) are missing doc strings altogether. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1254707108-8745-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4188-close) by emacsbugs.donarmstrong.com; 5 Oct 2009 01:36:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n951aWNI007803 for <4188-close@emacsbugs.donarmstrong.com>; Sun, 4 Oct 2009 18:36:33 -0700 Received: from localhost ([127.0.0.1]:36736 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1MucV6-0002Py-2a for 4188-close@emacsbugs.donarmstrong.com; Sun, 04 Oct 2009 20:36:32 -0500 From: Karl Fogel To: 4188-close@emacsbugs.donarmstrong.com Subject: Fixed "doc strings in bookmark.el" Reply-To: Karl Fogel Date: Sun, 04 Oct 2009 21:36:31 -0400 Message-ID: <87y6nqmxk0.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. Fix committed: $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.128; previous revision: 1.127 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16354; previous revision: 1.16353 Mailing notification to emacs-diffs@gnu.org... sent. $ ------------=_1254707108-8745-0--