From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4037: marked as done (Characters garbled in self-insert-command) Date: Fri, 28 Aug 2009 08:55:10 +0000 Message-ID: References: <83fxbccoca.fsf@gnu.org> <87ws5jh0ql.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1251449710-12535-0" X-Trace: ger.gmane.org 1251450463 14330 80.91.229.12 (28 Aug 2009 09:07:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Aug 2009 09:07:43 +0000 (UTC) To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 28 11:07:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MgxQj-0002Lt-NC for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Aug 2009 11:07:35 +0200 Original-Received: from localhost ([127.0.0.1]:47131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgxQj-0004ZX-00 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Aug 2009 05:07:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgxQL-0004M4-Vm for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2009 05:07:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgxQG-0004K7-FI for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2009 05:07:08 -0400 Original-Received: from [199.232.76.173] (port=43640 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgxQF-0004JM-Fa for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2009 05:07:03 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51877) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MgxQ9-0004Wj-RV; Fri, 28 Aug 2009 05:06:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7S96riB015098; Fri, 28 Aug 2009 02:06:55 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7S8tBbq012585; Fri, 28 Aug 2009 01:55:11 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4037 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30625 Archived-At: This is a multi-part message in MIME format... ------------=_1251449710-12535-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 28 Aug 2009 11:52:21 +0300 with message-id <83fxbccoca.fsf@gnu.org> and subject line Re: bug#4240: 23.1.50; C-u doesn't work with Swedish chara= cters has caused the Emacs bug report #4037, regarding Characters garbled in self-insert-command to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4037: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4037 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1251449710-12535-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 4 Aug 2009 19:28:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n74JSReB010080 for ; Tue, 4 Aug 2009 12:28:29 -0700 Received: from mx10.gnu.org ([199.232.76.166]:35335) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MYPgR-0005gX-8S for emacs-pretest-bug@gnu.org; Tue, 04 Aug 2009 15:28:27 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MYPgO-0004DW-PG for emacs-pretest-bug@gnu.org; Tue, 04 Aug 2009 15:28:26 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4]:45960 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MYPgO-0004Co-BL for emacs-pretest-bug@gnu.org; Tue, 04 Aug 2009 15:28:24 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.70.102.cable.starman.ee [82.131.70.102]) by mx2.starman.ee (Postfix) with ESMTP id 77F703F406F for ; Tue, 4 Aug 2009 22:28:16 +0300 (EEST) From: Juri Linkov To: emacs-pretest-bug@gnu.org Subject: Characters garbled in self-insert-command Organization: JURTA Date: Tue, 04 Aug 2009 22:27:42 +0300 Message-ID: <87ws5jh0ql.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) I just noticed a regression against Emacs 22. In GNU Emacs 23.1.50 (x86_64-pc-linux-gnu) typing C-u 5 C-x 8 ' a inserts into the current buffer =A8=A2\341\341\341=A8=A2 whereas in GNU Emacs 22.1.1 typing the same correctly inserts =A8=A2=A8=A2=A8=A2=A8=A2=A8=A2 The command `self-insert-command' in Emacs 23 inserts the first and the last characters without any modifications, but applies the following conversion for the remaining characters: /* Add the offset to the character, for Finsert_char. We pass internal_self_insert the unmodified character because it itself does this offsetting. */ if (! NILP (current_buffer->enable_multibyte_characters)) modified_char =3D unibyte_char_to_multibyte (modified_char); Commenting out the above 2 lines produces the correct result. However, I'm not sure what is the right fix. --=20 Juri Linkov http://www.jurta.org/emacs/ ------------=_1251449710-12535-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4037-done) by emacsbugs.donarmstrong.com; 28 Aug 2009 08:52:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FVGT_m_MULTI_ODD,GMAIL, HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout7.012.net.il (mtaout7.012.net.il [84.95.2.19]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7S8qNM3012023; Fri, 28 Aug 2009 01:52:25 -0700 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KP200H00WK3N100@i-mtaout7.012.net.il>; Fri, 28 Aug 2009 11:52:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.144.38]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KP200C83WN4FT20@i-mtaout7.012.net.il>; Fri, 28 Aug 2009 11:52:17 +0300 (IDT) Date: Fri, 28 Aug 2009 11:52:21 +0300 From: Eli Zaretskii Subject: Re: bug#4240: 23.1.50; C-u doesn't work with Swedish characters In-reply-to: X-012-Sender: halo1@inter.net.il To: Kenichi Handa Cc: monnier@iro.umontreal.ca, 4240-done@emacsbugs.donarmstrong.com, deniz.a.m.dogan@gmail.com, 4037-done@emacsbugs.donarmstrong.com Reply-to: Eli Zaretskii Message-id: <83fxbccoca.fsf@gnu.org> References: <7b501d5c0908230628r5bc2cad2he3fc7a2249fcac5@mail.gmail.com> <87ljlas6nn.fsf@mail.jurta.org> <833a7ifen3.fsf@gnu.org> <83y6p6cxk7.fsf@gnu.org> > From: Kenichi Handa > Cc: eliz@gnu.org, 4240@emacsbugs.donarmstrong.com, deniz.a.m.dogan@gmail.com > Date: Thu, 27 Aug 2009 15:23:25 +0900 > > In article , Stefan Monnier writes: > > >>> > Please see bug#4037: > >>> > http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4037 > >>> > I received no confirmation that my proposed fix is correct. > >>> I think those two lines are not necessary anymore and should be > >>> removed (together with the comments which explain their need). I > >>> think they belong to the old pre-unicode days when raw eight-bit > >>> characters needed such special treatment. > > > I believe you're right. Nowadays, the keyboard-decoding should always > > take place before we get to that point. > > Sorry for the late responce on this matter. Yes, that > unibyte->multibyte conversion is not necessary. I've just > installed a fix. Thanks. I'm closing the two related bug reports. ------------=_1251449710-12535-0--