From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3677: marked as done (23.0.95; facemenu-read-color should not require match) Date: Sun, 16 Aug 2009 05:35:05 +0000 Message-ID: References: <874os8ba60.fsf@cyd.mit.edu> <20090625102438.2173776366.qww314159@motoko.argon.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1250400905-5425-0" X-Trace: ger.gmane.org 1250401657 28467 80.91.229.12 (16 Aug 2009 05:47:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Aug 2009 05:47:37 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 16 07:47:29 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1McYaT-0006xP-5g for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Aug 2009 07:47:26 +0200 Original-Received: from localhost ([127.0.0.1]:40172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McYaS-0003jT-Ix for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Aug 2009 01:47:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1McYa2-0003da-Ux for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 01:46:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1McYZx-0003cO-Ii for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 01:46:58 -0400 Original-Received: from [199.232.76.173] (port=33509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McYZx-0003cJ-4w for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 01:46:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42923) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1McYZw-0000Sc-F3 for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 01:46:52 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7G5kntj007374; Sat, 15 Aug 2009 22:46:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7G5Z6pB005460; Sat, 15 Aug 2009 22:35:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3677 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30262 Archived-At: This is a multi-part message in MIME format... ------------=_1250400905-5425-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sun, 16 Aug 2009 01:27:35 -0400 with message-id <874os8ba60.fsf@cyd.mit.edu> and subject line Re: 23.0.95; facemenu-read-color should not require match has caused the Emacs bug report #3677, regarding 23.0.95; facemenu-read-color should not require match to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3677: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3677 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1250400905-5425-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 25 Jun 2009 14:24:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,FOURLA,IMPRONONCABLE_1, MURPHY_WRONG_WORD2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5PEOnKr003257 for ; Thu, 25 Jun 2009 07:24:51 -0700 Received: from mx10.gnu.org ([199.232.76.166]:34644) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MJpsf-0001W5-41 for emacs-pretest-bug@gnu.org; Thu, 25 Jun 2009 10:24:49 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MJpsb-0006f3-7d for emacs-pretest-bug@gnu.org; Thu, 25 Jun 2009 10:24:48 -0400 Received: from hermes.mail.tigertech.net ([64.62.209.72]:55270) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJpsa-0006eK-Jw for emacs-pretest-bug@gnu.org; Thu, 25 Jun 2009 10:24:45 -0400 Received: from localhost (localhost [127.0.0.1]) by hermes.tigertech.net (Postfix) with ESMTP id 28EC1430264; Thu, 25 Jun 2009 07:24:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at hermes.tigertech.net Received: from motoko.argon.local (unknown [72.165.80.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hermes.tigertech.net (Postfix) with ESMTP id 5518843025B; Thu, 25 Jun 2009 07:24:39 -0700 (PDT) From: Jay Berkenbilt To: emacs-pretest-bug@gnu.org Subject: 23.0.95; facemenu-read-color should not require match Message-ID: <20090625102438.2173776366.qww314159@motoko.argon.local> Date: Thu, 25 Jun 2009 10:24:38 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) [I apologize if this is a duplicate. M-x report-emacs-bug doesn't appear to have called my sendmail-send-it function, so my original report is likely to be rejected as spam from many recipients.] M-x set-cursor-color RET #9ef RET -> [no match] The same thing happens with set-foreground-color and set-background-color, all of which call facemenu-read-color, but not with set-face-foreground and set-face-background, which do not. All above mentioned functions do completing reads on color names, which is appropriate, but they should also accept #xxx, #xxxxxx, rgb:xx/xx/xx, etc. If you do M-: (set-cursor-color "#9ef"), it works, so this is clearly a case of the wrong kind of completing read being done. In facemenu-read-color, in the let statement, require-match is initialized this way: (require-match (not (eq window-system 'ns))) I believe it should always have the value nil so that people are free to enter colors in alternative ways. In GNU Emacs 23.0.95.1 (i686-pc-linux-gnu, GTK+ Version 2.10.4) of 2009-06-23 on motoko.argon.local Windowing system distributor `The X.Org Foundation', version 11.0.70101000 configured using `configure '--prefix=/opt/tps/packages/linux.ix86.rhel5/emacs-23.0.95-1'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Conf[Xdefaults] Minor modes in effect: diff-auto-refine-mode: t which-function-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-n C-n C-n C-n C-b C-d 9 C-d e C-x C-s C-p C-p C-p C-p C-b C-b C-d 8 d C-d C-x C-s C-d e C-x C-s C-x o C-v C-x C-x o C-x o C-b C-b C-b C-d d C-n C-n C-n C-n e C-x C-s C-x C-s C-x 0 M-< C-v C-v C-v C-v C-v C-v C-v C-v C-v M-v M-v C-SPC C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-g M-v M-v M-v M-v M-v C-x b C-f C-f C-b C-d b C-n C-n C-n C-n c C-x C-s C-x C-s C-x b C-s s k y C-x b C-x v u y e s C-n C-n C-n C-n C-k C-z C-o M-b 0 9 e f C-k C-p C-p C-p C-p 8 d e C-x C-s C-n C-n C-n C-n C-n M-b C-k b l a c k C-x C-s M-x C-g C-x b C-g C-x C-f ~ / X r c o C-s c u r s o r C-z C-o C-s C-s C-s C-e C-l M-b C-k 9 e f C-x b C-x b C-x C-s C-x b C-x b M-x s e t SPC c u # 9 9 e e f f M-p C-k ' # 9 e f C-g M-: ( s e t - c u r s o r - c o l o r SPC " # d 9 0 e f e f " ) C-a C-e M-x r e p o r t SPC b e m SPC b SPC Recent messages: Saving file /home/jberkenb/.local/share/themes/qtheme/openbox-3/themerc... Wrote /home/jberkenb/.local/share/themes/qtheme/openbox-3/themerc Quit [2 times] Note: file is write protected Mark saved where search started Checking out /home/jberkenb/Xresources/color...done Mark saved where search started Saving file /home/jberkenb/Xresources/color... Wrote /home/jberkenb/Xresources/color Quit nil ------------=_1250400905-5425-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3677-done) by emacsbugs.donarmstrong.com; 16 Aug 2009 05:26:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,IMPRONONCABLE_1, MURPHY_WRONG_WORD2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7G5Qaq6004145 for <3677-done@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 22:26:37 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 6B1BD57E21C; Sun, 16 Aug 2009 01:27:35 -0400 (EDT) From: Chong Yidong To: Jay Berkenbilt Cc: 3677-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.95; facemenu-read-color should not require match Date: Sun, 16 Aug 2009 01:27:35 -0400 Message-ID: <874os8ba60.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > M-x set-cursor-color RET #9ef RET > > -> [no match] > > The same thing happens with set-foreground-color and > set-background-color, all of which call facemenu-read-color, but not > with set-face-foreground and set-face-background, which do not. All > above mentioned functions do completing reads on color names, which is > appropriate, but they should also accept #xxx, #xxxxxx, rgb:xx/xx/xx, > etc. If you do M-: (set-cursor-color "#9ef"), it works, so this is > clearly a case of the wrong kind of completing read being done. Thanks for the bug report. I've hacked up the completion function so that it allows any defined colors, including RGB triplets. ------------=_1250400905-5425-0--