bug#3652: marked as done (FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]


Your message dated Thu, 23 Jul 2009 10:43:36 -0400
with message-id <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com>
and subject line Re: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared
has caused the Emacs bug report #3652,
regarding FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3652: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3652
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4832 bytes --]

From: Yavor Doganov <yavor@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared
Date: Mon, 22 Jun 2009 23:40:22 +0300
Message-ID: <87hby86lzd.GNU's_Not_Unix!%yavor@gnu.org>

Package: emacs,ns
Severity: serious
Tags: patch

The GNUstep port fails to build currently following this change:

2009-06-08  Adrian Robert  <Adrian.B.Robert@gmail.com>

	Changes to support :script/:lang/:otf in NS font driver.
	...

I believe it's a bug in GNUstep GUI which I'll report to their
tracker.  For now, I suggest the workaround below.

What's worse is that the NSFontDescriptor class was implemented in GUI
0.13, while gNewSense DeltaH has 0.12.  Do you consider it important
enough to add a fallback code?


Changelog:

2009-06-22  Yavor Doganov  <yavor@gnu.org>

	* configure.in: Check for <AppKit/NSFontdescriptor.h>.

*** configure.in	22 юни 2009 22:30:12 +0300	1.599
--- configure.in	22 юни 2009 23:29:18 +0300	
***************
*** 1257,1262 ****
--- 1257,1264 ----
    AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes],
    		  [AC_MSG_ERROR([`--with-ns' was specified, but the include
    files are missing or cannot be compiled.])])
+   AC_CHECK_HEADER([AppKit/NSFontDescriptor.h], [],
+                   [AC_MSG_ERROR([NSFontDescriptor is required.])])
    NS_HAVE_NSINTEGER=yes
    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>],
                                       [NSInteger i;])],

src/ChangeLog:

2009-06-22  Yavor Doganov  <yavor@gnu.org>

	* nsfont.m: Import <AppKit/NSFontDescriptor.h>.

*** nsfont.m	18 юни 2009 12:35:30 +0300	1.26
--- nsfont.m	22 юни 2009 22:35:30 +0300	
***************
*** 37,42 ****
--- 37,47 ----
  #include "character.h"
  #include "font.h"
  
+ /* This header is not included from GNUstep's (0.16.0) AppKit.h.  */
+ #ifdef NS_IMPL_GNUSTEP
+ #import <AppKit/NSFontDescriptor.h>
+ #endif
+ 
  #define NSFONT_TRACE 0
  
  extern Lisp_Object Qns;


[-- Attachment #3: Type: message/rfc822, Size: 2787 bytes --]

From: Adrian Robert <adrian.b.robert@gmail.com>
To: 3652-done@emacsbugs.donarmstrong.com
Subject: Re: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared
Date: Thu, 23 Jul 2009 10:43:36 -0400
Message-ID: <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com>

Closing.  I've checked in Yavor's change to nsfont.m to include  
NSFontDescriptor.h, but am leaving out the configure.in change -- it  
will slow down the configure for all NS builds for a condition that is  
hopefully temporary, and anyway the compile error message should be  
clear enough for builders.