[emacs-w3m:10206] ffap-string-at-point-mode-alist should include multibyte

[emacs-w3m:10206] ffap-string-at-point-mode-alist should include multibyte

[jidanni]

>>>>> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>> In [emacs-w3m : No.10204] jidanni@jidanni.org wrote:
>> U runs the command w3m-goto-url
>> but when the cursor is upon the link
>> http://www.coolloud.org.tw/tag/移民工/feed
>> it only prompts with
>> http://www.coolloud.org.tw/tag/
>> apparently unable to deal with the non-ASCII.

KY> Besause emacs-w3m uses the `ffap-url-at-point' function, what
KY> should be improved is the url element of the variable
KY> `ffap-string-at-point-mode-alist' defined in ffap.el.  For
KY> instance:

KY> (eval-after-load "ffap"
KY>   '(setcar (cdr (assq 'url ffap-string-at-point-mode-alist))
KY> 	   "--:=&?$+@-Z_[:lower:][:multibyte:]~#,%;*"))

KY> It defaults to "--:=&?$+@-Z_[:lower:]~#,%;*" which does not
KY> match non-ASCII characters.

OK, your workaround works.  I'm CCing this to bug-gnu-emacs.

bug#357: marked as done (ffap-string-at-point-mode-alist should include multibyte)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]


Your message dated Tue, 10 Jun 2008 15:35:44 -0400
with message-id <jwv8wxdqe3y.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: ffap-string-at-point-mode-alist should include multibyte 
has caused the Emacs bug report #357,
regarding ffap-string-at-point-mode-alist should include multibyte
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
357: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=357
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2900 bytes --]

From: jidanni@jidanni.org
To: emacs-w3m@namazu.org
Cc: bug-gnu-emacs@gnu.org
Subject: ffap-string-at-point-mode-alist should include multibyte
Date: Wed, 04 Jun 2008 08:47:10 +0800
Message-ID: <87zlq2m3g1.fsf_-_@jidanni.org>

>>>>> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>> In [emacs-w3m : No.10204] jidanni@jidanni.org wrote:
>> U runs the command w3m-goto-url
>> but when the cursor is upon the link
>> http://www.coolloud.org.tw/tag/移民工/feed
>> it only prompts with
>> http://www.coolloud.org.tw/tag/
>> apparently unable to deal with the non-ASCII.

KY> Besause emacs-w3m uses the `ffap-url-at-point' function, what
KY> should be improved is the url element of the variable
KY> `ffap-string-at-point-mode-alist' defined in ffap.el.  For
KY> instance:

KY> (eval-after-load "ffap"
KY>   '(setcar (cdr (assq 'url ffap-string-at-point-mode-alist))
KY> 	   "--:=&?$+@-Z_[:lower:][:multibyte:]~#,%;*"))

KY> It defaults to "--:=&?$+@-Z_[:lower:]~#,%;*" which does not
KY> match non-ASCII characters.

OK, your workaround works.  I'm CCing this to bug-gnu-emacs.




[-- Attachment #3: Type: message/rfc822, Size: 2457 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 357-done@emacsbugs.donarmstrong.com
Subject: Re: ffap-string-at-point-mode-alist should include multibyte
Date: Tue, 10 Jun 2008 15:35:44 -0400
Message-ID: <jwv8wxdqe3y.fsf-monnier+emacsbugreports@gnu.org>

I've installed the following patch instead, which seems to work as well.


        Stefan


=== modified file 'lisp/ffap.el'
--- lisp/ffap.el	2008-06-06 06:58:42 +0000
+++ lisp/ffap.el	2008-06-10 19:32:25 +0000
@@ -978,11 +978,11 @@
     ;; Slightly controversial decisions:
     ;; * strip trailing "@" and ":"
     ;; * no commas (good for latex)
-    (file "--:\\\\$+<>@-Z_[:lower:]~*?" "<@" "@>;.,!:")
+    (file "--:\\\\$+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
     ;; An url, or maybe a email/news message-id:
-    (url "--:=&?$+@-Z_[:lower:]~#,%;*" "^[:alnum:]" ":;.,!?")
+    (url "--:=&?$+@-Z_[:alpha:]~#,%;*" "^[:alnum:]" ":;.,!?")
     ;; Find a string that does *not* contain a colon:
-    (nocolon "--9$+<>@-Z_[:lower:]~" "<@" "@>;.,!?")
+    (nocolon "--9$+<>@-Z_[:alpha:]~" "<@" "@>;.,!?")
     ;; A machine:
     (machine "-[:alnum:]." "" ".")
     ;; Mathematica paths: allow backquotes