bug#3343: 23.0.93; Setting grep-command etc has no effect

bug#3343: 23.0.93; Setting grep-command etc has no effect

[Johan =?UTF-8?Q?Bockg=C3=A5rd]

The problem is that grep-compute-defaults overwrites `grep-command',
`grep-find-command' et al.


emacs -Q
M-x set-variable RET grep-command RET "ls" RET
M-x grep RET RET
M-x set-variable RET grep-command RET "ll" RET
M-x grep RET   => The old command is still used.


This used to work in Emacs 22.

bug#3343: marked as done (23.0.93; Setting grep-command etc has no effect)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


Your message dated Fri, 22 May 2009 20:19:43 -0400
with message-id <87pre0ekm8.fsf@cyd.mit.edu>
and subject line 23.0.93; Setting grep-command etc has no effect
has caused the Emacs bug report #3343,
regarding 23.0.93; Setting grep-command etc has no effect
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3343: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3343
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2419 bytes --]

From: bojohan+mail@dd.chalmers.se (Johan Bockgård)
To: emacs-pretest-bug@gnu.org
Subject: 23.0.93; Setting grep-command etc has no effect
Date: Thu, 21 May 2009 16:14:47 +0200
Message-ID: <yoij1vqimtk8.fsf@remote2.student.chalmers.se>


The problem is that grep-compute-defaults overwrites `grep-command',
`grep-find-command' et al.


emacs -Q
M-x set-variable RET grep-command RET "ls" RET
M-x grep RET RET
M-x set-variable RET grep-command RET "ll" RET
M-x grep RET   => The old command is still used.


This used to work in Emacs 22.



[-- Attachment #3: Type: message/rfc822, Size: 1841 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: bojohan+mail@dd.chalmers.se (Johan Bockgård)
Cc: 3343-done@emacsbugs.donarmstrong.com
Subject: 23.0.93; Setting grep-command etc has no effect
Date: Fri, 22 May 2009 20:19:43 -0400
Message-ID: <87pre0ekm8.fsf@cyd.mit.edu>

> emacs -Q
> M-x set-variable RET grep-command RET "ls" RET
> M-x grep RET RET
> M-x set-variable RET grep-command RET "ll" RET
> M-x grep RET   => The old command is still used.
>
> This used to work in Emacs 22.

This is due to the introduction of grep-compute-defaults and
grep-host-defaults-alist, which is supposed to offer "smarter" defaults
for these variables when you call grep on remote files.  Unfortunately,
this means that if you simply change these variables, those changes get
overwritten during the next interactive call to grep.

We should probably revisit the design of this code after the release.

In the meantime, I've made a change so that if you change these
variables via the Customize interface, the new values will take effect
correctly.