From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#33: marked as done (Patches for CANNOT_DUMP on 23.0.60 (fwd)) Date: Sun, 31 Aug 2008 07:00:04 -0700 Message-ID: References: <87k5dxjnm0.fsf@cyd.mit.edu> <30eab8fd35ca2f1a38a9632fe50c81b0@lagorda> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1220191204-28016-0" X-Trace: ger.gmane.org 1220191677 15785 80.91.229.12 (31 Aug 2008 14:07:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Aug 2008 14:07:57 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 31 16:08:51 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KZnbl-0002xt-NM for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2008 16:08:50 +0200 Original-Received: from localhost ([127.0.0.1]:54661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZnam-0004Sw-N9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Aug 2008 10:07:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZnaY-0004I8-Sm for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 10:07:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZnaY-0004HW-7q for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 10:07:34 -0400 Original-Received: from [199.232.76.173] (port=57896 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZnaX-0004HK-Ir for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 10:07:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:39430) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZnaW-0008De-Ij for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2008 10:07:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7VE7UgP031727; Sun, 31 Aug 2008 07:07:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7VE049q028127; Sun, 31 Aug 2008 07:00:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 33 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19932 Archived-At: This is a multi-part message in MIME format... ------------=_1220191204-28016-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sun, 31 Aug 2008 09:55:03 -0400 with message-id <87k5dxjnm0.fsf@cyd.mit.edu> and subject line Re: Patches for CANNOT_DUMP on 23.0.60 (fwd) has caused the Emacs bug report #33, regarding Patches for CANNOT_DUMP on 23.0.60 (fwd) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 33: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D33 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1220191204-28016-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Mar 2008 13:58:19 +0000 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m23Dw9ma015530 for ; Mon, 3 Mar 2008 05:58:11 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAD+Sy0fO+LKX/2dsb2JhbACFMIxJmh+BAA X-IronPort-AV: E=Sophos;i="4.25,438,1199682000"; d="diff'?scan'208";a="15487479" Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 03 Mar 2008 08:57:54 -0500 Received: from pastel.home ([206.248.178.151]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id JQI07154 for ; Mon, 03 Mar 2008 08:57:54 -0500 Received: by pastel.home (Postfix, from userid 20848) id 644CE8279; Mon, 3 Mar 2008 08:57:54 -0500 (EST) Resent-Message-ID: Resent-To: submit@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-Date: Mon, 03 Mar 2008 08:57:54 -0500 X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 61DE02CF86E for ; Mon, 3 Mar 2008 01:22:08 -0500 (EST) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 6E48A3B8B43 for ; Mon, 3 Mar 2008 01:22:01 -0500 (EST) Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW43l-00087l-1Q for monnier@iro.umontreal.ca; Mon, 03 Mar 2008 01:22:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JW43c-00087M-BN for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2008 01:21:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JW43a-000879-Ik for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2008 01:21:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW43a-000876-Cx for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2008 01:21:50 -0500 Received: from wf-out-1314.google.com ([209.85.200.171]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JW43a-0001vg-0p for bug-gnu-emacs@gnu.org; Mon, 03 Mar 2008 01:21:50 -0500 Received: by wf-out-1314.google.com with SMTP id 29so6636760wff.24 for ; Sun, 02 Mar 2008 22:21:48 -0800 (PST) Received: by 10.143.159.11 with SMTP id l11mr4940947wfo.186.1204525308237; Sun, 02 Mar 2008 22:21:48 -0800 (PST) Received: from localhost.localdomain ( [75.95.220.61]) by mx.google.com with ESMTPS id 30sm25913192wff.11.2008.03.02.22.21.46 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 02 Mar 2008 22:21:46 -0800 (PST) Date: Sun, 02 Mar 2008 20:25:09 -1000 Message-ID: <30eab8fd35ca2f1a38a9632fe50c81b0@lagorda> MIME-Version: 1.0 (Generated by Pantomime 1.2.0) From: "Chris Hall" To: Emacs bugs User-Agent: GNUMail (Version 1.2.0) Content-Type: multipart/mixed; boundary="=_ce13c6bab71330c375fb5514ccd6ae21" X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Cc: "Emacs.apps dev" Subject: Patches for CANNOT_DUMP on 23.0.60 (fwd) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.763, requis 5, BAYES_00 -2.60, MC_TRANSFR 0.11, RCVD_BY_IP 0.07, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org --=_ce13c6bab71330c375fb5514ccd6ae21 Content-Type: text/plain; charset="us-ascii"; format="flowed" A little more info on the second patch: Between Emacs 23.0.50 and 23.0.60, 'make_terminal_frame' was split into 'make_initial_frame' and 'make_terminal_frame'. Both versions of 'make_terminal_frame' end with a potential call to 'init_frame_faces'. The issue is that the Emacs CANNOT_DUMP build on my machine calls only 'make_initial_frame' during startup, and if 'init_frame_faces' isn't called, Emacs segfaults while attempting to dereference a 'face_cache' struct member containing 0x0. This occurs during startup after entering 'recursive_edit' while evaluating 'display-supports-face-attributes-p'. Maybe on DUMPED platforms 'init_frame_faces' somehow gets called earlier? HTH, Chris Hall ---------- Forwarded message ---------- Date: 2008-03-01 23:07:00 -1000 From: Chris Hall Subject: Patches for CANNOT_DUMP on 23.0.60 Aloha :) I currently use Emacs on Debian Sarge (sorry, RMS! ;) with a custom 2.6 kernel. I have recently also started using the GNUstep port, Emacs.app, on the current stable GNUstep. As of this writing, that would be: gnustep-base-1.14.2, gnustep-back-0.12.1 (libart), gnustep-gui-0.12.1, gnustep-make-2.0.4. Attached please find two patches that resolve: * While building Emacs 23.0.60, I would consistently get the following: batch-byte-compile quail/CCDOSPY.el make[1]: *** [quail/CCDOSPY.elc] Segmentation fault Based on information I received from YAMAMOTO Mitsuharu, the code in the attached patch 'gnustep-callproc.c.diff' seems to resolve that issue. * During startup, Emacs would consistently segfault while attempting to dereference a face_cache struct member containing address 0x0. This appears to be due to a problem where certain lisp functions get called in one order on DUMPED machines, and a different order on CANNOT_DUMP machines. (And again, YAMAMOTO Mitsuharu was very helpful in resolving this.) The attached patch 'gnustep-frame.c.diff' seems to resolve that issue on my machine. FYI, I also needed to increase SYSTEM_PURESIZE_EXTRA in order to avoid the associated warning message on startup. I used 200000 after first trying 100000, which wasn't enough. You may, of course, Free-ly use (or not!) the attached files. Mahalo for your time, Chris Hall --=_ce13c6bab71330c375fb5514ccd6ae21 Content-Transfer-Encoding: base64 Content-Type: text/plain; name="gnustep-callproc.c.diff" Content-Disposition: attachment; filename="gnustep-callproc.c.diff" KioqIGVtYWNzLTIzLjAuMF9OUy05LjByYzMvc3JjL2NhbGxwcm9jLmMJMjAwNy0xMC0yNyAx ODoyMTozNi4wMDAwMDAwMDAgLTEwMDAKLS0tIC4uL3NyYy9jYWxscHJvYy5jCTIwMDgtMDMt MDEgMjE6NDE6NTYuMDAwMDAwMDAwIC0xMDAwCioqKioqKioqKioqKioqKiBzZXRfaW5pdGlh bF9lbnZpcm9ubWVudCAoKQoqKiogMTY1OCwxNjY1ICoqKioKICAgIHJlZ2lzdGVyIGNoYXIg KiplbnZwOwogICNpZm5kZWYgQ0FOTk9UX0RVTVAKICAgIGlmIChpbml0aWFsaXplZCkKLSAj ZW5kaWYKICAgICAgewogICAgICAgIGZvciAoZW52cCA9IGVudmlyb247ICplbnZwOyBlbnZw KyspCiAgCVZwcm9jZXNzX2Vudmlyb25tZW50ID0gRmNvbnMgKGJ1aWxkX3N0cmluZyAoKmVu dnApLAogIAkJCQkgICAgICBWcHJvY2Vzc19lbnZpcm9ubWVudCk7Ci0tLSAxNjU4LDE2Njgg LS0tLQogICAgcmVnaXN0ZXIgY2hhciAqKmVudnA7CiAgI2lmbmRlZiBDQU5OT1RfRFVNUAog ICAgaWYgKGluaXRpYWxpemVkKQogICAgICB7CisgI2Vsc2UKKyAgICAgeworICAgICAgIFZw cm9jZXNzX2Vudmlyb25tZW50ID0gUW5pbDsKKyAjZW5kaWYKICAgICAgICBmb3IgKGVudnAg PSBlbnZpcm9uOyAqZW52cDsgZW52cCsrKQogIAlWcHJvY2Vzc19lbnZpcm9ubWVudCA9IEZj b25zIChidWlsZF9zdHJpbmcgKCplbnZwKSwKICAJCQkJICAgICAgVnByb2Nlc3NfZW52aXJv bm1lbnQpOwo= --=_ce13c6bab71330c375fb5514ccd6ae21 Content-Transfer-Encoding: base64 Content-Type: text/plain; name="gnustep-frame.c.diff" Content-Disposition: attachment; filename="gnustep-frame.c.diff" KioqIGVtYWNzLTIzLjAuMF9OUy05LjByYzMvc3JjL2ZyYW1lLmMJMjAwNy0xMS0xMCAxNzo1 Mzo1Ny4wMDAwMDAwMDAgLTEwMDAKLS0tIC4uL3NyYy9mcmFtZS5jCTIwMDgtMDMtMDEgMjE6 MzE6MzkuMDAwMDAwMDAwIC0xMDAwCioqKioqKioqKioqKioqKiBtYWtlX2luaXRpYWxfZnJh bWUgKHZvaWQpCioqKiA1NTksNTY0ICoqKioKLS0tIDU1OSw1NjkgLS0tLQogICAgRlJBTUVf Q0FOX0hBVkVfU0NST0xMX0JBUlMgKGYpID0gMDsKICAgIEZSQU1FX1ZFUlRJQ0FMX1NDUk9M TF9CQVJfVFlQRSAoZikgPSB2ZXJ0aWNhbF9zY3JvbGxfYmFyX25vbmU7CiAgCisgI2lmZGVm IENBTk5PVF9EVU1QCisgICBpZiAoIW5vbmludGVyYWN0aXZlKQorICAgICBpbml0X2ZyYW1l X2ZhY2VzIChmKTsKKyAjZW5kaWYKKyAKICAgIHJldHVybiBmOwogIH0KICAK --=_ce13c6bab71330c375fb5514ccd6ae21-- ------------=_1220191204-28016-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 33-done) by emacsbugs.donarmstrong.com; 31 Aug 2008 13:52:56 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7VDqr2j025930 for <33-done@emacsbugs.donarmstrong.com>; Sun, 31 Aug 2008 06:52:55 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 754FB57E311; Sun, 31 Aug 2008 09:55:03 -0400 (EDT) From: Chong Yidong To: 33-done@emacsbugs.donarmstrong.com Subject: Re: Patches for CANNOT_DUMP on 23.0.60 (fwd) Date: Sun, 31 Aug 2008 09:55:03 -0400 Message-ID: <87k5dxjnm0.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Closing this bug, as both patches have been checked in (2008-07-15). ------------=_1220191204-28016-0--