From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)
To: Chong Yidong <cyd@stupidchicken.com>
Subject: bug#2993: marked as done (23.0.92; posn-col-row wrong with line-spacing in terminals)
Date: Wed, 15 Apr 2009 22:50:03 +0000 [thread overview]
Message-ID: <handler.2993.D2993.123983545928306.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: m28wm31ock.fsf@nschum.de
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Your message dated Wed, 15 Apr 2009 18:46:02 -0400
with message-id <87ab6hbknp.fsf@cyd.mit.edu>
and subject line Re: 23.0.92; posn-col-row wrong with line-spacing in terminals
has caused the Emacs bug report #2993,
regarding 23.0.92; posn-col-row wrong with line-spacing in terminals
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
2993: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2993
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 2622 bytes --]
From: Nikolaj Schumacher <me@nschum.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.92; posn-col-row wrong with line-spacing in terminals
Date: Tue, 14 Apr 2009 13:11:55 +0200
Message-ID: <m28wm31ock.fsf@nschum.de>
posn-col-row uses the `line-spacing' value in terminals. According to the
doc `line-spacing' only has an effect in window systems.
Steps to reproduce:
- (setq-default line-spacing 3)
- emacsclient -t
- Move to a non-trivial pos.
- M-: (posn-col-row (posn-at-point))
Something like this would help:
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -934,7 +934,8 @@ and `event-end' functions."
(y (/ (cdr pair) (+ (frame-char-height frame)
(or (frame-parameter frame 'line-spacing)
;; FIXME: Why the `default'?
- (default-value 'line-spacing)
+ (when (window-system frame)
+ (default-value 'line-spacing))
0)))))
(cons x y))))))
[-- Attachment #3: Type: message/rfc822, Size: 1589 bytes --]
From: Chong Yidong <cyd@stupidchicken.com>
To: Nikolaj Schumacher <me@nschum.de>
Cc: Eli Zaretskii <eliz@gnu.org>, 2993-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.92; posn-col-row wrong with line-spacing in terminals
Date: Wed, 15 Apr 2009 18:46:02 -0400
Message-ID: <87ab6hbknp.fsf@cyd.mit.edu>
> posn-col-row uses the `line-spacing' value in terminals. According to
> the doc `line-spacing' only has an effect in window systems.
Actually, there were several additional bugs in the code. The function
should have used the line-spacing variable in the buffer itself, not its
default value, and also the line-spacing variable should take precedence
over the line-spacing frame parameter. Also, it failed to account for
floating-point line-spacing values.
I've committed a fix. Thanks.
prev parent reply other threads:[~2009-04-15 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ab6hbknp.fsf@cyd.mit.edu>
2009-04-14 11:11 ` bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Nikolaj Schumacher
2009-04-14 11:32 ` Eli Zaretskii
2009-04-14 12:12 ` Nikolaj Schumacher
2009-04-14 13:59 ` Eli Zaretskii
2009-04-15 22:50 ` Emacs bug Tracking System [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=handler.2993.D2993.123983545928306.ackdone@emacsbugs.donarmstrong.com \
--to=owner@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).