From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2989: marked as done (history-delete-duplicates does not apply to command history) Date: Wed, 15 Apr 2009 00:20:04 +0000 Message-ID: References: <200904150009.n3F09sos005185@godzilla.ics.uci.edu> <87d4bgt88e.fsf@jidanni.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1239754804-12143-0" X-Trace: ger.gmane.org 1239755065 31434 80.91.229.12 (15 Apr 2009 00:24:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Apr 2009 00:24:25 +0000 (UTC) To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 15 02:25:44 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ltswc-0000dm-JU for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Apr 2009 02:25:39 +0200 Original-Received: from localhost ([127.0.0.1]:36152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtsvD-0005O4-Rw for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 20:24:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ltsv0-0005KJ-6T for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:23:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ltsuv-0005Iz-Tn for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:23:57 -0400 Original-Received: from [199.232.76.173] (port=53390 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ltsuv-0005Iu-H8 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:23:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60954) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ltsuu-0001Bc-Um for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:23:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3F0NoW3013288; Tue, 14 Apr 2009 17:23:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3F0K43w012250; Tue, 14 Apr 2009 17:20:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2989 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27187 Archived-At: This is a multi-part message in MIME format... ------------=_1239754804-12143-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 14 Apr 2009 17:09:54 -0700 (PDT) with message-id <200904150009.n3F09sos005185@godzilla.ics.uci.edu> and subject line Re: bug#2989: history-delete-duplicates does not apply to = command history has caused the Emacs bug report #2989, regarding history-delete-duplicates does not apply to command history to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2989: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2989 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1239754804-12143-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Apr 2009 00:41:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3E0fdGv014949 for ; Mon, 13 Apr 2009 17:41:40 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtWiY-0002Gl-CJ for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2009 20:41:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtWiT-0002B5-OY for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2009 20:41:38 -0400 Received: from [199.232.76.173] (port=55635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtWiT-0002Ap-FT for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2009 20:41:33 -0400 Received: from caiajhbdccac.dreamhost.com ([208.97.132.202]:49116 helo=homiemail-a4.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LtWiT-0002TV-3S for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2009 20:41:33 -0400 Received: from jidanni.org (122-127-38-97.dynamic.hinet.net [122.127.38.97]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by homiemail-a4.g.dreamhost.com (Postfix) with ESMTP id 5BC8441627 for ; Mon, 13 Apr 2009 17:41:30 -0700 (PDT) To: bug-gnu-emacs@gnu.org Subject: implement bash's ignoredups From: jidanni@jidanni.org Date: Tue, 14 Apr 2009 08:00:17 +0800 Message-ID: <87d4bgt88e.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) M-p (translated from p) runs the command previous-history-element Which gets rather frustrating when one runs into a long patch of the same command, e.g., (compile "make" nil) (compile "make" nil) (compile "make" nil) That's because emacs hasn't implement bash's ignoredups: HISTCONTROL ...value of ignoredups causes lines matching the previous history entry to not be saved...A value of erasedups causes all previous lines matching the current line to be removed from the history list before that line is saved. Note I'm not talking about the *shell* buffer, but instead repeat-complex-command's previous-history-element etc. ------------=_1239754804-12143-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2989-done) by emacsbugs.donarmstrong.com; 15 Apr 2009 00:10:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3F0A66x009711 for <2989-done@emacsbugs.donarmstrong.com>; Tue, 14 Apr 2009 17:10:07 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n3F09tKv016895; Tue, 14 Apr 2009 17:09:55 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n3F09sos005185; Tue, 14 Apr 2009 17:09:54 -0700 (PDT) Date: Tue, 14 Apr 2009 17:09:54 -0700 (PDT) Message-Id: <200904150009.n3F09sos005185@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 2989-done@emacsbugs.donarmstrong.com, jidanni@jidanni.org Subject: Re: bug#2989: history-delete-duplicates does not apply to command history References: <200904140201.n3E219Rx007518@godzilla.ics.uci.edu> <874owst2bo.fsf_-_@jidanni.org> <200904140533.n3E5X4B7012170@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Tue, 14 Apr 2009 09:04:54 -0400") Lines: 18 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n3F09tKv016895 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > >> > You probably want to open another bug saying that > >> I'll just hopefully hereby reopen and retitle this one. > >> > history-delete-duplicates does not apply to command history. > >> (OK, but not sure you don't want two independent variables...) > >> > You can try this (not even compile tested) patch: > >> > --- callint.c.~1.172.~ Tue Mar 31 16:28:30 2009 > >> (Please test for me, I don't own a c-compiler here :-) ) > > > The patch needed an extra declaration to compile, and it seems to work fine. > > > I am not sure if it's acceptable to check in such a change at this point > > in the release process. > > Yes, it's fine, thank you, please install it. Done. ------------=_1239754804-12143-0--