From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2585: marked as done (23.0.90; read-file-name with dialog) Date: Mon, 09 Mar 2009 13:40:04 +0000 Message-ID: References: <49B51A3D.7040101@gnu.org> <18865.28230.516000.264948@MJ.T42.T42> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1236606004-31230-0" X-Trace: ger.gmane.org 1236606301 4091 80.91.229.12 (9 Mar 2009 13:45:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2009 13:45:01 +0000 (UTC) To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 09 14:46:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from terminus-est.gnu.org ([66.92.78.210] helo=lists.gnu.org) by lo.gmane.org with esmtp (Exim 4.50) id 1Lgfo2-00008H-7F for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 14:46:17 +0100 Original-Received: from localhost ([127.0.0.1]:44113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lgfmc-00084R-Ks for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2009 09:44:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lgflr-0007Vl-Cu for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 09:43:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lgflp-0007UG-Vs for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 09:43:54 -0400 Original-Received: from [199.232.76.173] (port=45689 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lgflp-0007Tt-9n for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2009 09:43:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lgflg-0005tz-2s; Mon, 09 Mar 2009 09:43:44 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29DheYr032486; Mon, 9 Mar 2009 06:43:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n29De4B3031342; Mon, 9 Mar 2009 06:40:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2585 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26181 Archived-At: This is a multi-part message in MIME format... ------------=_1236606004-31230-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 09 Mar 2009 21:31:41 +0800 with message-id <49B51A3D.7040101@gnu.org> and subject line Re: bug#2585: 23.0.90; read-file-name with dialog has caused the Emacs bug report #2585, regarding 23.0.90; read-file-name with dialog to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2585: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2585 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1236606004-31230-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 6 Mar 2009 18:41:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n26IfOx7002375 for ; Fri, 6 Mar 2009 10:41:25 -0800 Received: from mx10.gnu.org ([199.232.76.166]:53381) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lfez5-00043D-TQ for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:24 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Lfez1-0005xN-Ux for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:23 -0500 Received: from rv-out-0708.google.com ([209.85.198.245]:38477) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lfez1-0005wr-IW for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:19 -0500 Received: by rv-out-0708.google.com with SMTP id f25so732303rvb.6 for ; Fri, 06 Mar 2009 10:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:mime-version :content-type:content-transfer-encoding:message-id:date:from:to :subject:x-signature:x-spam-processed:x-mdremoteip:x-return-path :x-mdaemon-deliver-to; bh=oZSXEa9hppbe8F6klqlwaHIVzpBI1ddvt4zLTUeLZ+A=; b=ugriuZ+phIrtnfkW/NKRLTfESkP+84jM36rzPnEeQvltaR79OZKdcNA/puJiMAb/DB uD1ZGevTuqm1aT238CKv/PChHy/MjsQ4q6nhZjxuIo0doAxjjXheWLC4GoiR084yNWWP sDpfD1Fsrab3A7Cir+eM6meq5GvhCjP3sFT0w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:mime-version:content-type:content-transfer-encoding :message-id:date:from:to:subject:x-signature:x-spam-processed :x-mdremoteip:x-return-path:x-mdaemon-deliver-to; b=Fx4+lSx9gu0L5hraS8QqLUdVMBuNQjltZ2ez7zKZlvDgELntj0eleVpx3Egfqvup8r /t2xGpFZ4FqBmAnRyVDRNSUGRH1VAuVQHLE1smK9edZ5ykxiB6GYUN7eFa9SWL1Q0HBX hj8ZOjju+6YkS/0o6A0S4PJwE4TJhwSPC7IhE= Received: by 10.114.81.1 with SMTP id e1mr1669747wab.212.1236364877606; Fri, 06 Mar 2009 10:41:17 -0800 (PST) Received: from greenplace.page.us (c-68-33-70-96.hsd1.md.comcast.net [68.33.70.96]) by mx.google.com with ESMTPS id z15sm3830985pod.0.2009.03.06.10.41.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Mar 2009 10:41:16 -0800 (PST) Sender: MJ Chan Received: from T42 ([127.0.0.1]) by local (greenplace.page.us [127.0.0.1]) (MDaemon.PRO.v6.8.5.R) with ESMTP id 16-md50000000001.tmp for ; Fri, 06 Mar 2009 13:41:10 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18865.28230.516000.264948@MJ.T42.T42> Date: Fri, 6 Mar 2009 13:41:10 -0500 From: MJ To: emacs-pretest-bug@gnu.org Subject: 23.0.90; read-file-name with dialog X-Signature: mjchan 1548f55a6ed0d5c35ad11818fc49c2b2 X-MDRemoteIP: 127.0.0.1 X-Return-Path: mjchan.inbox@gmail.com X-MDaemon-Deliver-To: emacs-pretest-bug@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) When read-file-name is called and uses windows dialog to read a file name, the 'dir' parameter has to be ended with '/'. It it does not, the last part of the path name is used as the filename while the default directory is the stripped 'dir' without last part. This does not happen in Emacs 22. In minibuffer, there is comment that says: ;; If DIR contains a file name, split it. I'm not sure if that is the right thing to do. At least, it breaks the compatibility with previous Emacs version. Is this an intended change? Thanks. -- In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600) of 2009-02-22 on T42 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --cflags -I../../GnuWin32/include' ------------=_1236606004-31230-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2585-done) by emacsbugs.donarmstrong.com; 9 Mar 2009 13:32:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.184]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29DWE9k029891 for <2585-done@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 06:32:15 -0700 Received: by ti-out-0910.google.com with SMTP id 28so1130498tif.1 for <2585-done@emacsbugs.donarmstrong.com>; Mon, 09 Mar 2009 06:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Ey0bIXetpen34doDGzMOcVFjCbUTMmruhZinHoZGLVQ=; b=oSbyo4nNLyiI13bwKPUyMytHSwG4fkWRXEu+cEOuMfuHGUKlNhAdfrIQ5FwC2NLETd J7ycTSZg/kqKKteLgQr5VR2kbNV/1avgjTqIIM163OuXxl5Ju8XJRffnU63UIU4nPVm/ Ck/iUWGwo2V5mtn+jGEDVmmMkrJEXxGlj+fnM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Z4e8K9B9uh6XBaKhta3xJiYbLOJD2IT74cYtllnl99lHJLRw7H/EJHJifef5XwctvX LVbtT+VJNdOdW8QC4is/l+WyfVgHvroloYIqOmKAcqI4lGXerbF8S3ds2AgyRNH+rm1+ T2YOfDRaRkWCMKSKrzWI8mrge/tt/cr+xkp5s= Received: by 10.110.42.1 with SMTP id p1mr9173738tip.18.1236605532116; Mon, 09 Mar 2009 06:32:12 -0700 (PDT) Received: from ?192.168.249.26? ([118.100.161.108]) by mx.google.com with ESMTPS id 25sm804363tif.12.2009.03.09.06.32.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 09 Mar 2009 06:32:11 -0700 (PDT) Sender: Jason Rumney Message-ID: <49B51A3D.7040101@gnu.org> Date: Mon, 09 Mar 2009 21:31:41 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Stefan Monnier CC: MJ , 2585-done@emacsbugs.donarmstrong.com Subject: Re: bug#2585: 23.0.90; read-file-name with dialog References: <87fxhnok4m.fsf@cyd.mit.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Stefan Monnier wrote: >>> ;; If DIR contains a file name, split it. >>> (let ((file (file-name-nondirectory dir))) >>> (when (and default-filename (not (zerop (length file)))) >>> (setq default-filename file) >>> (setq dir (file-name-directory dir))) >>> >>> The third line makes more sense to me as: >>> >>> (when (and (not default-filename) (not (zerop (length file)))) >>> >> That seems right to me. Stefan, you were the one who rewrote >> read-file-name; could you verify this? >> > > Yes, it looks right, > OK, I've checked that change in. ------------=_1236606004-31230-0--