bug#2439: marked as done (23.0.60; [patch] `Mark set' clobbers useful message in ibuffer)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]


Your message dated Mon, 23 Feb 2009 12:01:57 +0100
with message-id <f7ccd24b0902230301l4ac70462w24994cb492180b20@mail.gmail.com>
and subject line Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in  ibuffer
has caused the Emacs bug report #2439,
regarding 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2439: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2439
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4121 bytes --]

From: Geoff Gole <geoffgole@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer
Date: Mon, 23 Feb 2009 11:26:49 +0900
Message-ID: <f5bc73230902221826h5f405509x9c2ee08b9321e2a7@mail.gmail.com>

In ibuffer, running ibuffer-toggle-sorting-mode will produce a useful
message telling the user what the buffer is now sorted by. That
message is immediately clobbered by an useless `Mark set' message
(useless because ibuffer stomps all over any such mark).

To reproduce:

  emacs -Q
  M-x ibuffer
  ,
  C-h e and observe that both "Sorting by ..." and "Mark set" appear

A patch follows (against GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+
Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian).

diff -c -L /usr/share/emacs/23.0.60/lisp/ibuffer.el.gz -L
/tmp/buffer-content-31328m2 /tmp/jka-com3132uwF
/tmp/buffer-content-31328m2
*** /usr/share/emacs/23.0.60/lisp/ibuffer.el.gz
--- /tmp/buffer-content-31328m2
***************
*** 2277,2283 ****
        (setq buffer-read-only t)
        (set-buffer-modified-p ibuffer-did-modification)
        (setq ibuffer-did-modification nil)
!       (goto-line (1+ orig)))))

  (defun ibuffer-quit ()
    "Quit this `ibuffer' session.
--- 2277,2284 ----
        (setq buffer-read-only t)
        (set-buffer-modified-p ibuffer-did-modification)
        (setq ibuffer-did-modification nil)
!       (goto-char 1)
!       (forward-line orig))))

  (defun ibuffer-quit ()
    "Quit this `ibuffer' session.



[-- Attachment #3: Type: message/rfc822, Size: 2677 bytes --]

From: Juanma Barranquero <lekktu@gmail.com>
To: Geoff Gole <geoffgole@gmail.com>
Cc: 2439-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in  ibuffer
Date: Mon, 23 Feb 2009 12:01:57 +0100
Message-ID: <f7ccd24b0902230301l4ac70462w24994cb492180b20@mail.gmail.com>

On Mon, Feb 23, 2009 at 03:26, Geoff Gole <geoffgole@gmail.com> wrote:

> A patch follows (against GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+
> Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian).

Installed, thanks.

    Juanma