bug#2211: server-socket-dir and make-temp-file

bug#2211: server-socket-dir and make-temp-file

[Roland Winkler]

server-socket-dir is by default a directory in /tmp. With CVS emacs
it also takes the TMPDIR environment variable into account.
Shouldn't this variable be initialized using make-temp-file so that
it obeys any customization of temporary-file-directory?

Actually, I ran the following command in the emacs directory
$ grep "\"/tmp\"" lisp/*el lisp/*/*el
Browsing through the matches, it seems to me that
pmail-mime-attachment-dirs-alist and url-temporary-directory
should be updated, too.

A related issue: I do not quite understand a piece of code like

  (make-temp-file
   (concat (file-name-as-directory
            (or (getenv "TMPDIR") "/tmp"))
            "artist-stdin."))

used in the function artist-system. If the PREFIX arg of
make-temp-file is an absolute directory as in the example above,
make-temp-file will ignore any user customization of
temporary-file-directory. The function ps-run-make-tmp-filename
behaves similarly.


In GNU Emacs 22.2.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-03-27 on tfkp07

bug#2211: server-socket-dir and make-temp-file

[Stefan Monnier]

> server-socket-dir is by default a directory in /tmp. With CVS emacs
> it also takes the TMPDIR environment variable into account.
> Shouldn't this variable be initialized using make-temp-file so that
> it obeys any customization of temporary-file-directory?

No, because emacsclient needs to access server-socket-dir but doesn't
read the .emacs so can't adapt to changes in temporary-file-directory
(it does pay attention to $TMPDIR, on the other hand).

> Actually, I ran the following command in the emacs directory
> $ grep "\"/tmp\"" lisp/*el lisp/*/*el
> Browsing through the matches, it seems to me that
> pmail-mime-attachment-dirs-alist and url-temporary-directory
> should be updated, too.

You're probably right on these ones.

> A related issue: I do not quite understand a piece of code like

>   (make-temp-file
>    (concat (file-name-as-directory
>             (or (getenv "TMPDIR") "/tmp"))
>             "artist-stdin."))

> used in the function artist-system. If the PREFIX arg of
> make-temp-file is an absolute directory as in the example above,
> make-temp-file will ignore any user customization of
> temporary-file-directory. The function ps-run-make-tmp-filename
> behaves similarly.

At first, I was going to say that

     (concat (file-name-as-directory
              (or (getenv "TMPDIR") "/tmp"))
             "artist-stdin.")

should be replaced by

     (expand-file-name "artist-stdin." (or (getenv "TMPDIR") "/tmp"))

but indeed, it's better to just skip it all and let `make-temp-file' use
temporary-file-directory.


        Stefan

bug#2211: server-socket-dir and make-temp-file

[Roland Winkler]

On Thu Feb 5 2009 Stefan Monnier wrote:
> > server-socket-dir is by default a directory in /tmp. With CVS emacs
> > it also takes the TMPDIR environment variable into account.
> > Shouldn't this variable be initialized using make-temp-file so that
> > it obeys any customization of temporary-file-directory?
> 
> No, because emacsclient needs to access server-socket-dir but doesn't
> read the .emacs so can't adapt to changes in temporary-file-directory
> (it does pay attention to $TMPDIR, on the other hand).

Thanks, I see. The lisp code defining server-socket-dir for emacs
matches a corresponding piece of C code in emacsclient.c

> > Actually, I ran the following command in the emacs directory
> > $ grep "\"/tmp\"" lisp/*el lisp/*/*el
> > Browsing through the matches, it seems to me that
> > pmail-mime-attachment-dirs-alist and url-temporary-directory
> > should be updated, too.
> 
> You're probably right on these ones.

I could update those. Yet I just realized that emacs 23 is already
in pretest. Is this the kind of thing that should be changed
nonethless or should I better wait?

> At first, I was going to say that
> 
>      (concat (file-name-as-directory
>               (or (getenv "TMPDIR") "/tmp"))
>              "artist-stdin.")
> 
> should be replaced by
> 
>      (expand-file-name "artist-stdin." (or (getenv "TMPDIR") "/tmp"))
> 
> but indeed, it's better to just skip it all and let `make-temp-file' use
> temporary-file-directory.

Same for these changes: better do them now or wait?

Thanks,

Roland

bug#2211: server-socket-dir and make-temp-file

[Stefan Monnier]

> Thanks, I see.  The lisp code defining server-socket-dir for Emacs
> matches a corresponding piece of C code in emacsclient.c

It deserves a comment (in both places), indeed.

>> You're probably right on these ones.
> I could update those. Yet I just realized that emacs 23 is already
> in pretest. Is this the kind of thing that should be changed
> nonethless or should I better wait?

I'd rather postpone those things to 23.2.


        Stefan

bug#2211: marked as done (server-socket-dir and make-temp-file)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]


Your message dated Sat, 07 Feb 2009 16:58:46 -0500
with message-id <87skmpucx5.fsf@cyd.mit.edu>
and subject line Re: bug#2211: server-socket-dir and make-temp-file
has caused the Emacs bug report #2211,
regarding server-socket-dir and make-temp-file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2211: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2211
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2943 bytes --]

From: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
To: bug-gnu-emacs@gnu.org
Subject: server-socket-dir and make-temp-file
Date: Thu, 05 Feb 2009 18:28:19 +0100
Message-ID: <m3iqnolrnw.fsf@tfkp04.physik.uni-erlangen.de>

server-socket-dir is by default a directory in /tmp. With CVS emacs
it also takes the TMPDIR environment variable into account.
Shouldn't this variable be initialized using make-temp-file so that
it obeys any customization of temporary-file-directory?

Actually, I ran the following command in the emacs directory
$ grep "\"/tmp\"" lisp/*el lisp/*/*el
Browsing through the matches, it seems to me that
pmail-mime-attachment-dirs-alist and url-temporary-directory
should be updated, too.

A related issue: I do not quite understand a piece of code like

  (make-temp-file
   (concat (file-name-as-directory
            (or (getenv "TMPDIR") "/tmp"))
            "artist-stdin."))

used in the function artist-system. If the PREFIX arg of
make-temp-file is an absolute directory as in the example above,
make-temp-file will ignore any user customization of
temporary-file-directory. The function ps-run-make-tmp-filename
behaves similarly.


In GNU Emacs 22.2.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-03-27 on tfkp07




[-- Attachment #3: Type: message/rfc822, Size: 1349 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
Cc: 2211-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2211: server-socket-dir and make-temp-file
Date: Sat, 07 Feb 2009 16:58:46 -0500
Message-ID: <87skmpucx5.fsf@cyd.mit.edu>

> I could update those. Yet I just realized that emacs 23 is already in
> pretest. Is this the kind of thing that should be changed nonethless
> or should I better wait?

I think it's better to fix these now.  I've just done that.  Thanks for
finding the problem.