From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2092: marked as done (23.0.60; vc-svn-diff) Date: Wed, 04 Feb 2009 11:10:04 +0000 Message-ID: References: <18825.30181.243954.921791@kahikatea.snap.net.nz> <20090128063434.74C018FC6D@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1233745804-19389-0" X-Trace: ger.gmane.org 1233746635 14780 80.91.229.12 (4 Feb 2009 11:23:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 11:23:55 +0000 (UTC) To: Nick Roberts Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 04 12:25:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUfsN-0001mM-C5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 12:25:05 +0100 Original-Received: from localhost ([127.0.0.1]:52688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUfr4-0002UI-AD for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 06:23:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUfqx-0002U1-Nj for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 06:23:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUfqw-0002TM-CX for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 06:23:34 -0500 Original-Received: from [199.232.76.173] (port=59819 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUfqw-0002TG-5V for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 06:23:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34187) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUfqv-0001yn-L5 for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 06:23:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14BNVFj022966; Wed, 4 Feb 2009 03:23:31 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n14BA4up019501; Wed, 4 Feb 2009 03:10:04 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2092 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24927 Archived-At: This is a multi-part message in MIME format... ------------=_1233745804-19389-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 5 Feb 2009 00:03:01 +1300 with message-id <18825.30181.243954.921791@kahikatea.snap.net.nz> and subject line Re: bug#2092: 23.0.60; vc-svn-diff has caused the Emacs bug report #2092, regarding 23.0.60; vc-svn-diff to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2092: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2092 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1233745804-19389-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 28 Jan 2009 07:05:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0S75LAn030628 for ; Tue, 27 Jan 2009 23:05:22 -0800 Received: from mail.gnu.org ([199.232.76.166]:60245 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LS4Sc-0006no-1b for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:03:42 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LS4U8-0007Rw-HU for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:19 -0500 Received: from viper.snap.net.nz ([202.37.101.23]:50958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LS4U8-0007R5-47 for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:16 -0500 Received: from kahikatea.snap.net.nz (unknown [123.255.31.95]) by viper.snap.net.nz (Postfix) with ESMTP id 0DAD73DA8C9 for ; Wed, 28 Jan 2009 19:35:46 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 74C018FC6D; Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) From: Nick Roberts To: emacs-pretest-bug@gnu.org Subject: 23.0.60; vc-svn-diff Message-Id: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Date: Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 vc-svn-diff fails when oldvers equals (vc-working-revision f). In that case "svn diff" executes with no -r argument and only gives a diff if the file is locally modified. To see this bug, do vc-print-log on a file under Subversion control that needs an update (newer revisions have been committed by someone else). Place the cursor over the revision after (in time) the working-revision (the revison with the number in the modeline) and press d (log-viw-diff). I think this clause needs to be removed: (and oldvers files (catch 'no (dolist (f files) (or (equal oldvers (vc-working-revision f)) (throw 'no nil))) t) ;; Use nil rather than the current revision because svn handles ;; it better (i.e. locally). Note that if _any_ of the files ;; has a different revision, we fetch the lot, which is ;; obviously sub-optimal. (setq oldvers nil)) I don't see how it could ever work (please note that I'm not saying that it could never work just that I don't see how it could). -- Nick http://www.inet.net.nz/~nickrob ------------=_1233745804-19389-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2092-done) by emacsbugs.donarmstrong.com; 4 Feb 2009 11:03:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from viper.snap.net.nz (viper.snap.net.nz [202.37.101.23]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14B3A9s017418 for <2092-done@emacsbugs.donarmstrong.com>; Wed, 4 Feb 2009 03:03:11 -0800 Received: from kahikatea.snap.net.nz (113.29.255.123.dynamic.snap.net.nz [123.255.29.113]) by viper.snap.net.nz (Postfix) with ESMTP id 628F73D9F9A; Thu, 5 Feb 2009 00:03:04 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 7759D8FC6D; Thu, 5 Feb 2009 00:03:02 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18825.30181.243954.921791@kahikatea.snap.net.nz> Date: Thu, 5 Feb 2009 00:03:01 +1300 To: Stefan Monnier Cc: 2092-done@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org Subject: Re: bug#2092: 23.0.60; vc-svn-diff In-Reply-To: References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.3.1 > > vc-svn-diff fails when oldvers equals (vc-working-revision f). > > In that case "svn diff" executes with no -r argument and only gives > > a diff if the file is locally modified. > > That's the right behavior when newvers is nil, isn't it? > > > I don't see how it could ever work (please note that I'm not saying that > > it could never work just that I don't see how it could). > > I think it was written assuming (incorrectly) that "newvers == nil". > Is the bug fixed if you add (null newvers) to the conjunction? > > > Stefan > > > PS: I see you've already removed this code, but I remember we added > specifically upon request from some users, so it would be better to fix > it than to remove it. OK, I've looked through the archives. I find it odd because: 1) I think that svn should be able to work out whether it can handle a request locally (a bug in svn?). 2) If you do "C-x v =" there is no problem. 3) I can only see a problem with "C-u C-x v =" with the default values which is eqivalent to 2). So it looks very much like a corner case. Anyway I've done as you say. -- Nick http://www.inet.net.nz/~nickrob ------------=_1233745804-19389-0--