From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2068: marked as done (23.0.60; dired-get-filename includes `*' for executable in name) Date: Wed, 28 Jan 2009 19:15:03 +0000 Message-ID: References: <007601c97f82$e5b0b910$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1233170103-19878-0" X-Trace: ger.gmane.org 1233170632 13523 80.91.229.12 (28 Jan 2009 19:23:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2009 19:23:52 +0000 (UTC) To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 28 20:25:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LSG20-0003jB-Se for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2009 20:25:01 +0100 Original-Received: from localhost ([127.0.0.1]:42978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSG0i-0002gN-7a for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2009 14:23:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSG0d-0002dS-UW for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 14:23:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSG0c-0002bm-Vg for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 14:23:35 -0500 Original-Received: from [199.232.76.173] (port=49612 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSG0c-0002bZ-Se for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2009 14:23:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57128) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LSG0a-0000J7-4I; Wed, 28 Jan 2009 14:23:32 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0SJNTxS022220; Wed, 28 Jan 2009 11:23:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0SJF3nB019901; Wed, 28 Jan 2009 11:15:03 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2068 X-Emacs-PR-Package: emacs,w32 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24689 Archived-At: This is a multi-part message in MIME format... ------------=_1233170103-19878-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 28 Jan 2009 21:07:35 +0200 with message-id and subject line Re: bug#2068: 23.0.60; dired-get-filename includes `*' for= executable in name has caused the Emacs bug report #2068, regarding 23.0.60; dired-get-filename includes `*' for executable in name to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2068: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2068 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1233170103-19878-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 26 Jan 2009 17:45:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0QHjlVq008488 for ; Mon, 26 Jan 2009 09:45:48 -0800 Received: from mx10.gnu.org ([199.232.76.166]:57321) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LRVVK-0002z2-GJ for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:44:10 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LRVWr-0001nZ-Ia for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:45:46 -0500 Received: from mx20.gnu.org ([199.232.41.8]:52725) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRVM3-0007bN-Ha for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:34:35 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRLMV-0001xb-Ea for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 01:54:23 -0500 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0Q6rEM4024995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Jan 2009 06:53:15 GMT Received: from acsmt704.oracle.com (acsmt704.oracle.com [141.146.40.82]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0Q6rn1X016309 for ; Mon, 26 Jan 2009 06:53:50 GMT Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Jan 2009 06:53:47 +0000 From: "Drew Adams" To: Subject: 23.0.60; dired-get-filename includes `*' for executable in name Date: Sun, 25 Jan 2009 22:54:12 -0800 Message-ID: <007601c97f82$e5b0b910$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acl/guUhqbi56Ot4SP6/Pfz3TI85vg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt704.oracle.com [141.146.40.82] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010206.497D5DFD.0063:SCFSTAT928724,ss=1,fgs=0 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. emacs -Q Create a file named `grep.exe' in some directory. The file content is unimportant. Use `C-u C-x d' to visit the directory, and specify `-alF' as the listing switches. Put the cursor on the line of the file named `grep.exe', which is displayed as `grep.exe*' to show that it is executable. M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" That is, the display artifact `*' is included as part of the file name. This is also a bug in Emacs 22.3. It is a regression from Emacs 21.3.1. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2009-01-04 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1233170103-19878-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2068-done) by emacsbugs.donarmstrong.com; 28 Jan 2009 19:07:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout2.012.net.il (mtaout2.012.net.il [84.95.2.4]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0SJ7it1018648 for <2068-done@emacsbugs.donarmstrong.com>; Wed, 28 Jan 2009 11:07:46 -0800 Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KE700E003IB5900@i_mtaout2.012.net.il> for 2068-done@emacsbugs.donarmstrong.com; Wed, 28 Jan 2009 21:07:56 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.255.234]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KE70044X3T7WN30@i_mtaout2.012.net.il>; Wed, 28 Jan 2009 21:07:56 +0200 (IST) Date: Wed, 28 Jan 2009 21:07:35 +0200 From: Eli Zaretskii Subject: Re: bug#2068: 23.0.60; dired-get-filename includes `*' for executable in name In-reply-to: <4980644C.6070905@gnu.org> X-012-Sender: halo1@inter.net.il To: Jason Rumney , 2068-done@emacsbugs.donarmstrong.com Cc: cyd@stupidchicken.com, Drew Adams Reply-to: Eli Zaretskii Message-id: References: <87r62owlec.fsf@cyd.mit.edu> <4980644C.6070905@gnu.org> > From: "Drew Adams" > Date: Tue, 27 Jan 2009 12:43:25 -0800 > Cc: > > > > emacs -Q > > > > > > Create a file named `grep.exe' in some directory. > > > > > > Use `C-u C-x d' to visit the directory, and specify `-alF' as the > > > listing switches. > > > > > > Put the cursor on the line of the file named `grep.exe', which is > > > displayed as `grep.exe*' to show that it is executable. > > > > > M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" > > > > Can't reproduce this. If this bug exists, it's probably Windows-only. > > Yes, I pretty much figured it was Windows-only. ls-lisp.el was putting the `dired-filename' property incorrectly when the "-F" switch was used. Fixed as below. If you want to try this without rebuilding Emacs, you will need to issue 2 commands, after byte-compiling the patched ls-lisp.el: M-x load-library RET files RET M-x load-library RET ls-lisp RET IOW, files.elc needs to be loaded before ls-lisp, because the latter redefines some functions in the former, and redefining them again will give you trouble. 2009-01-28 Eli Zaretskii * ls-lisp.el (ls-lisp-classify): Propertize file name before concatenating the type indicating character. (ls-lisp-format): Don't propertize file-name only if ls-lisp-classify already did. Index: lisp/ls-lisp.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/ls-lisp.el,v retrieving revision 1.80 retrieving revision 1.81 diff -u -r1.80 -r1.81 --- lisp/ls-lisp.el 5 Jan 2009 03:19:31 -0000 1.80 +++ lisp/ls-lisp.el 28 Jan 2009 19:01:42 -0000 1.81 @@ -531,13 +531,17 @@ (type (cadr filedata))) (cond (type (cons - (concat file-name (if (eq type t) "/" "@")) + (concat (propertize file-name 'dired-filename t) + (if (eq type t) "/" "@")) (cdr filedata))) ((string-match "x" (nth 9 filedata)) (cons - (concat file-name "*") + (concat (propertize file-name 'dired-filename t) "*") (cdr filedata))) - (t filedata)))) + (t + (cons + (propertize file-name 'dired-filename t) + (cdr filedata)))))) (defun ls-lisp-extension (filename) "Return extension of FILENAME (ignoring any version extension) @@ -632,7 +636,9 @@ " " (ls-lisp-format-time file-attr time-index now) " " - (propertize file-name 'dired-filename t) + (if (not (memq ?F switches)) ; ls-lisp-classify already did that + (propertize file-name 'dired-filename t) + file-name) (if (stringp file-type) ; is a symbolic link (concat " -> " file-type)) "\n" ------------=_1233170103-19878-0--