unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)
To: Chong Yidong <cyd@stupidchicken.com>
Subject: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart)
Date: Wed, 14 Jan 2009 20:55:04 +0000	[thread overview]
Message-ID: <handler.1899.D1899.123196607523998.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: uiqoinjm8.fsf@WDFD00185931A.sap.corp

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Your message dated Wed, 14 Jan 2009 15:48:04 -0500
with message-id <87fxjlvcl7.fsf@cyd.mit.edu>
and subject line Re: url-cookie-retrieve is not prepared for missing localpart
has caused the Emacs bug report #1899,
regarding url-cookie-retrieve is not prepared for missing localpart
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1899: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1899
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2741 bytes --]

From: Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE>
To: bug-gnu-emacs@gnu.org
Subject: url-cookie-retrieve is not prepared for missing localpart
Date: Wed, 14 Jan 2009 13:43:27 +0100 ()
Message-ID: <uiqoinjm8.fsf@WDFD00185931A.sap.corp>

In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'


the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is
not prepared for the case that the parameter localpart could be nil:
(regexp-quote nil) is an error. This is especially problematic since
the corresponding function for setting cookies, url-cookie-store,
defines the parameter localpart as optional.

Test example:
(require 'url-cookie)
(url-cookie-store "test" "42" nil "www.gnu.org")
followed by
(url-cookie-retrieve "www.gnu.org" nil)

-- 
Klaus Straubinger




[-- Attachment #3: Type: message/rfc822, Size: 1441 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE>
Cc: 1899-done@emacsbugs.donarmstrong.com
Subject: Re: url-cookie-retrieve is not prepared for missing localpart
Date: Wed, 14 Jan 2009 15:48:04 -0500
Message-ID: <87fxjlvcl7.fsf@cyd.mit.edu>

> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el)
> is not prepared for the case that the parameter localpart could be
> nil: (regexp-quote nil) is an error. This is especially problematic
> since the corresponding function for setting cookies,
> url-cookie-store, defines the parameter localpart as optional.

I've checked in a fix.  Thanks.


  reply	other threads:[~2009-01-14 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87fxjlvcl7.fsf@cyd.mit.edu>
2009-01-14 12:43 ` bug#1899: url-cookie-retrieve is not prepared for missing localpart Klaus Straubinger
2009-01-14 20:55   ` Emacs bug Tracking System [this message]
     [not found]   ` <mailman.4868.1231967014.26697.bug-gnu-emacs@gnu.org>
2009-01-15  8:44     ` bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) Klaus Straubinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=handler.1899.D1899.123196607523998.ackdone@emacsbugs.donarmstrong.com \
    --to=owner@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).