From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1754: marked as done (23.0.60; tool-bar is shown with tool-bar-mode off) Date: Sat, 10 Jan 2009 10:20:03 +0000 Message-ID: References: <496873E5.9080601@gmx.at> <005301c96b95$547ae890$c2b22382@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1231582803-11407-0" X-Trace: ger.gmane.org 1231583050 28243 80.91.229.12 (10 Jan 2009 10:24:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Jan 2009 10:24:10 +0000 (UTC) To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 10 11:25:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LLb1r-0001FV-Mn for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jan 2009 11:25:20 +0100 Original-Received: from localhost ([127.0.0.1]:36870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLb0b-00061Z-Hi for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jan 2009 05:24:01 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLb09-0005sO-F5 for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2009 05:23:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLb07-0005rz-8b for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2009 05:23:31 -0500 Original-Received: from [199.232.76.173] (port=47377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLb06-0005rv-Sc for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2009 05:23:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51477) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLb06-0004ig-B5 for bug-gnu-emacs@gnu.org; Sat, 10 Jan 2009 05:23:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0AANObR012594; Sat, 10 Jan 2009 02:23:25 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0AAK3UN011428; Sat, 10 Jan 2009 02:20:03 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 1754 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23963 Archived-At: This is a multi-part message in MIME format... ------------=_1231582803-11407-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 10 Jan 2009 11:09:41 +0100 with message-id <496873E5.9080601@gmx.at> and subject line Re: bug#1754: 23.0.60; tool-bar is shown with tool-bar-mod= e off has caused the Emacs bug report #1754, regarding 23.0.60; tool-bar is shown with tool-bar-mode off to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 1754: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1754 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1231582803-11407-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 31 Dec 2008 22:15:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=FVGT_m_MULTI_ODD autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBVMFrtb009803 for ; Wed, 31 Dec 2008 14:15:54 -0800 Received: from mx10.gnu.org ([199.232.76.166]:54840) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LI9Ky-0004Y4-I0 for emacs-pretest-bug@gnu.org; Wed, 31 Dec 2008 17:14:48 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LI9Ly-0004Rg-VH for emacs-pretest-bug@gnu.org; Wed, 31 Dec 2008 17:15:52 -0500 Received: from rcsinet13.oracle.com ([148.87.113.125]:39745 helo=rgminet13.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LI9Ly-0004RW-7s for emacs-pretest-bug@gnu.org; Wed, 31 Dec 2008 17:15:50 -0500 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mBVMGOpe019273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Dec 2008 22:16:25 GMT Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mBVM9iHh029119 for ; Wed, 31 Dec 2008 22:09:45 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 31 Dec 2008 22:15:43 +0000 From: "Drew Adams" To: Subject: 23.0.60; tool-bar is shown with tool-bar-mode off Date: Wed, 31 Dec 2008 14:15:46 -0800 Message-ID: <005301c96b95$547ae890$c2b22382@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AclrlVP3DPuJbLvSQfazuoG2vnyNvg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.495BEF11.0124:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) This is a regression wrt Emacs 20, 21, and 22. 1. Put this code in a file named `bug-tool-bar.el': (tool-bar-mode -1) (defvar my-minibuffer-frame nil "") (defun foo () "" (interactive) (setq default-frame-alist (append (list (cons 'tool-bar-lines 1)) default-frame-alist)) (setq pop-up-frames t pop-up-frame-alist (append default-frame-alist pop-up-frame-alist)) (setq minibuffer-frame-alist (append (list (cons 'minibuffer 'only)) minibuffer-frame-alist)) (if my-minibuffer-frame (modify-frame-parameters my-minibuffer-frame (list (cons 'minibuffer 'only))) (setq my-minibuffer-frame (let ((after-make-frame-functions nil)) (make-frame (list (cons 'minibuffer 'only))))))) It doesn't matter where the (tool-bar-mode -1) is, and you could alternatively leave it out altogether and then do `M-x tool-bar-mode' to turn it off (step 3). 2. Start Emacs this way: runemacs.exe -Q --debug-init -l "bug-tool-bar.el" -f "foo" You get one frame with buffer *scratch* and a standalone minibuffer frame. Neither frame has a tool bar. However, `tool-bar-mode' is t - it should be nil. You can see this by typing `tool-bar-mode' in buffer *scratch* and using `C-x C-e'. 3. Optional step: `M-x tool-bar-mode'. This turns off tool-bar mode, though it should already have been off because of the code in `bug-tool-bar.el'. 4. Do `C-x 4 f some-file.el'. The file is visited in a new frame, and the frame has a tool bar. And tool-bar mode is now on. And this is so regardless of whether you skip step 3. The mode should remain off, and no tool bar should be shown. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-12-30 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1231582803-11407-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1754-done) by emacsbugs.donarmstrong.com; 10 Jan 2009 10:10:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n0AAAW1N010125 for <1754-done@emacsbugs.donarmstrong.com>; Sat, 10 Jan 2009 02:10:34 -0800 Received: (qmail invoked by alias); 10 Jan 2009 10:10:27 -0000 Received: from 62-47-47-9.adsl.highway.telekom.at (EHLO [62.47.47.9]) [62.47.47.9] by mail.gmx.net (mp070) with SMTP; 10 Jan 2009 11:10:27 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19jNJ5oTi1jcEd5esyir4l/VTBwUxFKt+JfV1bzTE OTWmAslej+Qg0G Message-ID: <496873E5.9080601@gmx.at> Date: Sat, 10 Jan 2009 11:09:41 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: 1754-done@emacsbugs.donarmstrong.com CC: Chong Yidong Subject: Re: bug#1754: 23.0.60; tool-bar is shown with tool-bar-mode off References: <005301c96b95$547ae890$c2b22382@us.oracle.com> <4967A75D.1080404@gmx.at> <87bpugjkmf.fsf@cyd.mit.edu> In-Reply-To: <87bpugjkmf.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.74 >> IMHO, we should either not call `modify-all-frames-parameters' in >> either case or call them in both cases as in the (attached) >> tool-bar.el patch I proposed earlier. > > Patch looks OK; go ahead and install if you like. Done. Not that I liked it, but I'd rather find out now whether asking for non-zero tool-bar-lines may cause problems on text-only terminals. martin ------------=_1231582803-11407-0--