From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1560: marked as done (23.0.60; Cannot use function as value of :height face attribute) Date: Thu, 01 Jan 2009 08:35:06 +0000 Message-ID: References: <87eiznv36w.fsf@cyd.mit.edu> <000401c95d4f$0bcb1d30$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1230798906-3496-0" X-Trace: ger.gmane.org 1230799430 22505 80.91.229.12 (1 Jan 2009 08:43:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Jan 2009 08:43:50 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 01 09:45:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LIJAp-00038i-PT for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jan 2009 09:45:00 +0100 Original-Received: from localhost ([127.0.0.1]:43764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIJ9b-00060m-06 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jan 2009 03:43:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LIJ9O-0005s3-7M for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 03:43:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LIJ9J-0005nP-EK for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 03:43:29 -0500 Original-Received: from [199.232.76.173] (port=57788 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIJ9J-0005n6-8X for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 03:43:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:58143) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LIJ9I-0004XR-Ho for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 03:43:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n018hMbg005751; Thu, 1 Jan 2009 00:43:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n018Z6Bd003633; Thu, 1 Jan 2009 00:35:06 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 1560 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23645 Archived-At: This is a multi-part message in MIME format... ------------=_1230798906-3496-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 01 Jan 2009 03:30:15 -0500 with message-id <87eiznv36w.fsf@cyd.mit.edu> and subject line Re: 23.0.60; Cannot use function as value of :height face = attribute has caused the Emacs bug report #1560, regarding 23.0.60; Cannot use function as value of :height face attribute to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 1560: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1560 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1230798906-3496-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.0000 Tokens: new, 26; hammy, 124; neutral, 90; spammy, 2. spammytokens:0.921-2--scale, 0.912-2--prove hammytokens:0.000-+--emacs, 0.000-+--23.0.60, 0.000-+--23060, 0.000-+--Emacs, 0.000-+--gnu X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Dec 2008 18:17:30 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBDIHRns011351 for ; Sat, 13 Dec 2008 10:17:28 -0800 Received: from mail.gnu.org ([199.232.76.166]:56843 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LBZ2k-0000lv-K8 for emacs-pretest-bug@gnu.org; Sat, 13 Dec 2008 13:16:46 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LBZ3M-0007WS-SF for emacs-pretest-bug@gnu.org; Sat, 13 Dec 2008 13:17:26 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:29571) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBZ3M-0007WM-G8 for emacs-pretest-bug@gnu.org; Sat, 13 Dec 2008 13:17:24 -0500 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mBDIGxwq018259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 13 Dec 2008 18:17:01 GMT Received: from acsmt706.oracle.com (acsmt706.oracle.com [141.146.40.84]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mBDIHRwR023712 for ; Sat, 13 Dec 2008 18:17:28 GMT Received: from dradamslap1 (/141.144.80.117) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 13 Dec 2008 10:17:17 -0800 From: "Drew Adams" To: Subject: 23.0.60; Cannot use function as value of :height face attribute Date: Sat, 13 Dec 2008 10:17:23 -0800 Message-ID: <000401c95d4f$0bcb1d30$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcldTwtkSdd3+MrpT6qNsF7r4Pfs+A== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt706.oracle.com [141.146.40.84] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4943FC2F.00BE:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q M-: (set-face-attribute 'default (selected-frame) :height (quote 1+)) gives this error: (error "Invalid face height" 1+) Emacs 22 gives the same error, BTW. But the Elisp manual, node Face Attributes says this: `:height' Either the font height, an integer in units of 1/10 point, a floating point number specifying the amount by which to scale the height of any underlying face, or a function, which is called with the old height (from the underlying face), and should return the new height. Am I misunderstanding the doc, or should you be able to use a function as the value of the :height attribute? What's more, if you do `M-x customize-face RET default', the Value Menu for attribute Height does not have an item for a function value. It has only `Height in 1/10 pt' and `Scale'. That suggests, but doesn't prove, that a function value is not allowed. And grepping the Elisp sources, I see no use of a function value for :height. Beyond this bug (or my misunderstanding), can we say more about the kind of function that would be needed? Is it supposed to treat each kind of :height value: integer, floating-point number, and function? The doc says the old height (passed to the function) is "from the underlying face", so I guess this means the actual face height, not the old value of :height. But which units are used for the actual face height? Are they too "units of 1/10 point"? In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-11-24 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1230798906-3496-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1560-done) by emacsbugs.donarmstrong.com; 1 Jan 2009 08:30:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n018UCFh002793 for <1560-done@emacsbugs.donarmstrong.com>; Thu, 1 Jan 2009 00:30:14 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id EFDBE57E211; Thu, 1 Jan 2009 03:30:15 -0500 (EST) From: Chong Yidong To: "Drew Adams" Cc: 1560-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; Cannot use function as value of :height face attribute Date: Thu, 01 Jan 2009 03:30:15 -0500 Message-ID: <87eiznv36w.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > M-: (set-face-attribute 'default (selected-frame) :height (quote 1+)) > > gives this error: (error "Invalid face height" 1+) > > But the Elisp manual, node Face Attributes says this: > > `:height' > Either the font height, an integer in units of 1/10 point, a > floating point number specifying the amount by which to scale the > height of any underlying face, or a function, which is called with > the old height (from the underlying face), and should return the > new height. The default face must always be absolute (i.e., an integer). I've clarified the manual. ------------=_1230798906-3496-0--