From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1414: marked as done (23.0.60; Middle mouse button does not work in Cocoa port) Date: Mon, 24 Nov 2008 20:25:09 -0800 Message-ID: References: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1227587109-1093-4" X-Trace: ger.gmane.org 1227587472 2226 80.91.229.12 (25 Nov 2008 04:31:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2008 04:31:12 +0000 (UTC) To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 25 05:32:15 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L4paw-0004Lr-8w for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2008 05:32:14 +0100 Original-Received: from localhost ([127.0.0.1]:45509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4pZm-0003SE-F0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Nov 2008 23:31:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4pZg-0003Pb-TR for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 23:30:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4pZf-0003OO-85 for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 23:30:55 -0500 Original-Received: from [199.232.76.173] (port=43467 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4pZf-0003OK-1Y for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 23:30:55 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37158) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L4pZe-0005IS-9z for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 23:30:54 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4UAsL002966; Mon, 24 Nov 2008 20:30:11 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mAP4P9ZX001492; Mon, 24 Nov 2008 20:25:09 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1414 X-Emacs-PR-Package: emacs,ns X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22656 Archived-At: This is a multi-part message in MIME format... ------------=_1227587109-1093-4 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 24 Nov 2008 23:14:41 -0500 with message-id <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net> and subject line #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug repo= rt logs has caused the Emacs bug report #1048, regarding 23.0.60; Middle mouse button does not work in Cocoa port to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1048: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1048 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1227587109-1093-4 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.8 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8, RCVD_IN_DNSWL_MED,SUBJECT_FUZZY_TION autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Nov 2008 04:07:11 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAO4776r006715 for ; Sun, 23 Nov 2008 20:07:09 -0800 Received: from mail.gnu.org ([199.232.76.166]:43292 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1L4Siq-0006mv-KA for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 23:06:52 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1L4RNs-0004b8-PZ for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 21:41:17 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:3513) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4DZX-0004xG-6H for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 06:56:15 -0500 Received: by fg-out-1718.google.com with SMTP id l26so1576968fgb.30 for ; Sun, 23 Nov 2008 03:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:to:message-id :content-type:from:subject:date:x-mailer; bh=cdDLJX8o71HZq+4ZADCXh2ceNKaygIwT0oBh4cw/zj4=; b=KFFOpC/QY7rn7c6VLAAX3CLg3if8SQgLhlA5MDTmNAJ/lSEUvzow8a61l4tWPYUA4w 5ZprSP88NvwFwiOzOhblyGpZFRouUT8AMC70HM61VWGbgTYkN/3lCRrkmjwFbkQtjDUW WGZtzhztlogrDJVTo6nJbAUPGdCshiUd1lIyk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:to:message-id:content-type:from:subject:date:x-mailer; b=jyTBtlLNL/g6o1QdYzSEW8OHCFhRIPn6cfXWzmGG8vVv6yt624U8qHfpdZChnQmXZp AitV8fdXTVYcyExRWOseDO9k5TGyTznvzSqbAjV7hRAeC15Zd8/XvLKX0/kI8sGB9Nrb d7Xm8oF/7RWOk+EHlLQagIloSipCFhx0Qdv7s= Received: by 10.103.171.20 with SMTP id y20mr720189muo.122.1227441373227; Sun, 23 Nov 2008 03:56:13 -0800 (PST) Received: from ?212.144.125.215? (dialin-212-144-125-215.pools.arcor-ip.net [212.144.125.215]) by mx.google.com with ESMTPS id j10sm547049muh.57.2008.11.23.03.56.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 23 Nov 2008 03:56:12 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) To: emacs-pretest-bug@gnu.org Message-Id: Content-Type: multipart/mixed; boundary=Apple-Mail-1-26061598 From: Wolfgang Lux Subject: 23.0.60; Middle mouse button does not work in Cocoa port Date: Sun, 23 Nov 2008 12:56:04 +0100 X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-1-26061598 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Clicking the middle mouse button does not have an effect. The attached patch fixes this issue. In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple- appkit-824.48) of 2008-11-21 on Onyx.local Windowing system distributor `Apple', version 97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56 configured using `configure '--with-ns'' --Apple-Mail-1-26061598 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name=nsterm.patch Content-Disposition: attachment; filename=nsterm.patch Index: src/nsterm.m =================================================================== RCS file: /sources/emacs/emacs/src/nsterm.m,v retrieving revision 1.35 diff -u -r1.35 nsterm.m --- src/nsterm.m 15 Nov 2008 05:20:49 -0000 1.35 +++ src/nsterm.m 23 Nov 2008 11:54:29 -0000 @@ -260,9 +260,12 @@ #define EV_UDMODIFIERS(e) \ ((([e type] == NSLeftMouseDown) ? down_modifier : 0) \ | (([e type] == NSRightMouseDown) ? down_modifier : 0) \ + | (([e type] == NSOtherMouseDown) ? down_modifier : 0) \ | (([e type] == NSLeftMouseDragged) ? down_modifier : 0) \ | (([e type] == NSRightMouseDragged) ? down_modifier : 0) \ + | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \ | (([e type] == NSLeftMouseUp) ? up_modifier : 0) \ + | (([e type] == NSOtherMouseUp) ? up_modifier : 0) \ | (([e type] == NSRightMouseUp) ? up_modifier : 0)) #define EV_BUTTON(e) \ @@ -4725,6 +4728,13 @@ } +- (void)otherMouseDown: (NSEvent *)theEvent +{ + NSTRACE (otherMouseDown); + [self mouseDown: theEvent]; +} + + - (void)rightMouseUp: (NSEvent *)theEvent { NSTRACE (rightMouseUp); @@ -4732,6 +4742,13 @@ } +- (void)otherMouseUp: (NSEvent *)theEvent +{ + NSTRACE (otherMouseUp); + [self mouseDown: theEvent]; +} + + - (void) scrollWheel: (NSEvent *)theEvent { NSTRACE (scrollWheel); @@ -4800,6 +4817,13 @@ } +- (void)otherMouseDragged: (NSEvent *)e +{ + NSTRACE (otherMouseDragged); + [self mouseMoved: e]; +} + + - (BOOL)windowShouldClose: (id)sender { NSEvent *e =[[self window] currentEvent]; --Apple-Mail-1-26061598-- ------------=_1227587109-1093-4 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=BAYES_20,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1048-done) by emacsbugs.donarmstrong.com; 25 Nov 2008 04:17:55 +0000 Received: from theta.genwebserver.com (theta.genwebserver.com [72.18.148.146]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4HqsR032104 for <1048-done@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 20:17:53 -0800 Received: from [72.169.150.82] (helo=[10.0.1.198]) by theta.genwebserver.com with esmtpa (Exim 4.69) (envelope-from ) id 1L4pN3-0006t7-4F for 1048-done@emacsbugs.donarmstrong.com; Mon, 24 Nov 2008 21:17:55 -0700 Message-Id: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net> From: Adrian Robert To: 1048-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs Date: Mon, 24 Nov 2008 23:14:41 -0500 X-Mailer: Apple Mail (2.929.2) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - theta.genwebserver.com X-AntiAbuse: Original Domain - emacsbugs.donarmstrong.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - interstitiality.net Closing, applied patch from Wolfgang Lux. ------------=_1227587109-1093-4--