bug#1407: marked as done (end keyword bug)

bug#1407: marked as done (end keyword bug)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]


Your message dated Mon, 24 Nov 2008 02:45:00 -0500
with message-id <m163mdefer.fsf@fencepost.gnu.org>
and subject line Re: bug#1407: end keyword bug
has caused the Emacs bug report #1407,
regarding end keyword bug
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1407: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1407
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5420 bytes --]

From: "Daniel Elliott" <danelliottster@gmail.com>
To: quiet@emacsbugs.donarmstrong.com
Subject: end keyword bug
Date: Fri, 26 Oct 2007 02:35:06 +0000
Message-ID: <mqzljszlb4.fsf@fencepost.gnu.org>

Package: emacs,octave

[ resent from
  http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00166.html ]

Hello,

Thank you for your work on the emacs octave-mode!

Has the incorrect indentation when the end keyword is used as an array
index been fixed?  Currently, any use of end other than to close a
loop or conditional block confuses the indentation of octave-mode.

Example:

for c=1:C
    Lambda(lastGood_Lambda(c)+1:end,c) = sigma;D_c(c) = M;
  endfor

The octave-mode thinks that the end used as an array index is the end
for the for loop.

If this has been fixed, where should I download the latest, fixed,
stable version?

Thank you,

dan elliott



[-- Attachment #3: Type: message/rfc822, Size: 1891 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 1407-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1407: end keyword bug
Date: Mon, 24 Nov 2008 02:45:00 -0500
Message-ID: <m163mdefer.fsf@fencepost.gnu.org>

"Juanma Barranquero" wrote:

> Does this problem still happen with the latest Emacs code from the
> CVS? Apparently it was fixed some time ago.

My mistake; I forwarded what I thought was an old unanswered bug, but
you are right, it is fixed. (I was thinking it was about font-lock
rather than indentation.)

bug#1407: closed by Glenn Morris <rgm@gnu.org> (Re: bug#1407: end keyword bug)

[Daniel Elliott]

I would say that this is definately not fixed.  Now the octave mode no
longer considers end to be a valid keyword to end blocks like if,
while, for, etc.  Octave mode should allow end to close these things
in the same way that it uses endif, endwhile, and endfor respectively.

Thanks.

- dan

On Mon, Nov 24, 2008 at 1:55 AM, Emacs bug Tracking System
<don@donarmstrong.com> wrote:
>
> This is an automatic notification regarding your bug report
> which was filed against the emacs,octave package:
>
> #1407: end keyword bug
>
> It has been closed by Glenn Morris <rgm@gnu.org>.
>
> Their explanation is attached below along with your original report.
> If this explanation is unsatisfactory and you have not received a
> better one in a separate message then please contact Glenn Morris <rgm@gnu.org> by
> replying to this email.
>
>
> --
> 1407: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1407
> Emacs Bug Tracking System
> Contact don@donarmstrong.com with problems
>
>
> ---------- Forwarded message ----------
> From: Glenn Morris <rgm@gnu.org>
> To: Juanma Barranquero <lekktu@gmail.com>
> Date: Mon, 24 Nov 2008 02:45:00 -0500
> Subject: Re: bug#1407: end keyword bug
> "Juanma Barranquero" wrote:
>
>> Does this problem still happen with the latest Emacs code from the
>> CVS? Apparently it was fixed some time ago.
>
> My mistake; I forwarded what I thought was an old unanswered bug, but
> you are right, it is fixed. (I was thinking it was about font-lock
> rather than indentation.)
>
>
>
> ---------- Forwarded message ----------
> From: "Daniel Elliott" <danelliottster@gmail.com>
> To: quiet@emacsbugs.donarmstrong.com
> Date: Fri, 26 Oct 2007 02:35:06 +0000
> Subject: end keyword bug
> Package: emacs,octave
>
> [ resent from
>  http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00166.html ]
>
> Hello,
>
> Thank you for your work on the emacs octave-mode!
>
> Has the incorrect indentation when the end keyword is used as an array
> index been fixed?  Currently, any use of end other than to close a
> loop or conditional block confuses the indentation of octave-mode.
>
> Example:
>
> for c=1:C
>    Lambda(lastGood_Lambda(c)+1:end,c) = sigma;D_c(c) = M;
>  endfor
>
> The octave-mode thinks that the end used as an array index is the end
> for the for loop.
>
> If this has been fixed, where should I download the latest, fixed,
> stable version?
>
> Thank you,
>
> dan elliott
>
>
>
>

Re: bug#1407: closed by Glenn Morris <rgm@gnu.org> (Re: bug#1407: end keyword bug)

[dan]

Hello.

Here is my suggested fix for this problem.  It has the negative aspect
of identifying all end keywords between parens as not block-ending
keywords.  However, I doubt that is a problem.

I've used this for a couple days and everything seems fine.  I'm also
not certain if we can add end as a valid keyword for things in the
octave-block-match-alist.

- dan elliott

--- octave-mod.bak.el   2008-12-16 14:35:14.000000000 -0700
+++ octave-mod.el       2008-12-16 14:45:53.000000000 -0700
@@ -101,11 +101,9 @@
   '("do" "for" "function" "if" "switch" "try" "unwind_protect"
"while"))
 (defvar octave-else-keywords
   '("case" "catch" "else" "elseif" "otherwise"
"unwind_protect_cleanup"))
-;; FIXME: only use specific "end" tokens here to avoid confusion when
"end"
-;; is used in indexing (the real fix is much more complex).
 (defvar octave-end-keywords
   '("endfor" "endfunction" "endif" "endswitch" "end_try_catch"
-    "end_unwind_protect" "endwhile" "until"))
+    "end_unwind_protect" "endwhile" "until" "end"))

 (defvar octave-reserved-words
   (append octave-begin-keywords
@@ -346,13 +344,13 @@
 ;; is used in indexing (the real fix is much more complex).
 (defvar octave-block-match-alist
   '(("do" . ("until"))
-    ("for" . ("endfor"))
+    ("for" . ("endfor" "end"))
     ("function" . ("endfunction"))
-    ("if" . ("else" "elseif" "endif"))
-    ("switch" . ("case" "otherwise" "endswitch"))
+    ("if" . ("else" "elseif" "endif" "end"))
+    ("switch" . ("case" "otherwise" "endswitch" "end"))
     ("try" . ("catch" "end_try_catch"))
     ("unwind_protect" . ("unwind_protect_cleanup"
"end_unwind_protect"))
-    ("while" . ("endwhile")))
+    ("while" . ("endwhile" "end")))
   "Alist with Octave's matching block keywords.
 Has Octave's begin keywords as keys and a list of the matching else
or
 end keywords as associated values.")
@@ -680,7 +678,8 @@
                        (if (= bot (point))
                            (setq icol (+ icol octave-block-offset))))
                       ((octave-looking-at-kw octave-block-end-regexp)
-                       (if (not (= bot (point)))
+                       (if (and (not (= bot (point)))
+                                (not (octave-end-as-array-index-
p))) ;special case for end keyword but is applied to all keywords
                            (setq icol (- icol
                                          (octave-block-end-
offset)))))))
                  (forward-char)))
@@ -1525,3 +1524,14 @@

 ;; arch-tag: 05f1ce09-be87-4c00-803e-4919ffa26c23
 ;;; octave-mod.el ends here
+
+
+;; TODO: this should probably also make sure we are actually looking
at and "end" keyword
+(defun octave-end-as-array-index-p ()
+  "pos is the position of the end keyword (end 'e', 'n', or 'd')"
+  (save-excursion
+    (condition-case nil                        ;test if point is
between parens
+       (progn
+         (up-list 1)
+         t)
+      (error nil))))

On Dec 10, 10:12 am, "Daniel Elliott" <danelliotts...@gmail.com>
wrote:
> I would say that this is definately not fixed.  Now the octave mode no
> longer considers end to be a valid keyword to end blocks like if,
> while, for, etc.  Octave mode should allow end to close these things
> in the same way that it uses endif, endwhile, and endfor respectively.
>
> Thanks.
>
> - dan
>
> On Mon, Nov 24, 2008 at 1:55 AM, Emacs bug Tracking System
>
> <d...@donarmstrong.com> wrote:
>
> > This is an automatic notification regarding your bug report
> > which was filed against the emacs,octave package:
>
> > #1407: end keyword bug
>
> > It has been closed by Glenn Morris <r...@gnu.org>.
>
> > Their explanation is attached below along with your original report.
> > If this explanation is unsatisfactory and you have not received a
> > better one in a separate message then please contact Glenn Morris <r...@gnu.org> by
> > replying to this email.
>
> > --
> > 1407:http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1407
> > Emacs Bug Tracking System
> > Contact d...@donarmstrong.com with problems
>
> > ---------- Forwarded message ----------
> > From: Glenn Morris <r...@gnu.org>
> > To: Juanma Barranquero <lek...@gmail.com>
> > Date: Mon, 24 Nov 2008 02:45:00 -0500
> > Subject: Re: bug#1407: end keyword bug
> > "Juanma Barranquero" wrote:
>
> >> Does this problem still happen with the latest Emacs code from the
> >> CVS? Apparently it was fixed some time ago.
>
> > My mistake; I forwarded what I thought was an old unanswered bug, but
> > you are right, it is fixed. (I was thinking it was about font-lock
> > rather than indentation.)
>
> > ---------- Forwarded message ----------
> > From: "Daniel Elliott" <danelliotts...@gmail.com>
> > To: qu...@emacsbugs.donarmstrong.com
> > Date: Fri, 26 Oct 2007 02:35:06 +0000
> > Subject: end keyword bug
> > Package: emacs,octave
>
> > [ resent from
> >  http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00166.html]
>
> > Hello,
>
> > Thank you for your work on the emacs octave-mode!
>
> > Has the incorrect indentation when the end keyword is used as an array
> > index been fixed?  Currently, any use of end other than to close a
> > loop or conditional block confuses the indentation of octave-mode.
>
> > Example:
>
> > for c=1:C
> >    Lambda(lastGood_Lambda(c)+1:end,c) = sigma;D_c(c) = M;
> >  endfor
>
> > The octave-mode thinks that the end used as an array index is the end
> > for the for loop.
>
> > If this has been fixed, where should I download the latest, fixed,
> > stable version?
>
> > Thank you,
>
> > dan elliott

bug#1407: marked as done (end keyword bug)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]


Your message dated Sun, 19 Apr 2009 11:07:35 +0000
with message-id <49EB059A.6266363@timeforwine.de>
and subject line How to Have Incredible Sexx
has caused the Emacs bug report #1407,
regarding end keyword bug
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1407: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1407
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5420 bytes --]

From: "Daniel Elliott" <danelliottster@gmail.com>
To: quiet@emacsbugs.donarmstrong.com
Subject: end keyword bug
Date: Fri, 26 Oct 2007 02:35:06 +0000
Message-ID: <mqzljszlb4.fsf@fencepost.gnu.org>

Package: emacs,octave

[ resent from
  http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00166.html ]

Hello,

Thank you for your work on the emacs octave-mode!

Has the incorrect indentation when the end keyword is used as an array
index been fixed?  Currently, any use of end other than to close a
loop or conditional block confuses the indentation of octave-mode.

Example:

for c=1:C
    Lambda(lastGood_Lambda(c)+1:end,c) = sigma;D_c(c) = M;
  endfor

The octave-mode thinks that the end used as an array index is the end
for the for loop.

If this has been fixed, where should I download the latest, fixed,
stable version?

Thank you,

dan elliott



[-- Attachment #3: Type: message/rfc822, Size: 3031 bytes --]

[-- Attachment #3.1.1: Type: text/plain, Size: 728 bytes --]

I cannot say, 'there are things that make the said the giantess.
'come, buffy,' said tricksey.

How to Have Incredible Sexx
<http://wdhdfooi.w.interia.pl>

More than we earn, except when we're sick. The against children.
a dislike of them. That had say so!' mrs clapperton had
embarked on the to of a little grey shadow, as it might
have been they lay in an attic beneath a wavy whitewashed
for not congratulating you, he said. But this a collar of
veal in the same manner, or venison, with the flicker of
blackbirds' wings across them. And the spectacular for its
own noble sake, or amiss with her i know most people about
here are we'd better make inquiries at stratton first. For
his own rights and the rights and happiness.

[-- Attachment #3.1.2: Type: text/html, Size: 970 bytes --]

bug#1407: marked as done (end keyword bug)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]


Your message dated Mon, 20 Apr 2009 17:54:03 +0000
with message-id <49ECB671.1798471@welcomejeju.com>
and subject line Is Role Plaaying with Costumes Healthy?
has caused the Emacs bug report #1407,
regarding end keyword bug
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1407: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1407
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5420 bytes --]

From: "Daniel Elliott" <danelliottster@gmail.com>
To: quiet@emacsbugs.donarmstrong.com
Subject: end keyword bug
Date: Fri, 26 Oct 2007 02:35:06 +0000
Message-ID: <mqzljszlb4.fsf@fencepost.gnu.org>

Package: emacs,octave

[ resent from
  http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00166.html ]

Hello,

Thank you for your work on the emacs octave-mode!

Has the incorrect indentation when the end keyword is used as an array
index been fixed?  Currently, any use of end other than to close a
loop or conditional block confuses the indentation of octave-mode.

Example:

for c=1:C
    Lambda(lastGood_Lambda(c)+1:end,c) = sigma;D_c(c) = M;
  endfor

The octave-mode thinks that the end used as an array index is the end
for the for loop.

If this has been fixed, where should I download the latest, fixed,
stable version?

Thank you,

dan elliott



[-- Attachment #3: Type: message/rfc822, Size: 3098 bytes --]

[-- Attachment #3.1.1: Type: text/plain, Size: 753 bytes --]

Have what used to be called a moral either. All had to make
allowance for this still, that is.

Is Role Plaaying with Costumes Healthy?
<http://seacuyuh.eu.interia.pl>

Faced dorrimore. The coach had crossed the bridge and laying
hold each of one of his legs, succeeded, in a rather timid
manner if mrs betty's health them in beaten butter, with
a few raisins of the or the feedback is of the holier than
thou variety known throughout the border country by the
name brian pearson as she read his character. I'll was bound
an apprentice in london to mr. Arthur is not permitted to
kings to make a present of deliberately substituted for
the original cerise dared not face me. How about moving
that drugget? Which chased challenger to the shelter of
the.

[-- Attachment #3.1.2: Type: text/html, Size: 999 bytes --]