From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1352: marked as done (23.0.60; isearch-success-function) Date: Sun, 16 Nov 2008 16:55:07 -0800 Message-ID: References: <87tza7kwmt.fsf@jurta.org> <005c01c9477b$6adb8290$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1226883307-20239-0" X-Trace: ger.gmane.org 1226884232 14534 80.91.229.12 (17 Nov 2008 01:10:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Nov 2008 01:10:32 +0000 (UTC) To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 17 02:11:32 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L1seH-0007Xu-Jc for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Nov 2008 02:11:30 +0100 Original-Received: from localhost ([127.0.0.1]:60746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L1sd9-00007b-1C for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Nov 2008 20:10:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L1sd4-00006s-9t for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2008 20:10:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L1sd3-00006f-R7 for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2008 20:10:14 -0500 Original-Received: from [199.232.76.173] (port=46145 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L1sd3-00006U-9K for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2008 20:10:13 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47334) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L1sd2-00025C-Mp for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2008 20:10:13 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAH1A8r7025036; Sun, 16 Nov 2008 17:10:09 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mAH0t72G020292; Sun, 16 Nov 2008 16:55:07 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1352 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22427 Archived-At: This is a multi-part message in MIME format... ------------=_1226883307-20239-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 17 Nov 2008 02:46:02 +0200 with message-id <87tza7kwmt.fsf@jurta.org> and subject line Re: bug#1352: 23.0.60; isearch-success-function has caused the Emacs bug report #1352, regarding 23.0.60; isearch-success-function to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1352: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1352 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1226883307-20239-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Nov 2008 23:39:35 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAFNdWbI027113 for ; Sat, 15 Nov 2008 15:39:33 -0800 Received: from mx10.gnu.org ([199.232.76.166]:60412) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1L1Ujf-0006Ni-Ig for emacs-pretest-bug@gnu.org; Sat, 15 Nov 2008 18:39:27 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1L1Uji-00020l-O6 for emacs-pretest-bug@gnu.org; Sat, 15 Nov 2008 18:39:31 -0500 Received: from rcsinet11.oracle.com ([148.87.113.123]:58834 helo=rgminet11.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L1Uji-00020d-DP for emacs-pretest-bug@gnu.org; Sat, 15 Nov 2008 18:39:30 -0500 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mAFNe1xT017678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 15 Nov 2008 23:40:02 GMT Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mAFNdb2u028824 for ; Sat, 15 Nov 2008 23:39:39 GMT Received: from dradamslap1 (/24.23.165.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 15 Nov 2008 15:39:20 -0800 From: "Drew Adams" To: Subject: 23.0.60; isearch-success-function Date: Sat, 15 Nov 2008 15:39:35 -0800 Message-ID: <005c01c9477b$6adb8290$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AclHe2qABZ8MZmFzR7ydpVVHRhHdtg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.491F5DAD.006E:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) The name of `isearch-success-function' seems wrong, if we believe the doc string. The doc string suggests that it is a predicate that filters the search hits that would otherwise be available. That's very general. If that's true, then the name should reflect this meaning - perhaps `isearch-predicate'. Similarly, the name of `isearch-success-function-default' should be something that suggests its very limited meaning: it filters search hits to those that are visible, unless invisible text too can be searched. It is a particular kind of search filter, and its name should reflect that particularity. Also, in `isearch-search', there is this: ;; Clear RETRY unless we matched some invisible text ;; and we aren't supposed to do that. (if (or (not isearch-success) (bobp) (eobp) (= (match-beginning 0) (match-end 0)) (funcall isearch-success-function (match-beginning 0) (match-end 0))) (setq retry nil))) The code here is general; it is not related to text visibility. So the comment is not general enough. It is a vestige that is appropriate now only when the value of `isearch-success-function' is `isearch-success-function-default'. The comment should instead say that we clear RETRY unless the search predicate says to skip this search hit. It seems like this is a partly finished enhancement to behavior that was originally only for searching invisible text. Seems like this was generalized to an arbitrary predicate that filters possible search hits - but the job seems only half done. The code presumably works in a general way, but the comments and symbol names are inappropriate. The comments and the variable and function names need to reflect the new behavior, and this behavior should be documented for users. Users should know how to take advantage of this feature, defining their own search predicates that filter the search hits that would normally be available, so that hits that dissatisfy the predicate are skipped. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-11-08 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1226883307-20239-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_LOW,RCVD_IN_NIX1 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1352-done) by emacsbugs.donarmstrong.com; 17 Nov 2008 00:47:12 +0000 Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAH0l9DN018789 for <1352-done@emacsbugs.donarmstrong.com>; Sun, 16 Nov 2008 16:47:10 -0800 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1L1sGi-0000Xc-3E; Mon, 17 Nov 2008 02:47:08 +0200 From: Juri Linkov To: Stefan Monnier Cc: 1352-done@emacsbugs.donarmstrong.com, Drew Adams Subject: Re: bug#1352: 23.0.60; isearch-success-function Organization: JURTA References: <005c01c9477b$6adb8290$0200a8c0@us.oracle.com> <87fxlrid7i.fsf@jurta.org> Date: Mon, 17 Nov 2008 02:46:02 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 16 Nov 2008 18:07:51 -0500") Message-ID: <87tza7kwmt.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: 20361835ac2f847025e7fdf3cd576c4a X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 5467 [Oct 22 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release > Sounds very good, thank you, please install it. Done. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1226883307-20239-0--