bug#1230: `configure --with-ns' fails when the shell is not bash

bug#1230: `configure --with-ns' fails when the shell is not bash

[Yavor Doganov]

Package: emacs,ns
Tags: patch

$ CONFIG_SHELL=/bin/dash /bin/dash ./configure --with-ns
...
checking for X... libraries , headers 
./configure.lineno: 9373: source: not found
./configure.lineno: 9373: source: not found
./configure.lineno: 9373: source: not found
checking AppKit/AppKit.h usability... no
checking AppKit/AppKit.h presence... no
checking for AppKit/AppKit.h... no

That's because "source" is a bash feature.  But at this point one
would expect that configure should exit with an error.  However, it
continues, checks for GTK+ and finally fails for me because of missing
image librararies.  If I had them installed on this machine, it would
really configure Emacs for a GTK build.  This can't be right; if the
user says `--with-ns' he really means that.

The attached patch addresses both issues.


2008-10-23  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Use `.' instead of `source' to source
	GNUstep.conf.  Exit with an error if `--with-ns' was specified but
	<AppKit/AppKit.h> is not found.

--- configure.in	23 окт 2008 13:56:25 +0300	1.568
+++ configure.in	23 окт 2008 14:13:27 +0300	
@@ -1234,15 +1234,17 @@
      ns_appbindir=`pwd`/nextstep/Emacs.app
      ns_appresdir=`pwd`/nextstep/Emacs.app/Resources
      ns_appsrc=${srcdir}/nextstep/GNUstep/Emacs.base
-     GNUSTEP_MAKEFILES="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_MAKEFILES)"
-     GNUSTEP_SYSTEM_HEADERS="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_HEADERS)"
-     GNUSTEP_SYSTEM_LIBRARIES="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_LIBRARIES)"
+     GNUSTEP_MAKEFILES="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_MAKEFILES)"
+     GNUSTEP_SYSTEM_HEADERS="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_HEADERS)"
+     GNUSTEP_SYSTEM_LIBRARIES="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_LIBRARIES)"
      CPPFLAGS="$CPPFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      CFLAGS="$CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      REAL_CFLAGS="$REAL_CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      LDFLAGS="$LDFLAGS -L${GNUSTEP_SYSTEM_LIBRARIES}"
   fi
-  AC_CHECK_HEADER(AppKit/AppKit.h, HAVE_NS=yes)
+  AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes],
+  		  [AC_MSG_ERROR([`--with-ns' was specified, but the include
+  files are missing or cannot be compiled.])])
   NS_HAVE_NSINTEGER=yes
   AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>],
                                      [NSInteger i;])],

bug#1230: marked as done (`configure --with-ns' fails when the shell is not bash)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]


Your message dated Fri, 24 Oct 2008 00:24:34 -0400
with message-id <0f1vy6aad9.fsf@fencepost.gnu.org>
and subject line Re: bug#1230: `configure --with-ns' fails when the shell is not bash
has caused the Emacs bug report #1230,
regarding `configure --with-ns' fails when the shell is not bash
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1230: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1230
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5202 bytes --]

From: Yavor Doganov <yavor@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: `configure --with-ns' fails when the shell is not bash
Date: Thu, 23 Oct 2008 14:38:24 +0300
Message-ID: <87y70fsfrj.GNU's_Not_Unix!%yavor@gnu.org>

Package: emacs,ns
Tags: patch

$ CONFIG_SHELL=/bin/dash /bin/dash ./configure --with-ns
...
checking for X... libraries , headers 
./configure.lineno: 9373: source: not found
./configure.lineno: 9373: source: not found
./configure.lineno: 9373: source: not found
checking AppKit/AppKit.h usability... no
checking AppKit/AppKit.h presence... no
checking for AppKit/AppKit.h... no

That's because "source" is a bash feature.  But at this point one
would expect that configure should exit with an error.  However, it
continues, checks for GTK+ and finally fails for me because of missing
image librararies.  If I had them installed on this machine, it would
really configure Emacs for a GTK build.  This can't be right; if the
user says `--with-ns' he really means that.

The attached patch addresses both issues.


2008-10-23  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Use `.' instead of `source' to source
	GNUstep.conf.  Exit with an error if `--with-ns' was specified but
	<AppKit/AppKit.h> is not found.

--- configure.in	23 окт 2008 13:56:25 +0300	1.568
+++ configure.in	23 окт 2008 14:13:27 +0300	
@@ -1234,15 +1234,17 @@
      ns_appbindir=`pwd`/nextstep/Emacs.app
      ns_appresdir=`pwd`/nextstep/Emacs.app/Resources
      ns_appsrc=${srcdir}/nextstep/GNUstep/Emacs.base
-     GNUSTEP_MAKEFILES="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_MAKEFILES)"
-     GNUSTEP_SYSTEM_HEADERS="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_HEADERS)"
-     GNUSTEP_SYSTEM_LIBRARIES="$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_LIBRARIES)"
+     GNUSTEP_MAKEFILES="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_MAKEFILES)"
+     GNUSTEP_SYSTEM_HEADERS="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_HEADERS)"
+     GNUSTEP_SYSTEM_LIBRARIES="$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_SYSTEM_LIBRARIES)"
      CPPFLAGS="$CPPFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      CFLAGS="$CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      REAL_CFLAGS="$REAL_CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
      LDFLAGS="$LDFLAGS -L${GNUSTEP_SYSTEM_LIBRARIES}"
   fi
-  AC_CHECK_HEADER(AppKit/AppKit.h, HAVE_NS=yes)
+  AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes],
+  		  [AC_MSG_ERROR([`--with-ns' was specified, but the include
+  files are missing or cannot be compiled.])])
   NS_HAVE_NSINTEGER=yes
   AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>],
                                      [NSInteger i;])],



[-- Attachment #3: Type: message/rfc822, Size: 1498 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 1230-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1230: `configure --with-ns' fails when the shell is not bash
Date: Fri, 24 Oct 2008 00:24:34 -0400
Message-ID: <0f1vy6aad9.fsf@fencepost.gnu.org>


Thanks; applied.