From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1154: marked as done (C-x 4 a in struct [] diff does not work anymore) Date: Sat, 18 Oct 2008 01:00:02 -0700 Message-ID: References: <200810180753.m9I7rPsu017038@mothra.ics.uci.edu> <200810130238.m9D2cut9000668@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1224316802-26298-0" X-Trace: ger.gmane.org 1224317532 8246 80.91.229.12 (18 Oct 2008 08:12:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Oct 2008 08:12:12 +0000 (UTC) To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 18 10:13:13 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kr6vX-0001PP-Kz for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Oct 2008 10:12:48 +0200 Original-Received: from localhost ([127.0.0.1]:49590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kr6uS-0001q2-0a for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Oct 2008 04:11:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kr6t6-0001Qj-Sc for bug-gnu-emacs@gnu.org; Sat, 18 Oct 2008 04:10:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kr6t6-0001QI-19 for bug-gnu-emacs@gnu.org; Sat, 18 Oct 2008 04:10:16 -0400 Original-Received: from [199.232.76.173] (port=54870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kr6t5-0001QB-Ro for bug-gnu-emacs@gnu.org; Sat, 18 Oct 2008 04:10:15 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45093) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kr6t6-0003eb-8X for bug-gnu-emacs@gnu.org; Sat, 18 Oct 2008 04:10:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9I8A0S4029379; Sat, 18 Oct 2008 01:10:00 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9I802nx026332; Sat, 18 Oct 2008 01:00:02 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1154 X-Emacs-PR-Package: emacs,cc-mode X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21651 Archived-At: This is a multi-part message in MIME format... ------------=_1224316802-26298-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 18 Oct 2008 00:53:25 -0700 (PDT) with message-id <200810180753.m9I7rPsu017038@mothra.ics.uci.edu> and subject line Re: bug#1154: C-x 4 a in struct [] diff does not work anym= ore has caused the Emacs bug report #1154, regarding C-x 4 a in struct [] diff does not work anymore to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1154: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1154 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1224316802-26298-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.1 required=4.0 tests=AWL,BAYES_00,FOURLA, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Oct 2008 02:39:16 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9D2dBkH030974 for ; Sun, 12 Oct 2008 19:39:13 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KpDKw-0003wv-Nx for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KpDKu-0003vu-2q for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:10 -0400 Received: from [199.232.76.173] (port=36104 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpDKt-0003vr-St for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:07 -0400 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:39372) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KpDKt-0000fJ-D1 for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:08 -0400 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9D2cvkU006146 for ; Sun, 12 Oct 2008 19:38:57 -0700 (PDT) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9D2cut9000668; Sun, 12 Oct 2008 19:38:56 -0700 (PDT) Date: Sun, 12 Oct 2008 19:38:56 -0700 (PDT) Message-Id: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs@gnu.org Subject: C-x 4 a in struct [] diff does not work anymore X-Debbugs-No-Ack: yes Lines: 36 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9D2cvkU006146 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) For the patch below, with the point on the first + line, C-x 4 a adds an entry called: * emacsclient.c (]): emacs-22.2 added the correct entry: * emacsclient.c (longopts): Also, for the second hunk C-x 4 a cannot find the function name. Index: emacsclient.c =================================================================== RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v retrieving revision 1.132 diff -u -3 -p -u -p -r1.132 emacsclient.c --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 @@ -156,6 +156,7 @@ struct option longopts[] = { "help", no_argument, NULL, 'H' }, { "version", no_argument, NULL, 'V' }, { "tty", no_argument, NULL, 't' }, + { "nw", no_argument, NULL, 't' }, { "create-frame", no_argument, NULL, 'c' }, { "alternate-editor", required_argument, NULL, 'a' }, #ifndef NO_SOCKETS_IN_FILE_SYSTEM @@ -474,7 +475,7 @@ decode_options (argc, argv) while (1) { - int opt = getopt_long (argc, argv, + int opt = getopt_long_only (argc, argv, #ifndef NO_SOCKETS_IN_FILE_SYSTEM "VHnea:s:f:d:tc", #else ------------=_1224316802-26298-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.7 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1154-done) by emacsbugs.donarmstrong.com; 18 Oct 2008 07:53:40 +0000 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9I7rbna024968 for <1154-done@emacsbugs.donarmstrong.com>; Sat, 18 Oct 2008 00:53:38 -0700 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9I7rPs5014342; Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9I7rPsu017038; Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Date: Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Message-Id: <200810180753.m9I7rPsu017038@mothra.ics.uci.edu> From: Dan Nicolaescu To: Alan Mackenzie Cc: 1154-done@emacsbugs.donarmstrong.com Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore References: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> <20081017211750.GA2157@muc.de> X-Debbugs-No-Ack: yes In-Reply-To: <20081017211750.GA2157@muc.de> (Alan Mackenzie's message of "Fri, 17 Oct 2008 21:17:50 +0000") Lines: 58 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9I7rPs5014342 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu Alan Mackenzie writes: > Hi, Dan: > > I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes > the first bug (longopts). > > I can't reproduce the second bug (C-x 4 a can't find the name for the > second hunk). Could you let me know whether or not it's still a > problem. Thanks! All the issues seem fixed. Closing the bug. Thanks! > On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote: > > For the patch below, with the point on the first + line, C-x 4 a > > adds an entry called: > > > > * emacsclient.c (]): > > > > emacs-22.2 added the correct entry: > > > > * emacsclient.c (longopts): > > > > Also, for the second hunk C-x 4 a cannot find the function name. > > > > > > Index: emacsclient.c > > =================================================================== > > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v > > retrieving revision 1.132 > > diff -u -3 -p -u -p -r1.132 emacsclient.c > > --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 > > +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 > > @@ -156,6 +156,7 @@ struct option longopts[] = > > { "help", no_argument, NULL, 'H' }, > > { "version", no_argument, NULL, 'V' }, > > { "tty", no_argument, NULL, 't' }, > > + { "nw", no_argument, NULL, 't' }, > > { "create-frame", no_argument, NULL, 'c' }, > > { "alternate-editor", required_argument, NULL, 'a' }, > > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > > @@ -474,7 +475,7 @@ decode_options (argc, argv) > > > > while (1) > > { > > - int opt = getopt_long (argc, argv, > > + int opt = getopt_long_only (argc, argv, > > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > > "VHnea:s:f:d:tc", > > #else > > > > -- > Alan Mackenzie (Nuremberg, Germany). ------------=_1224316802-26298-0--