bug#1154: C-x 4 a in struct [] diff does not work anymore

bug#1154: C-x 4 a in struct [] diff does not work anymore

[Dan Nicolaescu]

For the patch below, with the point on the first + line, C-x 4 a
adds an entry called:

     * emacsclient.c (]):

emacs-22.2 added the correct entry:

     * emacsclient.c (longopts): 

Also, for the second hunk C-x 4 a cannot find the function name.


Index: emacsclient.c
===================================================================
RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.132
diff -u -3 -p -u -p -r1.132 emacsclient.c
--- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
+++ emacsclient.c	13 Oct 2008 01:34:25 -0000
@@ -156,6 +156,7 @@ struct option longopts[] =
   { "help",	no_argument,	   NULL, 'H' },
   { "version",	no_argument,	   NULL, 'V' },
   { "tty",	no_argument,       NULL, 't' },
+  { "nw",	no_argument,       NULL, 't' },
   { "create-frame", no_argument,   NULL, 'c' },
   { "alternate-editor", required_argument, NULL, 'a' },
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
@@ -474,7 +475,7 @@ decode_options (argc, argv)
 
   while (1)
     {
-      int opt = getopt_long (argc, argv,
+      int opt = getopt_long_only (argc, argv,
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
 			     "VHnea:s:f:d:tc",
 #else

bug#1154: C-x 4 a in struct [] diff does not work anymore

[Alan Mackenzie]

Hi, Dan:

I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes
the first bug (longopts).

I can't reproduce the second bug (C-x 4 a can't find the name for the
second hunk).  Could you let me know whether or not it's still a
problem.  Thanks!

On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote:
> For the patch below, with the point on the first + line, C-x 4 a
> adds an entry called:
> 
>      * emacsclient.c (]):
> 
> emacs-22.2 added the correct entry:
> 
>      * emacsclient.c (longopts): 
> 
> Also, for the second hunk C-x 4 a cannot find the function name.
> 
> 
> Index: emacsclient.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
> retrieving revision 1.132
> diff -u -3 -p -u -p -r1.132 emacsclient.c
> --- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
> +++ emacsclient.c	13 Oct 2008 01:34:25 -0000
> @@ -156,6 +156,7 @@ struct option longopts[] =
>    { "help",	no_argument,	   NULL, 'H' },
>    { "version",	no_argument,	   NULL, 'V' },
>    { "tty",	no_argument,       NULL, 't' },
> +  { "nw",	no_argument,       NULL, 't' },
>    { "create-frame", no_argument,   NULL, 'c' },
>    { "alternate-editor", required_argument, NULL, 'a' },
>  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
> @@ -474,7 +475,7 @@ decode_options (argc, argv)
>  
>    while (1)
>      {
> -      int opt = getopt_long (argc, argv,
> +      int opt = getopt_long_only (argc, argv,
>  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
>  			     "VHnea:s:f:d:tc",
>  #else
> 

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#1154: marked as done (C-x 4 a in struct [] diff does not work anymore)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]


Your message dated Sat, 18 Oct 2008 00:53:25 -0700 (PDT)
with message-id <200810180753.m9I7rPsu017038@mothra.ics.uci.edu>
and subject line Re: bug#1154: C-x 4 a in struct [] diff does not work anymore
has caused the Emacs bug report #1154,
regarding C-x 4 a in struct [] diff does not work anymore
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1154: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1154
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3563 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs@gnu.org
Subject: C-x 4 a in struct [] diff does not work anymore
Date: Sun, 12 Oct 2008 19:38:56 -0700 (PDT)
Message-ID: <200810130238.m9D2cut9000668@mothra.ics.uci.edu>

For the patch below, with the point on the first + line, C-x 4 a
adds an entry called:

     * emacsclient.c (]):

emacs-22.2 added the correct entry:

     * emacsclient.c (longopts): 

Also, for the second hunk C-x 4 a cannot find the function name.


Index: emacsclient.c
===================================================================
RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.132
diff -u -3 -p -u -p -r1.132 emacsclient.c
--- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
+++ emacsclient.c	13 Oct 2008 01:34:25 -0000
@@ -156,6 +156,7 @@ struct option longopts[] =
   { "help",	no_argument,	   NULL, 'H' },
   { "version",	no_argument,	   NULL, 'V' },
   { "tty",	no_argument,       NULL, 't' },
+  { "nw",	no_argument,       NULL, 't' },
   { "create-frame", no_argument,   NULL, 'c' },
   { "alternate-editor", required_argument, NULL, 'a' },
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
@@ -474,7 +475,7 @@ decode_options (argc, argv)
 
   while (1)
     {
-      int opt = getopt_long (argc, argv,
+      int opt = getopt_long_only (argc, argv,
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
 			     "VHnea:s:f:d:tc",
 #else




[-- Attachment #3: Type: message/rfc822, Size: 3710 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: Alan Mackenzie <acm@muc.de>
Cc: 1154-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore
Date: Sat, 18 Oct 2008 00:53:25 -0700 (PDT)
Message-ID: <200810180753.m9I7rPsu017038@mothra.ics.uci.edu>

Alan Mackenzie <acm@muc.de> writes:

  > Hi, Dan:
  > 
  > I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes
  > the first bug (longopts).
  > 
  > I can't reproduce the second bug (C-x 4 a can't find the name for the
  > second hunk).  Could you let me know whether or not it's still a
  > problem.  Thanks!

All the issues seem fixed.  Closing the bug.

Thanks!



  > On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote:
  > > For the patch below, with the point on the first + line, C-x 4 a
  > > adds an entry called:
  > > 
  > >      * emacsclient.c (]):
  > > 
  > > emacs-22.2 added the correct entry:
  > > 
  > >      * emacsclient.c (longopts): 
  > > 
  > > Also, for the second hunk C-x 4 a cannot find the function name.
  > > 
  > > 
  > > Index: emacsclient.c
  > > ===================================================================
  > > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
  > > retrieving revision 1.132
  > > diff -u -3 -p -u -p -r1.132 emacsclient.c
  > > --- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
  > > +++ emacsclient.c	13 Oct 2008 01:34:25 -0000
  > > @@ -156,6 +156,7 @@ struct option longopts[] =
  > >    { "help",	no_argument,	   NULL, 'H' },
  > >    { "version",	no_argument,	   NULL, 'V' },
  > >    { "tty",	no_argument,       NULL, 't' },
  > > +  { "nw",	no_argument,       NULL, 't' },
  > >    { "create-frame", no_argument,   NULL, 'c' },
  > >    { "alternate-editor", required_argument, NULL, 'a' },
  > >  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
  > > @@ -474,7 +475,7 @@ decode_options (argc, argv)
  > >  
  > >    while (1)
  > >      {
  > > -      int opt = getopt_long (argc, argv,
  > > +      int opt = getopt_long_only (argc, argv,
  > >  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
  > >  			     "VHnea:s:f:d:tc",
  > >  #else
  > > 
  > 
  > -- 
  > Alan Mackenzie (Nuremberg, Germany).